Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): 2.162.0 #31715

Merged
merged 39 commits into from
Oct 10, 2024
Merged

chore(release): 2.162.0 #31715

merged 39 commits into from
Oct 10, 2024

Conversation

aws-cdk-automation
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation commented Oct 10, 2024

See CHANGELOG

go-to-k and others added 30 commits October 3, 2024 23:26
…luster (#31280)

### Issue # (if applicable)

Closes #31116 .

### Reason for this change



It was not possible to call the `grantDataApiAccess` method for an imported database cluster.

Because the imported database cluster always has the `enableDataApi` with false.

https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-rds/lib/cluster.ts#L983

```ts
class ImportedDatabaseCluster extends DatabaseClusterBase implements IDatabaseCluster {
  // ...
  protected readonly enableDataApi = false;
```

But the `grantDataApiAccess` throws an error when the `enableDataApi` is set to false.

https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-rds/lib/cluster.ts#L523-L526

```ts
  public grantDataApiAccess(grantee: iam.IGrantable): iam.Grant {
    if (this.enableDataApi === false) {
      throw new Error('Cannot grant Data API access when the Data API is disabled');
    }
    // ...
}
```

### Description of changes



Added the property `dataApiEnabled` to attributes for the imported database cluster.

If the `dataApiEnabled` to the attributes is set to true, the `enableDataApi` in the imported cluster will be set to true and the `grantDataApiAccess` can be called.

### Description of how you validated changes



Unit and integ tests.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Issue # (if applicable)

Closes #<issue number here>.

### Reason for this change



The doc for `awsManagedKey` method is wrong.

- Configure server-side encryption using **a DynamoDB owned** key.

### Description of changes



Fixed.

- Configure server-side encryption using **an AWS managed** key.

### Description of how you validated changes



### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…31592)

Since JavaScript is single-threaded, `Promise.all()` will only ever be used for I/O-bound tasks. However, I/O-parallelism isn't free either. Every async I/O-performing task launched will consume some FDs, and their amount is limited. If the amount of promises launched is a function of the input the program runs on, the system FDs might be exhausted. Some concurrency limit must be introduced.

This linter rule exists to remind the programmer of that fact. It triggers on every `Promise.all()` invocation and cannot be resolved; the only solution is to think about it, and then silence this rule as proof that you thought about it.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…stination` and change type from array to single IDestination (#31630)

### Reason for this change

Setting a destination for your Delivery Stream was previously done by passing in an array of Destinations but with a restriction that there there could only be one Destination in that array. This property type does not make sense for the current user experience (have an array but can only specify one destination) and also does not align with the behaviour in the AWS Console which only allows you to select a single destination. 

If Kinesis Firehose ever supports multiple destinations in the future then we can add a new property to support that which will not be a breaking change. 

### Description of changes

BREAKING CHANGE: replaced `destinations` property with `destination` (singular) and changed the type from array of Destinations to a single Destination. Old behaviour would only allow an array with a single Destination to be passed in anyway.

### Description of how you validated changes

unit tests + no integ snapshot changes. 

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Issue # (if applicable)

Closes #[31654](#31654).

### Reason for this change

This reverts commit 0755561.

### Description of changes

Changes introduced regression in amplify app for nested stacks, reverting it.

### Description of how you validated changes

Validated with local build

### Checklist
- [ ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…itStackName` and `qualifier` (#31636)

Closes #29179 

### Reason for this change

If your account is bootstrapped with a custom `toolkitStackName` or `qualifier`, then running `cdk diff` does not work for large diff templates of over 50 KiB in size.

### Description of changes

The `toolkitStackName` was not passed down all the way through the `cdk diff` code path - this PR fixes the issue by adding the optional `toolkitStackName` property to the `DiffOptions` interface in `cdk-toolkit.ts` and passing that value all the way through the diff code path to the `uploadBodyParameterAndCreateChangeSet` function in `cloudformation.ts`, where the template asset is built and published.

### Description of how you validated changes

I created a CDK app locally and ran the commands (exactly following the reproduction steps from the original issue) using the CLI build from this PR and was able to successfully run `cdk diff` without needing to pass in the `--toolkit-stack-name` flag. 

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…ns (#31658)

#31624 is too big so I'm splitting out the parts that I can without causing type conflicts. This upgrades all sdk v3 versions to the most recent version used in every region by lambda's node18 and node20 runtime bundle.

Closes #<issue number here>.

### Reason for this change



### Description of changes



### Description of how you validated changes



### Checklist
- [ ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
We have cli integ tests for nested stacks, but not for nested stacks-in-nested stacks.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
)

Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 45.0.2 to 45.0.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/tj-actions/changed-files/releases">tj-actions/changed-files's releases</a>.</em></p>
<blockquote>
<h2>v45.0.3</h2>
<h2>What's Changed</h2>
<ul>
<li>Upgraded to v45.0.2 by <a href="https://github.com/tj-actions-bot"><code>@​tj-actions-bot</code></a> in <a href="https://redirect.github.com/tj-actions/changed-files/pull/2282">tj-actions/changed-files#2282</a></li>
<li>chore(deps): update dependency eslint to v8.57.1 by <a href="https://github.com/renovate"><code>@​renovate</code></a> in <a href="https://redirect.github.com/tj-actions/changed-files/pull/2284">tj-actions/changed-files#2284</a></li>
<li>chore(deps): update peter-evans/create-pull-request action to v7.0.5 by <a href="https://github.com/renovate"><code>@​renovate</code></a> in <a href="https://redirect.github.com/tj-actions/changed-files/pull/2286">tj-actions/changed-files#2286</a></li>
<li>chore(deps): update actions/setup-node action to v4.0.4 by <a href="https://github.com/renovate"><code>@​renovate</code></a> in <a href="https://redirect.github.com/tj-actions/changed-files/pull/2287">tj-actions/changed-files#2287</a></li>
<li>chore(deps): lock file maintenance by <a href="https://github.com/renovate"><code>@​renovate</code></a> in <a href="https://redirect.github.com/tj-actions/changed-files/pull/2289">tj-actions/changed-files#2289</a></li>
<li>chore(deps): update dependency <code>@​types/lodash</code> to v4.17.9 by <a href="https://github.com/renovate"><code>@​renovate</code></a> in <a href="https://redirect.github.com/tj-actions/changed-files/pull/2291">tj-actions/changed-files#2291</a></li>
<li>chore(deps): update dependency <code>@​vercel/ncc</code> to v0.38.2 by <a href="https://github.com/renovate"><code>@​renovate</code></a> in <a href="https://redirect.github.com/tj-actions/changed-files/pull/2290">tj-actions/changed-files#2290</a></li>
<li>chore(deps): update dependency <code>@​types/node</code> to v22.6.1 by <a href="https://github.com/renovate"><code>@​renovate</code></a> in <a href="https://redirect.github.com/tj-actions/changed-files/pull/2292">tj-actions/changed-files#2292</a></li>
<li>chore(deps): update dependency <code>@​types/node</code> to v22.7.0 by <a href="https://github.com/renovate"><code>@​renovate</code></a> in <a href="https://redirect.github.com/tj-actions/changed-files/pull/2294">tj-actions/changed-files#2294</a></li>
<li>fix: test for since last remote commit check on pull_request closed by <a href="https://github.com/jackton1"><code>@​jackton1</code></a> in <a href="https://redirect.github.com/tj-actions/changed-files/pull/2295">tj-actions/changed-files#2295</a></li>
<li>chore(deps): update dependency <code>@​types/node</code> to v22.7.2 by <a href="https://github.com/renovate"><code>@​renovate</code></a> in <a href="https://redirect.github.com/tj-actions/changed-files/pull/2297">tj-actions/changed-files#2297</a></li>
<li>docs: Update README.md by <a href="https://github.com/jackton1"><code>@​jackton1</code></a> in <a href="https://redirect.github.com/tj-actions/changed-files/pull/2296">tj-actions/changed-files#2296</a></li>
<li>chore(deps): update dependency <code>@​types/node</code> to v22.7.3 by <a href="https://github.com/renovate"><code>@​renovate</code></a> in <a href="https://redirect.github.com/tj-actions/changed-files/pull/2298">tj-actions/changed-files#2298</a></li>
<li>chore(deps): update dependency <code>@​types/node</code> to v22.7.4 by <a href="https://github.com/renovate"><code>@​renovate</code></a> in <a href="https://redirect.github.com/tj-actions/changed-files/pull/2299">tj-actions/changed-files#2299</a></li>
<li>chore(deps): lock file maintenance by <a href="https://github.com/renovate"><code>@​renovate</code></a> in <a href="https://redirect.github.com/tj-actions/changed-files/pull/2301">tj-actions/changed-files#2301</a></li>
<li>docs: Update README.md by <a href="https://github.com/jackton1"><code>@​jackton1</code></a> in <a href="https://redirect.github.com/tj-actions/changed-files/pull/2300">tj-actions/changed-files#2300</a></li>
<li>fix: bug with files ignore yaml patterns not filtering the list of files by <a href="https://github.com/jackton1"><code>@​jackton1</code></a> in <a href="https://redirect.github.com/tj-actions/changed-files/pull/2304">tj-actions/changed-files#2304</a></li>
<li>fix(deps): update dependency <code>@​actions/core</code> to v1.11.0 by <a href="https://github.com/renovate"><code>@​renovate</code></a> in <a href="https://redirect.github.com/tj-actions/changed-files/pull/2305">tj-actions/changed-files#2305</a></li>
<li>chore(deps): update dependency <code>@​types/lodash</code> to v4.17.10 by <a href="https://github.com/renovate"><code>@​renovate</code></a> in <a href="https://redirect.github.com/tj-actions/changed-files/pull/2306">tj-actions/changed-files#2306</a></li>
<li>fix: overwriting yaml filter patterns by <a href="https://github.com/jackton1"><code>@​jackton1</code></a> in <a href="https://redirect.github.com/tj-actions/changed-files/pull/2307">tj-actions/changed-files#2307</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/tj-actions/changed-files/compare/v45...v45.0.3">https://github.com/tj-actions/changed-files/compare/v45...v45.0.3</a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/tj-actions/changed-files/blob/main/HISTORY.md">tj-actions/changed-files's changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<h1><a href="https://github.com/tj-actions/changed-files/compare/v45.0.2...v45.0.3">45.0.3</a> - (2024-10-03)</h1>
<h2>🐛 Bug Fixes</h2>
<ul>
<li>Overwriting yaml filter patterns (<a href="https://redirect.github.com/tj-actions/changed-files/issues/2307">#2307</a>) (<a href="https://github.com/tj-actions/changed-files/commit/c3a1bb2c992d77180ae65be6ae6c166cf40f857c">c3a1bb2</a>)  - (Tonye Jack)</li>
<li><strong>deps:</strong> Update dependency <code>@​actions/core</code> to v1.11.0 (<a href="https://github.com/tj-actions/changed-files/commit/9d4f8fea5842800088922c102ca4538178833673">9d4f8fe</a>)  - (renovate[bot])</li>
<li>Bug with files ignore yaml patterns not filtering the list of files (<a href="https://redirect.github.com/tj-actions/changed-files/issues/2304">#2304</a>) (<a href="https://github.com/tj-actions/changed-files/commit/d0cf1645b795cec63a72fbe846e317bf9178b010">d0cf164</a>)  - (Tonye Jack)</li>
<li>Test for since last remote commit check on pull_request closed (<a href="https://redirect.github.com/tj-actions/changed-files/issues/2295">#2295</a>) (<a href="https://github.com/tj-actions/changed-files/commit/e753fb0a6337371498559e2a3aba56403f65b949">e753fb0</a>)  - (Tonye Jack)</li>
</ul>
<h2>➕ Add</h2>
<ul>
<li>Added missing changes and modified dist assets.
(<a href="https://github.com/tj-actions/changed-files/commit/36d5b9dda5f13e931f09f5033a176efb2f03e605">36d5b9d</a>)  - (GitHub Action)</li>
<li>Added missing changes and modified dist assets.
(<a href="https://github.com/tj-actions/changed-files/commit/4dbe54f96e17faab8feb2c0c323ff84faa4512d2">4dbe54f</a>)  - (GitHub Action)</li>
</ul>
<h2>📚 Documentation</h2>
<ul>
<li>Update README.md (<a href="https://redirect.github.com/tj-actions/changed-files/issues/2300">#2300</a>) (<a href="https://github.com/tj-actions/changed-files/commit/641e22af4a94c93fb947ec20045f1ea036579b71">641e22a</a>)  - (Tonye Jack)</li>
<li>Update README.md (<a href="https://redirect.github.com/tj-actions/changed-files/issues/2296">#2296</a>) (<a href="https://github.com/tj-actions/changed-files/commit/1a71128b6a67056616a4284adea37ae02b564f16">1a71128</a>)  - (Tonye Jack)</li>
</ul>
<h2>⚙️ Miscellaneous Tasks</h2>
<ul>
<li><strong>deps:</strong> Update dependency <code>@​types/lodash</code> to v4.17.10 (<a href="https://github.com/tj-actions/changed-files/commit/27843f166754bb92655dfb6102aaa76ee2faf762">27843f1</a>)  - (renovate[bot])</li>
<li><strong>deps:</strong> Lock file maintenance (<a href="https://github.com/tj-actions/changed-files/commit/8a4a9757b70fd0abbb3230709dd2efe832689c93">8a4a975</a>)  - (renovate[bot])</li>
<li><strong>deps:</strong> Update dependency <code>@​types/node</code> to v22.7.4 (<a href="https://github.com/tj-actions/changed-files/commit/6bfa9e7a9a0cf32f41834ac67d934c8930978a10">6bfa9e7</a>)  - (renovate[bot])</li>
<li><strong>deps:</strong> Update dependency <code>@​types/node</code> to v22.7.3 (<a href="https://github.com/tj-actions/changed-files/commit/625dbd682e29fb911c89c6a72b0e723206519c2c">625dbd6</a>)  - (renovate[bot])</li>
<li><strong>deps:</strong> Update dependency <code>@​types/node</code> to v22.7.2 (<a href="https://github.com/tj-actions/changed-files/commit/c29c1d3dd08b5aa5936b4f5eb5916104e8eb028b">c29c1d3</a>)  - (renovate[bot])</li>
<li><strong>deps:</strong> Update dependency <code>@​types/node</code> to v22.7.0 (<a href="https://github.com/tj-actions/changed-files/commit/e21f1a3077058afe256713170452e771df5b8693">e21f1a3</a>)  - (renovate[bot])</li>
<li><strong>deps:</strong> Update dependency <code>@​types/node</code> to v22.6.1 (<a href="https://github.com/tj-actions/changed-files/commit/792230fcedfb6be06f8b82405336b8c64d072307">792230f</a>)  - (renovate[bot])</li>
<li><strong>deps:</strong> Update dependency <code>@​vercel/ncc</code> to v0.38.2 (<a href="https://github.com/tj-actions/changed-files/commit/537f1c63183dc57ec71788609090fd4eb34d0645">537f1c6</a>)  - (renovate[bot])</li>
<li><strong>deps:</strong> Update dependency <code>@​types/lodash</code> to v4.17.9 (<a href="https://github.com/tj-actions/changed-files/commit/82587d885833b45b38f65922b2bab11734b2e666">82587d8</a>)  - (renovate[bot])</li>
<li><strong>deps:</strong> Lock file maintenance (<a href="https://github.com/tj-actions/changed-files/commit/eda64a62bda002f91918e506fa907562d648e723">eda64a6</a>)  - (renovate[bot])</li>
<li><strong>deps:</strong> Update actions/setup-node action to v4.0.4 (<a href="https://github.com/tj-actions/changed-files/commit/4d5444c2c31b579919a04a4452abc5d87e4646ad">4d5444c</a>)  - (renovate[bot])</li>
<li><strong>deps:</strong> Update peter-evans/create-pull-request action to v7.0.5 (<a href="https://github.com/tj-actions/changed-files/commit/c2e104be2f2a434709460be32ce45f24994f8bd4">c2e104b</a>)  - (renovate[bot])</li>
<li><strong>deps:</strong> Update dependency eslint to v8.57.1 (<a href="https://github.com/tj-actions/changed-files/commit/eed685a419db057cbbbc6590e9ecec893f8e5c27">eed685a</a>)  - (renovate[bot])</li>
</ul>
<h2>⬆️ Upgrades</h2>
<ul>
<li>Upgraded to v45.0.2 (<a href="https://redirect.github.com/tj-actions/changed-files/issues/2282">#2282</a>)</li>
</ul>
<p>Co-authored-by: jackton1 <a href="mailto:[email protected]">[email protected]</a> (<a href="https://github.com/tj-actions/changed-files/commit/6f538bb83f28b3289d5cd90d638bbdca3e478ebe">6f538bb</a>)  - (tj-actions[bot])</p>
<h1><a href="https://github.com/tj-actions/changed-files/compare/v45.0.1...v45.0.2">45.0.2</a> - (2024-09-16)</h1>
<h2>🐛 Bug Fixes</h2>
<ul>
<li><strong>deps:</strong> Update dependency yaml to v2.5.1 (<a href="https://github.com/tj-actions/changed-files/commit/c7114f61a18a89477ae75bf8f896d395bc8b76ea">c7114f6</a>)  - (renovate[bot])</li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/tj-actions/changed-files/commit/c3a1bb2c992d77180ae65be6ae6c166cf40f857c"><code>c3a1bb2</code></a> fix: overwriting yaml filter patterns (<a href="https://redirect.github.com/tj-actions/changed-files/issues/2307">#2307</a>)</li>
<li><a href="https://github.com/tj-actions/changed-files/commit/27843f166754bb92655dfb6102aaa76ee2faf762"><code>27843f1</code></a> chore(deps): update dependency <code>@​types/lodash</code> to v4.17.10</li>
<li><a href="https://github.com/tj-actions/changed-files/commit/36d5b9dda5f13e931f09f5033a176efb2f03e605"><code>36d5b9d</code></a> Added missing changes and modified dist assets.</li>
<li><a href="https://github.com/tj-actions/changed-files/commit/9d4f8fea5842800088922c102ca4538178833673"><code>9d4f8fe</code></a> fix(deps): update dependency <code>@​actions/core</code> to v1.11.0</li>
<li><a href="https://github.com/tj-actions/changed-files/commit/d0cf1645b795cec63a72fbe846e317bf9178b010"><code>d0cf164</code></a> fix: bug with files ignore yaml patterns not filtering the list of files (<a href="https://redirect.github.com/tj-actions/changed-files/issues/2304">#2304</a>)</li>
<li><a href="https://github.com/tj-actions/changed-files/commit/641e22af4a94c93fb947ec20045f1ea036579b71"><code>641e22a</code></a> docs: Update README.md (<a href="https://redirect.github.com/tj-actions/changed-files/issues/2300">#2300</a>)</li>
<li><a href="https://github.com/tj-actions/changed-files/commit/8a4a9757b70fd0abbb3230709dd2efe832689c93"><code>8a4a975</code></a> chore(deps): lock file maintenance</li>
<li><a href="https://github.com/tj-actions/changed-files/commit/6bfa9e7a9a0cf32f41834ac67d934c8930978a10"><code>6bfa9e7</code></a> chore(deps): update dependency <code>@​types/node</code> to v22.7.4</li>
<li><a href="https://github.com/tj-actions/changed-files/commit/625dbd682e29fb911c89c6a72b0e723206519c2c"><code>625dbd6</code></a> chore(deps): update dependency <code>@​types/node</code> to v22.7.3</li>
<li><a href="https://github.com/tj-actions/changed-files/commit/1a71128b6a67056616a4284adea37ae02b564f16"><code>1a71128</code></a> docs: Update README.md (<a href="https://redirect.github.com/tj-actions/changed-files/issues/2296">#2296</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/tj-actions/changed-files/compare/48d8f15b2aaa3d255ca5af3eba4870f807ce6b3c...c3a1bb2c992d77180ae65be6ae6c166cf40f857c">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=tj-actions/changed-files&package-manager=github_actions&previous-version=45.0.2&new-version=45.0.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>
This is a re-draft of #31407.  All description and motivation of the previous PR still apply.

The previous PR caused a regression because some `CREATE_IN_PROGRESS` events for CloudFormation do not have a `PhysicalResourceId`.

Fix that issue in this PR. Update the existing unit test that was supposed to catch this issue previously, it did not set a `ResourceStatus` which caused the event to be skipped for the wrong reason.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Updates the L1 CloudFormation resource definitions with the latest changes from `@aws-cdk/aws-service-spec`

**L1 CloudFormation resource definition changes:**
```
├[~] service aws-b2bi
│ └ resources
│    ├[~] resource AWS::B2BI::Capability
│    │ └ types
│    │    ├[~] type EdiType
│    │    │ ├  - documentation: Specifies the details for the EDI standard that is being used for the transformer. Currently, only X12 is supported. X12 is a set of standards and corresponding messages that define specific business documents.
│    │    │ │  + documentation: undefined
│    │    │ └ properties
│    │    │    └ X12Details: (documentation changed)
│    │    └[~] type S3Location
│    │      └  - documentation: Specifies the details for the Amazon S3 file location that is being used with AWS B2BI Data Interchange. File locations in Amazon S3 are identified using a combination of the bucket and key.
│    │         + documentation: Specifies the details for the Amazon S3 file location that is being used with AWS B2B Data Interchange. File locations in Amazon S3 are identified using a combination of the bucket and key.
│    └[~] resource AWS::B2BI::Transformer
│      ├  - documentation: Creates a transformer. A transformer describes how to process the incoming EDI documents and extract the necessary information to the output file.
│      │  + documentation: Creates a transformer. AWS B2B Data Interchange currently supports two scenarios:
│      │  - *Inbound EDI* : the AWS customer receives an EDI file from their trading partner. AWS B2B Data Interchange converts this EDI file into a JSON or XML file with a service-defined structure. A mapping template provided by the customer, in JSONata or XSLT format, is optionally applied to this file to produce a JSON or XML file with the structure the customer requires.
│      │  - *Outbound EDI* : the AWS customer has a JSON or XML file containing data that they wish to use in an EDI file. A mapping template, provided by the customer (in either JSONata or XSLT format) is applied to this file to generate a JSON or XML file in the service-defined structure. This file is then converted to an EDI file.
│      │  > The following fields are provided for backwards compatibility only: `fileFormat` , `mappingTemplate` , `ediType` , and `sampleDocument` .
│      │  > 
│      │  > - Use the `mapping` data type in place of `mappingTemplate` and `fileFormat`
│      │  > - Use the `sampleDocuments` data type in place of `sampleDocument`
│      │  > - Use either the `inputConversion` or `outputConversion` in place of `ediType`
│      └ types
│         └[~] type EdiType
│           ├  - documentation: Specifies the details for the EDI standard that is being used for the transformer. Currently, only X12 is supported. X12 is a set of standards and corresponding messages that define specific business documents.
│           │  + documentation: undefined
│           └ properties
│              └ X12Details: (documentation changed)
├[~] service aws-cloudformation
│ └ resources
│    └[~] resource AWS::CloudFormation::CustomResource
│      └ properties
│         └[+] ServiceTimeout: integer
├[~] service aws-emr
│ └ resources
│    ├[~] resource AWS::EMR::Cluster
│    │ └ types
│    │    ├[~] type InstanceFleetConfig
│    │    │ └ properties
│    │    │    └[+] ResizeSpecifications: InstanceFleetResizingSpecifications
│    │    ├[+] type InstanceFleetResizingSpecifications
│    │    │ ├  name: InstanceFleetResizingSpecifications
│    │    │ └ properties
│    │    │    ├OnDemandResizeSpecification: OnDemandResizingSpecification
│    │    │    └SpotResizeSpecification: SpotResizingSpecification
│    │    ├[~] type InstanceTypeConfig
│    │    │ └ properties
│    │    │    └[+] Priority: number
│    │    ├[+] type OnDemandCapacityReservationOptions
│    │    │ ├  name: OnDemandCapacityReservationOptions
│    │    │ └ properties
│    │    │    ├UsageStrategy: string
│    │    │    ├CapacityReservationResourceGroupArn: string
│    │    │    └CapacityReservationPreference: string
│    │    ├[~] type OnDemandProvisioningSpecification
│    │    │ └ properties
│    │    │    └[+] CapacityReservationOptions: OnDemandCapacityReservationOptions
│    │    ├[+] type OnDemandResizingSpecification
│    │    │ ├  name: OnDemandResizingSpecification
│    │    │ └ properties
│    │    │    ├CapacityReservationOptions: OnDemandCapacityReservationOptions
│    │    │    ├AllocationStrategy: string
│    │    │    └TimeoutDurationMinutes: integer
│    │    └[+] type SpotResizingSpecification
│    │      ├  name: SpotResizingSpecification
│    │      └ properties
│    │         ├AllocationStrategy: string
│    │         └TimeoutDurationMinutes: integer
│    └[~] resource AWS::EMR::InstanceFleetConfig
│      ├ properties
│      │  └[+] ResizeSpecifications: InstanceFleetResizingSpecifications
│      └ types
│         ├[+] type InstanceFleetResizingSpecifications
│         │ ├  name: InstanceFleetResizingSpecifications
│         │ └ properties
│         │    ├OnDemandResizeSpecification: OnDemandResizingSpecification
│         │    └SpotResizeSpecification: SpotResizingSpecification
│         ├[~] type InstanceTypeConfig
│         │ └ properties
│         │    └[+] Priority: number
│         ├[+] type OnDemandCapacityReservationOptions
│         │ ├  name: OnDemandCapacityReservationOptions
│         │ └ properties
│         │    ├UsageStrategy: string
│         │    ├CapacityReservationResourceGroupArn: string
│         │    └CapacityReservationPreference: string
│         ├[~] type OnDemandProvisioningSpecification
│         │ └ properties
│         │    └[+] CapacityReservationOptions: OnDemandCapacityReservationOptions
│         ├[+] type OnDemandResizingSpecification
│         │ ├  name: OnDemandResizingSpecification
│         │ └ properties
│         │    ├CapacityReservationOptions: OnDemandCapacityReservationOptions
│         │    ├AllocationStrategy: string
│         │    └TimeoutDurationMinutes: integer
│         └[+] type SpotResizingSpecification
│           ├  name: SpotResizingSpecification
│           └ properties
│              ├AllocationStrategy: string
│              └TimeoutDurationMinutes: integer
├[~] service aws-glue
│ └ resources
│    └[~] resource AWS::Glue::Job
│      ├ properties
│      │  └ JobRunQueuingEnabled: (documentation changed)
│      └ attributes
│         └ Id: (documentation changed)
├[~] service aws-iot
│ └ resources
│    └[~] resource AWS::IoT::DomainConfiguration
│      ├ properties
│      │  ├[+] ApplicationProtocol: string
│      │  ├[+] AuthenticationType: string
│      │  └[+] ClientCertificateConfig: ClientCertificateConfig
│      └ types
│         └[+] type ClientCertificateConfig
│           ├  name: ClientCertificateConfig
│           └ properties
│              └ClientCertificateCallbackArn: string
├[~] service aws-iotsitewise
│ └ resources
│    └[~] resource AWS::IoTSiteWise::AssetModel
│      └ types
│         └[~] type AssetModelProperty
│           └ properties
│              └ DataType: (documentation changed)
├[~] service aws-quicksight
│ └ resources
│    └[~] resource AWS::QuickSight::Folder
│      ├  - documentation: Definition of the AWS::QuickSight::Folder Resource Type.
│      │  + documentation: Creates an empty shared folder.
│      ├ properties
│      │  ├ FolderId: (documentation changed)
│      │  ├ FolderType: (documentation changed)
│      │  ├ Name: (documentation changed)
│      │  ├ ParentFolderArn: (documentation changed)
│      │  └ SharingModel: (documentation changed)
│      └ attributes
│         ├ Arn: (documentation changed)
│         ├ CreatedTime: (documentation changed)
│         └ LastUpdatedTime: (documentation changed)
├[~] service aws-rds
│ └ resources
│    ├[~] resource AWS::RDS::DBInstance
│    │ └ properties
│    │    └ DBSnapshotIdentifier: (documentation changed)
│    └[~] resource AWS::RDS::GlobalCluster
│      └ properties
│         └ Tags: (documentation changed)
├[~] service aws-route53resolver
│ └ resources
│    └[~] resource AWS::Route53Resolver::ResolverRule
│      └ types
│         └[~] type TargetAddress
│           └ properties
│              └ Protocol: (documentation changed)
└[~] service aws-s3
  └ resources
     └[~] resource AWS::S3::Bucket
       └ types
          └[~] type LifecycleConfiguration
            └ properties
               ├ Rules: (documentation changed)
               └[+] TransitionDefaultMinimumObjectSize: string
```
### Issue # (if applicable)

Closes #<issue number here>.

### Reason for this change

Because there is no `ownerContact` prop on the aws-appsync graphqlapi.ts L2 layer.

### Description of changes

Added `ownerContact` prop on the aws-appsync graphqlapi.ts L2 layer.

### Description of how you validated changes

Added both of unit test and integration test.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…31576)

### Issue # (if applicable)

Closes #<issue number here>.

### Reason for this change

By using Amazon owned s3 bucket physical names, we remove the possibility of documenting customer owned buckets in our examples. 

### Description of changes

Change physical S3 bucket names such as `my-bucket` to Amazon owned ones such as `amzn-s3-demo-bucket`. 

### Description of how you validated changes



### Checklist
- [X] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
#31615)

### Issue # (if applicable)

Closes #30390 . 

### Reason for this change

This is extending a closed PR #30484 by @jwoehrle . I couldn't update that PR so I am creating this new one.

Reason for this change is due to a AWS ECS campaign where they are asking customers to add task definition revision number (or wildcard as the revision number) to IAM policies.

### Description of changes

When adding permission to the Events Role to allow it to use the task definition, check if the task definition arn has a revision number, if yes, do nothing, if not, add the wildcard `*`. This is only done when the task definition arn is not using any token.

### Description of how you validated changes

Unit tests and Integ tests are added.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Add EventBridge event bus as a Pipes target.
…rvice) (#31374)

### Issue # (if applicable)

Closes #31181.

### Reason for this change

In the `ecs.ExternalService` class (ECS Anywhere), the `enableExecuteCommand` property cannot be set to true, so it is not possible to enable ECS exec.
However, the [documentation](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/ecs-exec.html) states that ECS Anywhere supports ECS Exec.

> ECS Exec is supported for tasks that run on the following infrastructure:
> Linux and Windows containers on external instances (Amazon ECS Anywhere)



### Description of changes
Remove unnecessary if statement.



### Description of how you validated changes
Fix an unit test.



### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Issue # (if applicable)

Closes #31663.

### Reason for this change

Cloudformation supports create an account audit configuration but AWS CDK doesn't support it.

### Description of changes

- Define `IAccountAuditConfiguration`
- Define `AccountAuditConfiguration` class and `AccountAuditConfigurationProps`

I couldn't find documentation regarding the required policies for the role when executing an audit, but when enabling the audit configuration through the management console, it was set to use a "AWSIoTDeviceDefenderAudit" managed policy. 
This implementation follows that same approach.

<img width="624" alt="スクリーンショット 2024-10-05 15 05 10" src="https://github.com/user-attachments/assets/61f9d0bb-2606-4b2d-9c8f-8245f7f47c68">

### Description of how you validated changes

Add both unit and integ tests

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…gs (#30759)

### Issue # (if applicable)

Closes #30721

### Reason for this change

Expose api on ECS L2 Cluster construct to encrypt fargate ephemeral storage

### Description of changes

adds new property to pass key for encrypton. 
Updates key policy according to developer documentation

### Description of how you validated changes

Added unit tests to validate cases where cluster has a generated name or a specified name. 

When name is random, the key policy can't be as restrictive since it will generate a cyclic dependency issue due to the Key Policy being inline in KMS

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
We've moved the rules to a separate package. Switch over to using that package.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This incorporates feedback from #30756 so all integration tests are uniform.

Related to #31589.
### Issue # (if applicable)

None.

### Reason for this change

The headings are set incorrectly, causing the table of contents to be misaligned.

<img width="244" alt="スクリーンショット 2024-10-08 20 13 13" src="https://github.com/user-attachments/assets/b08ab461-031b-4ffb-9937-3ab4ad0cddef">

### Description of changes

Remove heading and made some minor adjustments to the document.

### Description of how you validated changes

None

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Issue # (if applicable)

N/A

### Reason for this change
The link about key policy for an Event Bus has been updated.



### Description of changes
Updated a link in docs.


### Description of how you validated changes
No tests because only docs has been changed.



### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Issue # (if applicable)

Closes #31651 

### Reason for this change



`Role.customizeRoles` throws an Error if there is a construct that calls `applyRemovalPolicy` internally. This means users cannot use with some constructs like `RestApi`.

```
Error: Cannot apply RemovalPolicy: no child or not a CfnResource. Apply the removal policy on the CfnResource directly.
```

This can be reproduced with:

```typescript
const app = new App();
Role.customizeRoles(app);
const stack = new Stack(app, 'Stack');
new RestApi(stack, 'RestApi');
```

Or explicitly:
 
```typescript
const app = new App();
Role.customizeRoles(app);
const stack = new Stack(app, 'Stack');
const role = new Role(stack, 'Role', { assumedBy: new ServicePrincipal('sns.amazonaws.com') });
role.applyRemovalPolicy(RemovalPolicy.DESTROY);
```

### Description of changes



While it might be possible to fix `RestApi`, there could be other constructs within aws-cdk-lib that also call `Role.applyRemovalPolicy`. Moreover, it's nearly impossible to make library users aware of this.

Since `Role` implements the `IResource` interface, it has the responsibility to respond to the `applyRemovalPolicy` call. Therefore, I think it would be good to override `applyRemovalPolicy` in the `Role` class.

### Description of how you validated changes



Fixed the existing unit test to change behavior.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…ad Balancer Listener (#31584)

### Issue # (if applicable)

Closes #31310.

### Reason for this change
To set idle timeout for NLB.

AWS Network Load Balancer now supports configurable TCP idle timeout.

Announcement: https://aws.amazon.com/about-aws/whats-new/2024/09/aws-network-load-balancer-tcp-idle-timeout/



### Description of changes
* Add attributes to `BaseListener` class.
* Add `tcpIdleTimeout` property to `NetworkListener` class.



### Description of how you validated changes
Add unit tests and integ test.



### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…3 bucket (#31431)

### Issue # (if applicable)

Closes #31303.

### Reason for this change

During the update S3 bucket notifications, if there are multiple filter rules involved, the order of filter rules is different from CFN event notifications and S3 get notifications call. This will result different hash value which makes CDK unable to recognize s3 notifications created by the stack itself.

### Description of changes
Sort the notifications filter rules by key when calculating the hash value.

### Description of how you validated changes

Manually tested and integration tests.

### Checklist
- [ ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
JonWallsten and others added 7 commits October 8, 2024 21:50
### Issue # (if applicable)

Closes #31605.

### Reason for this change

I need to access the authorizer id and type to be able to import the authorizer in another CDK project

### Description of changes

I have added a public readonly variable for the authorizationType that was previously a string in the return object from the bind function. 
I have also added a getter that will return the authorizerId after the first binding. If not bound yet it will throw an error.

### Description of how you validated changes

I have added unit tests for all changed files.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Issue # (if applicable)

Closes #31695

### Reason for this change

- Similar to #30454, this PR adds 1.31 support.
- Update all existing integ tests for V1_30 and make sure they deploy with V1_31.


### Description of changes



### Description of how you validated changes


```ts
import * as ec2 from 'aws-cdk-lib/aws-ec2';
import * as iam from 'aws-cdk-lib/aws-iam';
import { App, Stack, StackProps } from 'aws-cdk-lib';
import { KubectlV31Layer } from '@aws-cdk/lambda-layer-kubectl-v31';
import * as eks from 'aws-cdk-lib/aws-eks';
import { Construct } from 'constructs';

export class EksClusterLatestVersion extends Stack {
  constructor(scope: Construct, id: string, props: StackProps) {
    super(scope, id, props);

    const vpc = new ec2.Vpc(this, 'Vpc', { natGateways: 1 });
    const mastersRole = new iam.Role(this, 'Role', {
      assumedBy: new iam.AccountRootPrincipal(),
    });

    new eks.Cluster(this, 'Cluster', {
      vpc,
      mastersRole,
      version: eks.KubernetesVersion.V1_31,
      kubectlLayer: new KubectlV31Layer(this, 'KubectlLayer'),
      defaultCapacity: 1,
    });
  }
}

const app = new App();
new EksClusterLatestVersion(app, 'v31-stack', {
  env: {
    account: process.env.CDK_DEFAULT_ACCOUNT,
    region: process.env.CDK_DEFAULT_REGION,
  },
})
```

verify

```sh
$ kubectl get no
NAME                           STATUS   ROLES    AGE     VERSION
ip-10-0-183-173.ec2.internal   Ready    <none>   4m25s   v1.31.0-eks-a737599
```

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Issue # (if applicable)

None

### Reason for this change

AWS Kafka now supports private link access.

### Description of changes

Add `kafka` and `kafka-fips` interface vpc endpoints.

### Description of how you validated changes

I confirmed from the result of AWS CLI.

```sh
$ aws ec2 describe-vpc-endpoint-services --filters Name=service-type,Values=Interface Name=owner,Values=amazon --region us-east-1 --query ServiceNames
    "com.amazonaws.us-east-1.kafka",
    "com.amazonaws.us-east-1.kafka-fips",
```

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Reason for this change

Put git-lfs in the prerequisites to avoid a git checkout error on initial clone. (And a failed checkout means `yarn install` will fail.)

### Description of changes

Added a note about it in contributing.md.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Issue

Closes #31656

### Reason for this change

When boostrapping, users may need to explicitly provide the environment if it can be determined from the app or shell environment. Previously this was not possible using the cli-lib-alpha package.

### Description of changes

Add a new argument to support environments.

### Description of how you validated changes

Unit test case was added.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…pplicationLoadBalancer (#31675)

### Issue # (if applicable)

Closes #31609.

### Reason for this change



The `http2Enabled` can only be set to CFn if it is specified with false. Therefore, if it is specified with true, the change is not reflected in CFn.

### Description of changes



Passed `http2Enabled` if it is not undefined.

```ts
if (props.http2Enabled !== undefined) { this.setAttribute('routing.http2.enabled', props.http2Enabled ? 'true' : 'false'); }
```

### Description of how you validated changes



Both unit and integ tests.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@aws-cdk-automation aws-cdk-automation added auto-approve pr/no-squash This PR should be merged instead of squash-merging it labels Oct 10, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team October 10, 2024 14:14
@github-actions github-actions bot added the p2 label Oct 10, 2024
CHANGELOG.v2.md Outdated Show resolved Hide resolved
@kaizencc kaizencc added the pr/do-not-merge This PR should not be merged at this time. label Oct 10, 2024
@aws-cdk-automation
Copy link
Collaborator Author

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 25d68f8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 10, 2024
@kaizencc kaizencc removed the pr/do-not-merge This PR should not be merged at this time. label Oct 10, 2024
Copy link
Contributor

mergify bot commented Oct 10, 2024

Thank you for contributing! Your pull request will be automatically updated and merged without squashing (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit c8d7dd3 into v2-release Oct 10, 2024
17 of 18 checks passed
@mergify mergify bot deleted the bump/2.162.0 branch October 10, 2024 17:29
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-approve p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. pr/no-squash This PR should be merged instead of squash-merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.