chore(pipes-sources): update integration tests to use SqsTarget #31589
Conversation
github-actions
bot
added
p2
distinguished-contributor
aws-cdk-automation
added
the
pr/needs-community-review
|
@moelasmar Likewise here, could you review please :) |
msambol
force-pushed
the
pipes-sources-int-tests
branch
from
8236e45
to
5476688
Compare
| @@ -1,5 +1,7 @@ | |||
| import { randomUUID } from 'crypto'; | |||
| import { ITarget, InputTransformation, Pipe, TargetConfig } from '@aws-cdk/aws-pipes-alpha'; | |||
| import { InputTransformation, Pipe } from '@aws-cdk/aws-pipes-alpha'; | |||
| // eslint-disable-next-line import/no-extraneous-dependencies | |||
There was a problem hiding this comment.
I'm not sure the proper way to handle this. If I add @aws-cdk/aws-pipes-targets-alphs to devDependencies, it creates a circular dependency. is eslint-disable-next-line import/no-extraneous-dependencies OK to have here?
There was a problem hiding this comment.
@moelasmar I may need your input here. Do I need to go back to those TestClasses?
There was a problem hiding this comment.
sorry @msambol I missed checking this PR, I will take a look to it tomorrow.
There was a problem hiding this comment.
Thanks! The build is failing but those look like good imports to me in the integration test?
@aws-cdk/aws-pipes-sources-alpha: /codebuild/output/src3454251283/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-pipes-sources-alpha/test/integ.dynamodb.ts
@aws-cdk/aws-pipes-sources-alpha: 3:27 error Unable to resolve path to module '@aws-cdk/aws-pipes-targets-alpha' import/no-unresolved
@aws-cdk/aws-pipes-sources-alpha: /codebuild/output/src3454251283/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-pipes-sources-alpha/test/integ.kinesis.ts
@aws-cdk/aws-pipes-sources-alpha: 3:27 error Unable to resolve path to module '@aws-cdk/aws-pipes-targets-alpha' import/no-unresolved
@aws-cdk/aws-pipes-sources-alpha: /codebuild/output/src3454251283/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-pipes-sources-alpha/test/integ.sqs.ts
@aws-cdk/aws-pipes-sources-alpha: 4:27 error Unable to resolve path to module '@aws-cdk/aws-pipes-targets-alpha' import/no-unresolved
@aws-cdk/aws-pipes-sources-alpha: ✖ 3 problems (3 errors, 0 warnings)
There was a problem hiding this comment.
@moelasmar Wondering if I should revert some of these changes and do one test-classes.ts file that contains an SqsSource in the targets directory and an SqsTarget in the sources directory, that way there are no dependencies between the two.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This incorporates feedback from #30756 so all integration tests are uniform.
Related to #31588.