Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(kinesisfirehose-alpha): replacedestinations property with destination and change type from array to single IDestination #31630

Merged
merged 10 commits into from
Oct 4, 2024

Conversation

paulhcsun
Copy link
Contributor

@paulhcsun paulhcsun commented Oct 2, 2024

Reason for this change

Setting a destination for your Delivery Stream was previously done by passing in an array of Destinations but with a restriction that there there could only be one Destination in that array. This property type does not make sense for the current user experience (have an array but can only specify one destination) and also does not align with the behaviour in the AWS Console which only allows you to select a single destination.

If Kinesis Firehose ever supports multiple destinations in the future then we can add a new property to support that which will not be a breaking change.

Description of changes

BREAKING CHANGE: replaced destinations property with destination (singular) and changed the type from array of Destinations to a single Destination. Old behaviour would only allow an array with a single Destination to be passed in anyway.

Description of how you validated changes

unit tests + no integ snapshot changes.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Oct 2, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team October 2, 2024 22:47
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 2, 2024
@paulhcsun paulhcsun changed the title chore(kinesis-firehose-alpha): change Stream's destination property type from array to single IDestination WIP: chore(kinesis-firehose-alpha): change Stream's destination property type from array to single IDestination Oct 2, 2024
@paulhcsun paulhcsun changed the title WIP: chore(kinesis-firehose-alpha): change Stream's destination property type from array to single IDestination WIP: chore(kinesis-firehose-alpha): change Stream's destinations property type from array to single IDestination Oct 2, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@paulhcsun paulhcsun changed the title WIP: chore(kinesis-firehose-alpha): change Stream's destinations property type from array to single IDestination WIP: chore(kinesis-firehose-alpha): replacedestinations property with destination and change type from array to single IDestination Oct 3, 2024
@paulhcsun paulhcsun changed the title WIP: chore(kinesis-firehose-alpha): replacedestinations property with destination and change type from array to single IDestination chore(kinesis-firehose-alpha): replacedestinations property with destination and change type from array to single IDestination Oct 3, 2024
@paulhcsun paulhcsun changed the title chore(kinesis-firehose-alpha): replacedestinations property with destination and change type from array to single IDestination chore(kinesisfirehose-alpha): replacedestinations property with destination and change type from array to single IDestination Oct 3, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 3, 2024 00:07

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@paulhcsun paulhcsun marked this pull request as ready for review October 3, 2024 00:07
@Leo10Gama Leo10Gama self-assigned this Oct 3, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 4, 2024
Copy link
Member

@Leo10Gama Leo10Gama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(it was, in fact, the last)

@Leo10Gama
Copy link
Member

@Mergifyio update

Copy link
Contributor

mergify bot commented Oct 4, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Oct 4, 2024

update

☑️ Nothing to do

  • queue-position = -1 [📌 update requirement]
  • #commits-behind > 0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 4, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 13ae67f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 1e2cff1 into aws:main Oct 4, 2024
15 checks passed
Copy link
Contributor

mergify bot commented Oct 4, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link

github-actions bot commented Oct 4, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2024
@paulhcsun paulhcsun deleted the firehose-destination-property branch October 4, 2024 20:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants