-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump up @aws-sdk packages to 3.175.0 #10362
Conversation
The aws-sdk 3.175.0 upgrade introduces in transit dependencies that uses es6 const syntax. It causes uglify-js fail. Update the rollup config to prefer "browser" field of the dependencies solves the issue.
As per sample app bundle size audition, this upgrade will cause significant bundle size increase(18KB) in at lease storage catagory: baseline:
after:
|
5b68474
to
66bfe31
Compare
PR to reduce the bundle size increase caused by the aws-sdk: aws/aws-sdk-js-v3#4001. It is current blocked by NaturalIntelligence/fast-xml-parser#501 |
Confirmed the AWS SDK update can resolve the bundling issue with Vite #9639. The result can be confirmed with the sample app in this commit: AllanZhengYP@857745f. |
Description of changes
Follow up to #7822, update
@aws-sdk
packages after over 1.5 years. Targeting the package set in the 3.175.0 release of@aws-sdk
Pending:
Resolves: #9639
Issue #, if available
Description of how you validated changes
TBD
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.