Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entities dependency bumps up bundle size by 13 KB #3978

Closed
3 tasks done
AllanZhengYP opened this issue Sep 23, 2022 · 3 comments
Closed
3 tasks done

Entities dependency bumps up bundle size by 13 KB #3978

AllanZhengYP opened this issue Sep 23, 2022 · 3 comments
Assignees
Labels
bug This issue is a bug. p2 This is a standard priority issue

Comments

@AllanZhengYP
Copy link
Contributor

Checkboxes for prior research

Describe the bug

The entities dependency was introduced in the PR: #2381 to solve the xml decoding issues. It's a 13 KB Gzipped un-treeshakable dependency. It has larger footprint than several SDK clients source code Gzipped.

Now that the issue has been fixed in the mentioned dependency: #2375 (comment), the dependency can be removed.

SDK version number

@aws-sdk/client-s3

Which JavaScript Runtime is this issue in?

Browser

Details of the browser/Node.js/ReactNative version

all browsers

Reproduction Steps

aws-amplify/amplify-js#10362

Observed Behavior

Bundle analytics report of bundling Amplify-js library with 3.175.0 release of the SDK:

https://dev.d30eefz4azmpyu.amplifyapp.com/storage-new.html

Expected Behavior

The entities dependency not installed

Possible Solution

Bump up fast-xml-parser to 4.0.0+

Additional Information/Context

No response

@AllanZhengYP AllanZhengYP added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Sep 23, 2022
@kuhe kuhe self-assigned this Sep 23, 2022
@ajredniwja ajredniwja removed the needs-triage This issue or PR still needs to be triaged. label Sep 26, 2022
@trivikr
Copy link
Member

trivikr commented Sep 26, 2022

Bumping fast-xml-parser to 4.x is not straightforward, as API has changed along with some options and protocol tests are failing.

For future reference, the commits can be picked from attempt:

@RanVaknin RanVaknin added the p2 This is a standard priority issue label Mar 27, 2023
@kuhe
Copy link
Contributor

kuhe commented Mar 19, 2024

fast xml parser is currently at 4.2.5 and entities is not imported in the sdk

@kuhe kuhe closed this as completed Mar 19, 2024
Copy link

github-actions bot commented Apr 4, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. p2 This is a standard priority issue
Projects
None yet
Development

No branches or pull requests

5 participants