Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump fast-xml-parser to 4.0.11 #4001

Merged
merged 10 commits into from
Oct 11, 2022

Conversation

AllanZhengYP
Copy link
Contributor

@AllanZhengYP AllanZhengYP commented Sep 29, 2022

Issue

followup to #3989
ref: smithy-lang/smithy-typescript#599
blocked by: NaturalIntelligence/fast-xml-parser#501

Description

Bump fast-xml-parser to 4.0.11

This change removes the dependency entities(13 KB Gzipped). The dependency was introduced in #2381 to handle the HTML entities(#2362 #2375). However HTML entities isn't the root cause the the linked issues. They can be fixed by handling basic xml entities. So the chunky dependency can be removed.

Manually tested in SQS with cases in #2362 and #2375;

Code Snippet
import { SQS } from "@aws-sdk/client-sqs";
import md5 from "md5";

const region = "us-west-2";
const client = new SQS({ region });

const QueueName = `test-${Date.now()}`;
const { QueueUrl } = await client.createQueue({ QueueName });

const MessageBody = `<`;
console.log(MessageBody);
const { MD5OfMessageBody } = await client.sendMessage({
  MessageBody,
  QueueUrl,
});

console.log(
  `\nmd5 check for sent message: ${md5(MessageBody) === MD5OfMessageBody}`
);

const response = await client.receiveMessage({ QueueUrl });
console.log(
  `md5 check for received message: ${
    md5(MessageBody) === md5(response.Messages[0].Body)
  }`
);
console.log(
  `\nStrict Equality Comparison: ${MessageBody === response.Messages[0].Body}`
);

console.log(response.Messages[0].Body);

console.log(
  `\nChecksum Comparison: ${MD5OfMessageBody === response.Messages[0].MD5OfBody}`
);

await client.deleteQueue({ QueueUrl });

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AllanZhengYP AllanZhengYP changed the title chore(deps-dev): bump fast-xml-parser to 4.0.10 chore(deps-dev): bump fast-xml-parser to 4.0.11 Oct 5, 2022
@AllanZhengYP AllanZhengYP marked this pull request as ready for review October 6, 2022 04:23
@AllanZhengYP AllanZhengYP requested a review from a team as a code owner October 6, 2022 04:23
@AllanZhengYP
Copy link
Contributor Author

Any update? @siddsriv

@trivikr trivikr self-requested a review October 11, 2022 18:20
Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that clients are generated correctly and integration tests are successful.

@trivikr trivikr merged commit 0a893fb into aws:main Oct 11, 2022
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants