Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add genesis config to the genesis domain #1704

Merged
merged 11 commits into from
Aug 1, 2023
Merged

Add genesis config to the genesis domain #1704

merged 11 commits into from
Aug 1, 2023

Conversation

NingLin-P
Copy link
Member

close #1696

This PR adds concrete genesis config value to the genesis domain which makes the genesis domain have the same genesis config as in v1, and enables previously disabled tests.

Code contributor checklist:

liuchengxu
liuchengxu reviewed Jul 28, 2023
View reviewed changes
Copy link
Contributor

@liuchengxu liuchengxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense in general, a few nits.

test/subspace-test-client/src/chain_spec.rs Outdated Show resolved Hide resolved
crates/subspace-node/src/domain/evm_chain_spec.rs Outdated Show resolved Hide resolved
crates/subspace-node/src/chain_spec.rs Outdated Show resolved Hide resolved
crates/subspace-node/src/domain/evm_chain_spec.rs Show resolved Hide resolved
vedhavyas
vedhavyas reviewed Jul 28, 2023
View reviewed changes
Copy link
Member

@vedhavyas vedhavyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not very pleasing to see the raw genesis config. Left some questions. Will do another look in a bit

crates/pallet-domains/src/domain_registry.rs Show resolved Hide resolved
crates/pallet-domains/src/domain_registry.rs Show resolved Hide resolved
crates/sp-domains/src/lib.rs Show resolved Hide resolved
crates/subspace-node/src/domain/evm_chain_spec.rs Show resolved Hide resolved
vedhavyas
vedhavyas previously approved these changes Jul 31, 2023
View reviewed changes
crates/pallet-domains/src/domain_registry.rs Show resolved Hide resolved
@NingLin-P NingLin-P enabled auto-merge July 31, 2023 09:16
@NingLin-P
Copy link
Member Author

The CI test failed due to #1700 adding a check to extrinsic in the bundle which invokes the check_transaction_validity API, but this API is unimplemented (with the unimplemented macro). The test didn't fail previously because in all the tests the bundle didn't contain any extrinsic and this PR enabled tests that produced bundles with extrinsic thus triggering this failure, it is fixed in the last commit PTAL.

@NingLin-P NingLin-P merged commit 42489e3 into main Aug 1, 2023
@NingLin-P NingLin-P deleted the genesis-config branch August 1, 2023 17:40
ParthDesai added a commit to autonomys/subspace-pulsar-sdk that referenced this pull request Aug 5, 2023
@ParthDesai
import autonomys/subspace#1703 autonomys/subspace#1719 autonomys/subs…
3b5b8bb 
…pace#1721 autonomys/subspace#1716 autonomys/subspace#1722 autonomys/subspace#1732 autonomys/subspace#1733 autonomys/subspace#1704
ParthDesai added a commit to autonomys/subspace-pulsar-sdk that referenced this pull request Aug 5, 2023
@ParthDesai
import autonomys/subspace#1703 autonomys/subspace#1719 autonomys/subs…
b90e07b 
…pace#1721 autonomys/subspace#1716 autonomys/subspace#1722 autonomys/subspace#1732 autonomys/subspace#1733 autonomys/subspace#1704 autonomys/subspace#1710 subspace#1737 autonomys/subspace#1736
ParthDesai added a commit to autonomys/subspace-pulsar-sdk that referenced this pull request Aug 15, 2023
@ParthDesai
import autonomys/subspace#1703 autonomys/subspace#1719 autonomys/subs…
b38f4cb 
…pace#1721 autonomys/subspace#1716 autonomys/subspace#1722 autonomys/subspace#1732 autonomys/subspace#1733 autonomys/subspace#1704 autonomys/subspace#1710 subspace#1737 autonomys/subspace#1736
ParthDesai added a commit to autonomys/subspace-pulsar-sdk that referenced this pull request Aug 15, 2023
@ParthDesai
import autonomys/subspace#1703 autonomys/subspace#1719 autonomys/subs…
dab0330 
…pace#1721 autonomys/subspace#1716 autonomys/subspace#1722 autonomys/subspace#1732 autonomys/subspace#1733 autonomys/subspace#1704 autonomys/subspace#1710 subspace#1737 autonomys/subspace#1736
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuchengxu liuchengxu liuchengxu left review comments

@vedhavyas vedhavyas vedhavyas approved these changes

@nazar-pc nazar-pc Awaiting requested review from nazar-pc nazar-pc is a code owner

@rg3l3dr rg3l3dr Awaiting requested review from rg3l3dr rg3l3dr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add genesis config to the domain instance
4 participants
@NingLin-P @nazar-pc @vedhavyas @liuchengxu