Remove invalid bundles in the process of compiling bundles to extrinsics #1700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename `should_select_tx()` to `is_within_tx_range()` and handle the case of unsigned transactions within `is_within_tx_range()`.
This commit is a pure refactoring to make the tx range check reusable in domain-block-preprocessor later. The sortition module in domain-operator is now not useful and deleted.
… bundles - Make compile_own_domain_bundles() as a method of DomainBlockPreprocessor - Remove invalid bundles in the process of compiling bundles to extrinsics
No logical changes
liuchengxu
requested review from
vedhavyas,
NingLin-P,
nazar-pc and
rg3l3dr
as code owners
liuchengxu
force-pushed
the
remove-invalid-bundles
branch
from
c668afc to
335751b
Compare
vedhavyas
reviewed
Jul 27, 2023
NingLin-P
reviewed
Jul 27, 2023
| @@ -331,23 +359,23 @@ where | |||
| >, | |||
| consensus_block_hash: CBlock::Hash, | |||
| at: Block::Hash, | |||
| ) -> sp_blockchain::Result<bool> { | |||
| ) -> Result<bool, sp_api::ApiError> { | |||
There was a problem hiding this comment.
If we return Option<Vec<Block::Extrinsic>> instead of bool then we won't need to decode the extrinsic a second time, it may hurt readability though, non-blocker.
There was a problem hiding this comment.
Yeah, thought about avoiding the decoding again, but unsure if it's worth the readability comprise.
NingLin-P
approved these changes
Jul 27, 2023
vedhavyas
approved these changes
Jul 27, 2023
1 task
ParthDesai
added a commit
to autonomys/subspace-pulsar-sdk
that referenced
this pull request
Aug 5, 2023
ParthDesai
added a commit
to autonomys/subspace-pulsar-sdk
that referenced
this pull request
Aug 15, 2023
ParthDesai
added a commit
to autonomys/subspace-pulsar-sdk
that referenced
this pull request
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the invalid bundles in the bundles to extrinsics processing, each invalid bundle will be removed if any problematic tx is found in it. There are a few refactorings down the road, recommended to review commit by commit.
Close #1695
Code contributor checklist: