Delete object mappings and WS server from farmer #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamil-gadelshin
approved these changes
Aug 1, 2023
ParthDesai
added a commit
to autonomys/subspace-pulsar-sdk
that referenced
this pull request
Aug 5, 2023
ParthDesai
added a commit
to autonomys/subspace-pulsar-sdk
that referenced
this pull request
Aug 5, 2023
ParthDesai
added a commit
to autonomys/subspace-pulsar-sdk
that referenced
this pull request
Aug 15, 2023
ParthDesai
added a commit
to autonomys/subspace-pulsar-sdk
that referenced
this pull request
Aug 15, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still don't have clarity on object mappings and as for WS server, it was not used for very long time and only served as an example of code that retrieves objects from DSN, but over time de-synced with implementation.
I think it is time to remove them, we can restore this code from git history if/when needed.
Code contributor checklist: