Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moveable perf fix #566

Merged
merged 7 commits into from
Jun 26, 2018
Merged

Moveable perf fix #566

merged 7 commits into from
Jun 26, 2018

Conversation

alexreardon
Copy link
Collaborator

No description provided.

alexreardon and others added 7 commits June 22, 2018 16:25
@alexreardon
Squashed commit of the following:
e4c7262 
commit 5a5e2b4
Author: Alex Reardon <[email protected]>
Date:   Fri Jun 22 16:20:05 2018 +1000

    moveable is a boss

commit 48e86ac
Author: Alex Reardon <[email protected]>
Date:   Fri Jun 22 13:57:36 2018 +1000

    stable base

commit 1eb695d
Author: Alex Reardon <[email protected]>
Date:   Fri Jun 22 08:08:42 2018 +1000

    little change

commit e1cb947
Author: Alex Reardon <[email protected]>
Date:   Thu Jun 21 16:04:59 2018 +1000

    moveable tests

commit 0881788
Author: Alex Reardon <[email protected]>
Date:   Thu Jun 21 15:42:23 2018 +1000

    invariant cleanup in mouse sensor

commit b4fe944
Author: Alex Reardon <[email protected]>
Date:   Thu Jun 21 15:34:36 2018 +1000

    cleaner use of invariant

commit 9b28d51
Author: Alex Reardon <[email protected]>
Date:   Thu Jun 21 11:43:25 2018 +1000

    it is okay to end a drag while preparing

commit a0ccc4f
Author: Alex Reardon <[email protected]>
Date:   Thu Jun 21 11:15:03 2018 +1000

    fixing linting

commit de8fee6
Author: Alex Reardon <[email protected]>
Date:   Thu Jun 21 11:06:41 2018 +1000

    fixing flow

commit 9372d1e
Author: Alex Reardon <[email protected]>
Date:   Thu Jun 21 10:30:58 2018 +1000

    ignoring pesky website cache directory

commit 4a4d1cb
Author: Alex Reardon <[email protected]>
Date:   Thu Jun 21 10:24:41 2018 +1000

    fixing touch sensor test

commit dd1910d
Author: Alex Reardon <[email protected]>
Date:   Thu Jun 21 10:22:06 2018 +1000

    fixing drag handle

commit b514662
Author: Alex Reardon <[email protected]>
Date:   Thu Jun 21 08:29:35 2018 +1000

    more tests

commit d962533
Author: Alex Reardon <[email protected]>
Date:   Wed Jun 20 17:03:38 2018 +1000

    fixing tests

commit b99c2c3
Author: Alex Reardon <[email protected]>
Date:   Wed Jun 20 17:03:33 2018 +1000

    removing old bulk replace

commit b990562
Author: Alex Reardon <[email protected]>
Date:   Wed Jun 20 16:16:38 2018 +1000

    dimensions getting some love

commit a6fe9cb
Author: Alex Reardon <[email protected]>
Date:   Wed Jun 20 15:44:18 2018 +1000

    draggable tests

commit 89487bb
Author: Alex Reardon <[email protected]>
Date:   Wed Jun 20 14:30:13 2018 +1000

    finishing connected droppable tests

commit 3a9ae20
Author: Alex Reardon <[email protected]>
Date:   Wed Jun 20 11:30:59 2018 +1000

    dropping

commit e2bd8c6
Author: Alex Reardon <[email protected]>
Date:   Wed Jun 20 09:09:56 2018 +1000

    connected droppable tests

commit 25d6f85
Author: Alex Reardon <[email protected]>
Date:   Wed Jun 20 09:01:36 2018 +1000

    connected droppable

commit c0557bf
Author: Alex Reardon <[email protected]>
Date:   Wed Jun 20 08:44:58 2018 +1000

    moving testing utilities out of connected draggable

commit 8db4a5e
Author: Alex Reardon <[email protected]>
Date:   Tue Jun 19 15:37:05 2018 +1000

    fixing middleware tests

commit 3a012dc
Author: Alex Reardon <[email protected]>
Date:   Tue Jun 19 14:06:05 2018 +1000

    more middleware tests

commit c396b92
Author: Alex Reardon <[email protected]>
Date:   Tue Jun 19 10:54:33 2018 +1000

    fixing middleware tests

commit de452ca
Author: Alex Reardon <[email protected]>
Date:   Tue Jun 19 10:08:27 2018 +1000

    connected draggable

commit 9a1ef92
Author: Alex Reardon <[email protected]>
Date:   Tue Jun 19 09:14:46 2018 +1000

    renaming and adding tests

commit 3b4638e
Author: Alex Reardon <[email protected]>
Date:   Mon Jun 18 17:02:27 2018 +1000

    tests everywhere

commit 59c4c17
Author: Alex Reardon <[email protected]>
Date:   Mon Jun 18 13:44:30 2018 +1000

    its happening

commit 59479bc
Author: Alex Reardon <[email protected]>
Date:   Mon Jun 18 11:07:25 2018 +1000

    draggable and droppable dimension components and tests

commit 3e1aa00
Author: Alex Reardon <[email protected]>
Date:   Mon Jun 18 09:59:38 2018 +1000

    finishing sub test

commit b816d09
Author: Alex Reardon <[email protected]>
Date:   Mon Jun 18 09:57:15 2018 +1000

    dimension marshal tests wrapping up

commit 41ecab2
Author: Alex Reardon <[email protected]>
Date:   Mon Jun 18 09:30:36 2018 +1000

    more tests

commit c542979
Merge: adfe9a9 ffa1405
Author: Alex Reardon <[email protected]>
Date:   Fri Jun 15 16:25:08 2018 +1000

    Merge branch 'master' of github.com:atlassian/react-beautiful-dnd into pivot

commit adfe9a9
Author: Alex Reardon <[email protected]>
Date:   Fri Jun 15 13:35:10 2018 +1000

    new registration tests

commit a6002a9
Author: Alex Reardon <[email protected]>
Date:   Fri Jun 15 11:31:23 2018 +1000

    why hello there my old friend

commit 60ccbd4
Author: Alex Reardon <[email protected]>
Date:   Fri Jun 15 10:36:11 2018 +1000

    renaming

commit 212365b
Author: Alex Reardon <[email protected]>
Date:   Fri Jun 15 10:29:05 2018 +1000

    moving forward

commit 302d60c
Author: Alex Reardon <[email protected]>
Date:   Thu Jun 14 16:13:33 2018 +1000

    now passing type down through context

commit 2add044
Author: Alex Reardon <[email protected]>
Date:   Thu Jun 14 15:19:11 2018 +1000

    placeholder

commit fdef7ae
Author: Alex Reardon <[email protected]>
Date:   Thu Jun 14 11:35:29 2018 +1000

    correctly shifting draggable post update

commit e802a06
Author: Alex Reardon <[email protected]>
Date:   Thu Jun 14 08:11:42 2018 +1000

    loving it

commit 1bdced5
Author: Alex Reardon <[email protected]>
Date:   Wed Jun 13 17:19:44 2018 +1000

    moving things around

commit db7bd19
Author: Alex Reardon <[email protected]>
Date:   Wed Jun 13 17:05:14 2018 +1000

    wip

commit c5a4dee
Author: Alex Reardon <[email protected]>
Date:   Wed Jun 13 13:45:37 2018 +1000

    getting ready

commit b2c52aa
Author: Alex Reardon <[email protected]>
Date:   Wed Jun 13 12:54:49 2018 +1000

    crazy simple use case now working

commit b17857d
Author: Alex Reardon <[email protected]>
Date:   Wed Jun 13 11:28:31 2018 +1000

    yep

commit 2e9b757
Author: Alex Reardon <[email protected]>
Date:   Wed Jun 13 11:03:21 2018 +1000

    updating types

commit abb3abc
Author: Alex Reardon <[email protected]>
Date:   Wed Jun 13 09:49:19 2018 +1000

    yeah

commit bdf35bc
Author: Alex Reardon <[email protected]>
Date:   Tue Jun 12 17:04:06 2018 +1000

    logging

commit 8275cc7
Author: Alex Reardon <[email protected]>
Date:   Tue Jun 12 16:18:47 2018 +1000

    new strategy for draggable dimension correcting

commit 59c3dc3
Author: Alex Reardon <[email protected]>
Date:   Tue Jun 12 11:30:03 2018 +1000

    using style marshal to clear transitions will collecting

commit fe77d8c
Author: Alex Reardon <[email protected]>
Date:   Tue Jun 12 10:54:47 2018 +1000

    its happening

commit ffc440a
Author: Alex Reardon <[email protected]>
Date:   Tue Jun 12 10:11:54 2018 +1000

    progress

commit d9b9157
Author: Alex Reardon <[email protected]>
Date:   Fri Jun 8 17:06:45 2018 +1000

    working, but not well

commit 00fd3eb
Author: Alex Reardon <[email protected]>
Date:   Fri Jun 8 14:16:36 2018 +1000

    getting closer

commit d57cfd4
Author: Alex Reardon <[email protected]>
Date:   Thu Jun 7 14:00:30 2018 +1000

    getting tests ready

commit e6b1a64
Author: Alex Reardon <[email protected]>
Date:   Thu Jun 7 11:10:34 2018 +1000

    bulk replace getting some love

commit 36a5fde
Author: Alex Reardon <[email protected]>
Date:   Thu Jun 7 10:38:18 2018 +1000

    adding jest typeahead

commit b4df9d4
Author: Alex Reardon <[email protected]>
Date:   Thu Jun 7 08:07:25 2018 +1000

    fixing dimension tests

commit 77b3cfd
Author: Alex Reardon <[email protected]>
Date:   Thu Jun 7 08:02:11 2018 +1000

    fixing droppable scrolling

commit eba6d05
Author: Alex Reardon <[email protected]>
Date:   Wed Jun 6 17:04:42 2018 +1000

    fix moveable. fix autoscroll for window

commit 28b74f5
Author: Alex Reardon <[email protected]>
Date:   Tue Jun 5 16:22:50 2018 +1000

    wip post drop updates

commit 3c0677c
Author: Alex Reardon <[email protected]>
Date:   Tue Jun 5 13:07:36 2018 +1000

    comments

commit 5a5d2e7
Author: Alex Reardon <[email protected]>
Date:   Tue Jun 5 11:43:10 2018 +1000

    bumping deps

commit e788c3e
Author: Alex Reardon <[email protected]>
Date:   Sun May 27 21:41:56 2018 +1000

    wip

commit e095ec7
Author: Alex Reardon <[email protected]>
Date:   Fri May 25 12:38:23 2018 +1000

    wip

commit b5aa18d
Author: Alex Reardon <[email protected]>
Date:   Fri May 25 11:09:51 2018 +1000

    adding more stories

commit 3d80f27
Author: Alex Reardon <[email protected]>
Date:   Fri May 25 08:12:15 2018 +1000

    lift

commit 947748e
Author: Alex Reardon <[email protected]>
Date:   Thu May 24 17:26:57 2018 +1000

    fixing middleware tests

commit 7576193
Author: Alex Reardon <[email protected]>
Date:   Thu May 24 16:20:12 2018 +1000

    test wip

commit 6182601
Author: Alex Reardon <[email protected]>
Date:   Thu May 24 10:07:55 2018 +1000

    hooks integration is a go

commit 966b2c6
Author: Alex Reardon <[email protected]>
Date:   Thu May 24 09:45:48 2018 +1000

    more dimension marshal tests

commit 3bb4f07
Author: Alex Reardon <[email protected]>
Date:   Thu May 24 08:35:34 2018 +1000

    dimension marshal

commit 04ce4e8
Author: Alex Reardon <[email protected]>
Date:   Wed May 23 11:54:17 2018 +1000

    more tests

commit 49b022a
Author: Alex Reardon <[email protected]>
Date:   Wed May 23 11:22:59 2018 +1000

    testing++

commit c46f68b
Author: Alex Reardon <[email protected]>
Date:   Mon May 21 17:22:42 2018 +1000

    removing older debug

commit 23f50d5
Author: Alex Reardon <[email protected]>
Date:   Mon May 21 17:02:29 2018 +1000

    test test tests

commit edc21bb
Author: Alex Reardon <[email protected]>
Date:   Mon May 21 16:32:44 2018 +1000

    drastically improved viewport

commit f5df39a
Author: Alex Reardon <[email protected]>
Date:   Mon May 21 15:57:49 2018 +1000

    viewport is back in action

commit 572df8b
Author: Alex Reardon <[email protected]>
Date:   Mon May 21 14:05:39 2018 +1000

    moving things around a lot

commit f9ef7a1
Author: Alex Reardon <[email protected]>
Date:   Mon May 21 10:46:40 2018 +1000

    minor changes

commit 311f1cb
Author: Alex Reardon <[email protected]>
Date:   Mon May 21 08:57:03 2018 +1000

    jump scroller

commit 9daafd1
Author: Alex Reardon <[email protected]>
Date:   Fri May 18 17:18:16 2018 +1000

    improving api

commit a9a64c5
Author: Alex Reardon <[email protected]>
Date:   Fri May 18 16:28:58 2018 +1000

    finishing remaining fluid scroller tests

commit d484233
Author: Alex Reardon <[email protected]>
Date:   Fri May 18 16:24:35 2018 +1000

    almost done with fluid scroller

commit 637cd00
Author: Alex Reardon <[email protected]>
Date:   Fri May 18 15:35:45 2018 +1000

    removing old code

commit 481f7ab
Author: Alex Reardon <[email protected]>
Date:   Fri May 18 14:56:21 2018 +1000

    wip

commit d8d2710
Author: Alex Reardon <[email protected]>
Date:   Fri May 18 14:41:52 2018 +1000

    fixing fluid scroller tests

commit 2ea4a74
Author: Alex Reardon <[email protected]>
Date:   Fri May 18 13:20:53 2018 +1000

    starting to look at auto scrolling

commit 6725051
Author: Alex Reardon <[email protected]>
Date:   Fri May 18 11:11:55 2018 +1000

    lots o tests

commit cef948c
Author: Alex Reardon <[email protected]>
Date:   Fri May 18 09:04:50 2018 +1000

    fixing infinite auto scroll recursion

commit 9e0708f
Author: Alex Reardon <[email protected]>
Date:   Fri May 18 08:20:49 2018 +1000

    moving direction movement into reducer

commit ad6ef18
Author: Alex Reardon <[email protected]>
Date:   Fri May 18 06:48:54 2018 +1000

    wip

commit bb28a9d
Author: Alex Reardon <[email protected]>
Date:   Thu May 17 21:59:30 2018 +1000

    original

commit 85305a5
Merge: d6adc0e 55de4c8
Author: Alex Reardon <[email protected]>
Date:   Thu May 17 21:28:06 2018 +1000

    Merge branch 'master' of github.com:atlassian/react-beautiful-dnd into major-state-refactor

commit d6adc0e
Author: Alex Reardon <[email protected]>
Date:   Thu May 17 17:42:52 2018 +1000

    wip

commit 1f3812b
Author: Alex Reardon <[email protected]>
Date:   Thu May 17 17:25:36 2018 +1000

    reorganing reducer imports

commit ffe6d81
Author: Alex Reardon <[email protected]>
Date:   Thu May 17 17:23:51 2018 +1000

    window scroll is a little nicer

commit 962212a
Author: Alex Reardon <[email protected]>
Date:   Thu May 17 16:22:08 2018 +1000

    more drop tests

commit beb3be8
Author: Alex Reardon <[email protected]>
Date:   Thu May 17 14:16:20 2018 +1000

    cancel drop animating

commit 9d0725b
Author: Alex Reardon <[email protected]>
Date:   Thu May 17 13:10:36 2018 +1000

    fixing flow types

commit 65b7eb0
Author: Alex Reardon <[email protected]>
Date:   Thu May 17 08:13:30 2018 +1000

    surely something valuable

commit 85da3f4
Author: Alex Reardon <[email protected]>
Date:   Wed May 16 17:02:05 2018 +1000

    improving things

commit 25b5b36
Author: Alex Reardon <[email protected]>
Date:   Wed May 16 08:37:43 2018 +1000

    moving files around

commit a0fd7e8
Author: Alex Reardon <[email protected]>
Date:   Wed May 16 08:29:32 2018 +1000

    adding a post drag end abort test

commit 2d7ecc1
Author: Alex Reardon <[email protected]>
Date:   Tue May 15 17:28:02 2018 +1000

    yummy test

commit bac8217
Author: Alex Reardon <[email protected]>
Date:   Tue May 15 13:58:35 2018 +1000

    bulk publish flow improvement

commit 7ea6a1a
Author: Alex Reardon <[email protected]>
Date:   Tue May 15 07:55:06 2018 +1000

    today smells like success

commit 7f77585
Author: Alex Reardon <[email protected]>
Date:   Mon May 14 15:05:37 2018 +1000

    getting into it

commit d936e96
Author: Alex Reardon <[email protected]>
Date:   Mon May 14 14:34:20 2018 +1000

    cleanup

commit 53cbb39
Author: Alex Reardon <[email protected]>
Date:   Mon May 14 13:45:34 2018 +1000

    progress

commit 37dd5db
Author: Alex Reardon <[email protected]>
Date:   Mon May 14 10:40:23 2018 +1000

    improving hooks

commit f7b265b
Author: Alex Reardon <[email protected]>
Date:   Mon May 14 10:14:05 2018 +1000

    hooks are dead. long live hooks

commit bebb771
Merge: 4c43a70 715e35f
Author: Alex Reardon <[email protected]>
Date:   Mon May 14 09:14:07 2018 +1000

    Merge branch 'master' of github.com:atlassian/react-beautiful-dnd into major-state-refactor

commit 4c43a70
Author: Alex Reardon <[email protected]>
Date:   Mon May 14 09:05:37 2018 +1000

    progress

commit d7b8c9c
Author: Alex Reardon <[email protected]>
Date:   Mon May 14 08:58:45 2018 +1000

    upgrading hooks

commit 597a236
Merge: ce2e8ad eb0487d
Author: Alex Reardon <[email protected]>
Date:   Fri May 11 17:25:03 2018 +1000

    Merge branch 'master' of github.com:atlassian/react-beautiful-dnd into major-state-refactor

commit ce2e8ad
Author: Alex Reardon <[email protected]>
Date:   Thu May 10 15:17:35 2018 +1000

    adding hook placeholder

commit 2dfb621
Author: Alex Reardon <[email protected]>
Date:   Wed May 9 17:22:40 2018 +1000

    killing it

commit af9c215
Author: Alex Reardon <[email protected]>
Date:   Wed May 9 15:10:39 2018 +1000

    moving away from thunks

commit 5521315
Author: Alex Reardon <[email protected]>
Date:   Wed May 9 10:45:50 2018 +1000

    yolo

commit 2ebe6cc
Author: Alex Reardon <[email protected]>
Date:   Wed May 9 10:44:11 2018 +1000

    progress

commit 72944e3
Author: Alex Reardon <[email protected]>
Date:   Wed May 9 08:12:14 2018 +1000

    moving to middleware

commit cc70c39
Author: Alex Reardon <[email protected]>
Date:   Tue May 8 17:24:22 2018 +1000

    moving

commit 8946249
Author: Alex Reardon <[email protected]>
Date:   Tue May 8 17:07:55 2018 +1000

    progressing

commit ed8a743
Author: Alex Reardon <[email protected]>
Date:   Mon May 7 22:06:38 2018 +1000

    moving forward

commit 0f1fa90
Author: Alex Reardon <[email protected]>
Date:   Mon May 7 17:05:42 2018 +1000

    pushing forward

commit 589ef1e
Author: Alex Reardon <[email protected]>
Date:   Mon May 7 15:40:21 2018 +1000

    lets see how we go

commit 184696c
Author: Alex Reardon <[email protected]>
Date:   Mon May 7 13:58:02 2018 +1000

    fresh slate

commit 9f616a0
Author: Alex Reardon <[email protected]>
Date:   Mon May 7 13:46:22 2018 +1000

    wip

commit bc948ec
Author: Alex Reardon <[email protected]>
Date:   Mon May 7 10:31:01 2018 +1000

    removing box-sizing

commit 3a785c3
Author: Alex Reardon <[email protected]>
Date:   Mon May 7 10:28:38 2018 +1000

    moving things around a little

commit c18cf5d
Author: Alex Reardon <[email protected]>
Date:   Mon May 7 08:28:37 2018 +1000

    more accurate placeholder

commit 756c7a3
Author: Alex Reardon <[email protected]>
Date:   Sun May 6 21:47:28 2018 +1000

    initial

commit 7ef1da9
Author: Alex Reardon <[email protected]>
Date:   Sun May 6 21:22:31 2018 +1000

    cancel drag on any uncaught errors

commit 0805272
Merge: 513d0b6 07764b9
Author: Alex Reardon <[email protected]>
Date:   Fri May 4 16:29:45 2018 +1000

    Merge branch 'master' of github.com:atlassian/react-beautiful-dnd into dynamic-example

commit 513d0b6
Author: Alex Reardon <[email protected]>
Date:   Fri May 4 15:50:57 2018 +1000

    progress

commit d951a2d
Author: Alex Reardon <[email protected]>
Date:   Fri May 4 13:59:36 2018 +1000

    progress

commit bed898d
Author: Alex Reardon <[email protected]>
Date:   Thu May 3 16:30:48 2018 +1000

    yum

commit 8617353
Author: Alex Reardon <[email protected]>
Date:   Thu May 3 16:11:29 2018 +1000

    updating droppable dimension publisher

commit c8e2c79
Author: Alex Reardon <[email protected]>
Date:   Thu May 3 15:35:40 2018 +1000

    wip

commit 6c7dad0
Author: Alex Reardon <[email protected]>
Date:   Thu May 3 15:25:13 2018 +1000

    collector

commit eab420d
Author: Alex Reardon <[email protected]>
Date:   Thu May 3 09:09:08 2018 +1000

    changing key

commit 511e911
Author: Alex Reardon <[email protected]>
Date:   Wed May 2 16:34:35 2018 +1000

    fixing reordering

commit 5883efd
Author: Alex Reardon <[email protected]>
Date:   Wed May 2 16:21:23 2018 +1000

    Why does everything need to be some complicated?

commit c0fe54f
Author: Alex Reardon <[email protected]>
Date:   Wed May 2 16:05:04 2018 +1000

    initial
@alexreardon
tidy
074e106
@alexreardon
prevent double render
5aac43f
@alexreardon
preventing double render
c14a8dc
@alexreardon
optimising selectors
887e092
@RajaBellebon @alexreardon
Extend Jest timeout (#575)
a4af508 
* Extend Jest timeout

* Add a link to the stackoverflow issue
@alexreardon
Merge branch 'master' of github.com:atlassian/react-beautiful-dnd int…
7a80cd0 
…o moveable-perf-fix
@alexreardon alexreardon merged commit f31df80 into dev Jun 26, 2018
@alexreardon alexreardon deleted the moveable-perf-fix branch June 26, 2018 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexreardon @RajaBellebon