improving hooks

src/state/create-store.js

@@ -38,14 +38,17 @@ export default ({
   composeEnhancers(
     applyMiddleware(
       // ## Debug middleware
+
       // > uncomment to use
       // debugging logger
-      require('./debug-middleware/log-middleware').default,
+      // require('./debug-middleware/log-middleware').default,
       // debugging timer
       // require('./debug-middleware/timing-middleware').default,
       // average action timer
       // require('./debug-middleware/timing-average-middleware').default(20),
+
       // ## Application middleware
+
       // Style updates do not cause more actions. It is important to update styles
       // before hooks are called: specifically the onDragEnd hook. We need to clear
       // the transition styles off the elements before a reorder to prevent strange
@@ -58,6 +61,9 @@ export default ({
       // We need to stop the marshal before hooks fire as hooks can cause
       // dimension registration changes in response to reordering
       dimensionMarshalStopper(getDimensionMarshal),
+      // Fire application hooks
+      // TODO: where should this be?
+      hooks(getHooks, announce),
       // Fire application hooks in response to drag changes
       lift(getDimensionMarshal),
       // When a drop is pending and a bulk publish occurs, we need
@@ -67,10 +73,6 @@ export default ({
       dropAnimationFinish,
       pendingDrop,
       autoScroll,
-
-      // TODO: where should this go?
-      hooks(getHooks, announce),
-
     ),
   ),
 );

src/state/middleware/hooks.js

@@ -117,17 +117,19 @@ export default (getHooks: () => Hooks, announce: Announce) => {
 
     const move = (location: ?DraggableLocation) => {
       invariant(publishedStart, 'Cannot fire onDragMove when onDragStart has not been called');
+
       // No change to publish
       if (areLocationsEqual(lastLocation, location)) {
         return;
       }
 
+      lastLocation = location;
       const update: DragUpdate = {
         ...publishedStart,
         destination: location,
       };
 
-      withTimings('onDragMove', () => execute(getHooks().onDragEnd, update, messagePreset.onDragUpdate));
+      withTimings('onDragUpdate', () => execute(getHooks().onDragUpdate, update, messagePreset.onDragUpdate));
     };
 
     const end = (result: DropResult) => {

src/view/drag-drop-context/drag-drop-context.jsx

@@ -73,6 +73,8 @@ export default class DragDropContext extends React.Component<Props> {
       // Lazy reference to dimension marshal get around circular dependency
       getDimensionMarshal: (): DimensionMarshal => this.dimensionMarshal,
       styleMarshal: this.styleMarshal,
+      // This is a function as users are allowed to change their hook functions
+      // at any time
       getHooks: (): Hooks => ({
         onDragStart: this.props.onDragStart,
         onDragEnd: this.props.onDragEnd,