fixing drag handle

src/view/drag-handle/drag-handle.jsx

@@ -204,8 +204,8 @@ export default class DragHandle extends Component<Props> {
   }
 
   onKeyDown = (event: KeyboardEvent) => {
-    // let the mouse sensor deal with it
-    if (this.mouseSensor.isCapturing()) {
+    // let the other sensors deal with it
+    if (this.mouseSensor.isCapturing() || this.touchSensor.isCapturing()) {
       return;
     }
 

src/view/drag-handle/sensor/create-keyboard-sensor.js

@@ -1,5 +1,6 @@
 // @flow
 /* eslint-disable no-use-before-define */
+import invariant from 'tiny-invariant';
 import { type Position } from 'css-box-model';
 import createScheduler from '../util/create-scheduler';
 import preventStandardKeyEvents from '../util/prevent-standard-key-events';
@@ -82,10 +83,7 @@ export default ({
 
       const ref: ?HTMLElement = getDraggableRef();
 
-      if (!ref) {
-        console.error('cannot start a keyboard drag without a draggable ref');
-        return;
-      }
+      invariant(ref, 'Cannot start a keyboard drag without a draggable ref');
 
       // using center position as selection
       const center: Position = getBorderBoxCenterPosition(ref);

src/view/drag-handle/sensor/create-mouse-sensor.js

@@ -1,5 +1,6 @@
 // @flow
 /* eslint-disable no-use-before-define */
+import invariant from 'tiny-invariant';
 import { type Position } from 'css-box-model';
 import createScheduler from '../util/create-scheduler';
 import isSloppyClickThresholdExceeded from '../util/is-sloppy-click-threshold-exceeded';
@@ -247,13 +248,13 @@ export default ({
       return;
     }
 
-    if (!canStartCapturing(event)) {
-      return;
-    }
+    invariant(!isCapturing(), 'Should not be able to perform a mouse down while a drag or pending drag is occurring');
 
-    if (isCapturing()) {
-      console.error('should not be able to perform a mouse down while a drag or pending drag is occurring');
-      cancel();
+    if (!canStartCapturing(event)) {
+      // blocking the event as we want to opt out of the standard browser behaviour
+      // this *could* occur during a drop - although it should not thanks to pointer-events: none
+      // this is just being really safe
+      event.preventDefault();
       return;
     }
 

src/view/drag-handle/sensor/create-touch-sensor.js

@@ -1,5 +1,6 @@
 // @flow
 /* eslint-disable no-use-before-define */
+import invariant from 'tiny-invariant';
 import { type Position } from 'css-box-model';
 import createScheduler from '../util/create-scheduler';
 import createPostDragEventPreventer, { type EventPreventer } from '../util/create-post-drag-event-preventer';
@@ -368,14 +369,9 @@ export default ({
       return;
     }
 
-    // TODO: call prevent default here?
-    if (!canStartCapturing(event)) {
-      return;
-    }
+    invariant(!isCapturing(), 'Should not be able to perform a touch start while a drag or pending drag is occurring');
 
-    if (isCapturing()) {
-      console.error('should not be able to perform a touch start while a drag or pending drag is occurring');
-      cancel();
+    if (!canStartCapturing(event)) {
       return;
     }