Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export golangci-lint options, add scopelint linter #45

Merged
merged 1 commit into from
Apr 11, 2020
Merged

Export golangci-lint options, add scopelint linter #45

merged 1 commit into from
Apr 11, 2020

Conversation

atc0005
Copy link
Owner

@atc0005 atc0005 commented Apr 11, 2020

Summary

  • Move linter choices from Makefile to separate include file

  • Add scopelint linter to help catch variable use
    outside of intended scope

References

@atc0005
Export golangci-lint options, add scopelint linter
5415b5f 
Summary:

- Move linter choices from Makefile to separate include file

- Add scopelint linter to help catch variable use
  outside of intended scope

References:

- #42
- #44
- atc0005/todo#4
- dasrick/go-teams-notify#14
@atc0005 atc0005 added this to the v0.3.0 milestone Apr 11, 2020
@atc0005 atc0005 self-assigned this Apr 11, 2020
@atc0005 atc0005 merged commit b0bfa0a into master Apr 11, 2020
@atc0005 atc0005 deleted the move-and-extend-golangci-lint-options branch April 11, 2020 04:14
@atc0005 atc0005 mentioned this pull request Apr 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@atc0005 atc0005

Labels
builds CI enhancement New feature or request linting
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

Extend golangci-lint usage to include scopelint linter Move golangci-lint options to dedicated config file
1 participant
@atc0005