Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend golangci-lint usage to include scopelint linter #44

Closed
atc0005 opened this issue Apr 11, 2020 · 0 comments · Fixed by #45
Closed

Extend golangci-lint usage to include scopelint linter #44

atc0005 opened this issue Apr 11, 2020 · 0 comments · Fixed by #45
Assignees
@atc0005
Labels
CI enhancement New feature or request linting
Milestone
v0.3.0

Comments

@atc0005
Copy link
Owner

atc0005 commented Apr 11, 2020

See also #42 and atc0005/todo#4.
@atc0005 atc0005 added enhancement New feature or request CI linting labels Apr 11, 2020
@atc0005 atc0005 added this to the v0.3.0 milestone Apr 11, 2020
@atc0005 atc0005 self-assigned this Apr 11, 2020
atc0005 added a commit that referenced this issue Apr 11, 2020
@atc0005
Export golangci-lint options, add scopelint linter
5415b5f 
Summary:

- Move linter choices from Makefile to separate include file

- Add scopelint linter to help catch variable use
  outside of intended scope

References:

- #42
- #44
- atc0005/todo#4
- dasrick/go-teams-notify#14
@atc0005 atc0005 mentioned this issue Apr 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
CI enhancement New feature or request linting
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

Export golangci-lint options, add scopelint linter atc0005/send2teams
1 participant
@atc0005