Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend golangci-lint usage to include scopelint linter #1

Closed
atc0005 opened this issue Apr 8, 2020 · 2 comments
Closed

Extend golangci-lint usage to include scopelint linter #1

atc0005 opened this issue Apr 8, 2020 · 2 comments
Assignees
@atc0005
Labels
ci golang linting
Milestone
2020-04

Comments

@atc0005
Copy link
Owner

atc0005 commented Apr 8, 2020

This linter isn't currently enabled (AFAIK) in the Go projects I'm currently developing. It wasn't until I saw what it caught that I understood the need for it.

Example:

dasrick/go-teams-notify#14
@atc0005 atc0005 added this to the 2020-04 milestone Apr 8, 2020
@atc0005 atc0005 self-assigned this Apr 8, 2020
@atc0005
Copy link
Owner Author

atc0005 commented Apr 11, 2020

Enabled in send2teams project as part of atc0005/send2teams#45

@atc0005 atc0005 mentioned this issue Apr 26, 2020
Closed
atc0005 added a commit to atc0005/elbow that referenced this issue Apr 26, 2020
@atc0005
golangci-lint: Add scopelint linter
a624574 
Include this linter in the list when running linting checks.

- refs #231
- refs atc0005/todo#1
This was referenced Apr 26, 2020
Merged
Closed
Closed
Closed
@atc0005
Copy link
Owner Author

atc0005 commented Aug 6, 2020

I believe that this is complete. Additionally, this linter is enabled for containers provided by the atc0005/go-ci project:

https://github.com/atc0005/go-ci/blob/master/.golangci.yml

@atc0005 atc0005 closed this as completed Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
ci golang linting
Projects
None yet
Milestone
2020-04
Development

No branches or pull requests
1 participant
@atc0005