feat: rewrite to TS and start using Jest #115
Conversation
magicmatatjahu
requested review from
fmvilas,
derberg and
asyncapi-bot-eve
as code owners
There was a problem hiding this comment.
I think it makes sense as converter will grow in complexity, especially with 3.0 🤣
I support it, of course while being awake 👇🏼
The only thing is missing is the pre publish script that would run a build script during release.
I'm also thinking, minimum should be that we release it as feat as you expose 2 new interfaces (btw update readme) there that were not in the package before. Also, maybe remove CLI and we do 1.0 release.
|
@derberg 😘 Thanks dude! I forgot about that About CLI I wrote about my plan here #100 (comment) So in the next month when we will release |
|
@derberg Thanks for review! I added to the Readme example how to use package with exported types and also added |
|
Kudos, SonarCloud Quality Gate passed!
|
|
what about my comment
|
magicmatatjahu
changed the title
|
@derberg Sorry, done 😅 |
There was a problem hiding this comment.
if you want to update it manually in studio, then remember to stop https://github.com/asyncapi/converter-js/actions/workflows/bump.yml after release of converter. Or just block update PR in studio once it is created
|
@derberg Thanks for tip, however It won't be needed, because there isn't breaking change :) |
|
/rtm |
|
🎉 This PR is included in version 0.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Related issue(s)
Resolves #106
Resolves #107