Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add output flag #100

Merged
merged 2 commits into from
Feb 18, 2022
Merged

Conversation

magicmatatjahu
Copy link
Member

@magicmatatjahu magicmatatjahu commented Feb 17, 2022

Description

  • Add -o flag as output where converted spec should be saved.
  • Add info about new flag in Readme.md.

Related issue(s)
Resolves #93

@magicmatatjahu magicmatatjahu added the enhancement New feature or request label Feb 17, 2022
fmvilas
fmvilas previously approved these changes Feb 17, 2022
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve but I'd start thinking about getting rid of this CLI and suggest people use the asyncapi CLI.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@magicmatatjahu
Copy link
Member Author

magicmatatjahu commented Feb 18, 2022

@fmvilas I agree, but first we need have such a command in the CLI (which is very close to merge). However we don't know how people use that package, including CLI, so I would like release 1.0.0 (with removed CLI and migration guide to core CLI) when we will release 2.4.0 version of spec and then start preparing converter for 3.0.0 AsyncAPI. I don't want to break features in the minor release.

Btw. Could you check again? I had to resolve conflicts in the cli.js.

@magicmatatjahu
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 2774fb8 into asyncapi:master Feb 18, 2022
@magicmatatjahu magicmatatjahu deleted the output-flag branch February 18, 2022 11:26
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Converter should allow in-place conversion
3 participants