Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add php support for models generation #576

Merged
merged 6 commits into from
May 23, 2023
Merged

feat: add php support for models generation #576

merged 6 commits into from
May 23, 2023

Conversation

Shurtu-gal
Copy link
Collaborator

Description

  • add php model generation support to cli in accordance to modelina

Related issue(s)
Fixes #572

github-actions[bot]
github-actions bot reviewed May 22, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

jonaslagoni
jonaslagoni previously approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

Need a code owner to take a look as well 🙂

derberg
derberg reviewed May 23, 2023
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one tiny thing to fix

src/commands/generate/models.ts Outdated Show resolved Hide resolved
@Shurtu-gal
Copy link
Collaborator Author

one tiny thing to fix

Done @derberg

@Shurtu-gal Shurtu-gal requested a review from derberg May 23, 2023 11:24
@derberg
Copy link
Member

derberg commented May 23, 2023

sorry but as a result of merging #575 you have conflicts that you need to solve

@Shurtu-gal
Copy link
Collaborator Author

sorry but as a result of merging #575 you have conflicts that you need to solve

Done @derberg

@derberg
Copy link
Member

derberg commented May 23, 2023

please fix tests

@Shurtu-gal
Copy link
Collaborator Author

please fix tests

Done @derberg

@jonaslagoni
Copy link
Member

@Shurtu-gal do you mind updating the docs as well?

https://github.com/asyncapi/cli/blob/master/docs/usage.md

Just add PHP and since C++ has been merged, you can add cplusplus as well 🙂

jonaslagoni
jonaslagoni approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

derberg
derberg approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

soon there will be no need for manual usage docs updates ❤️
#556

@derberg derberg changed the title feat: add php support feat: add php support for models generation May 23, 2023
@derberg
Copy link
Member

derberg commented May 23, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 5b0f793 into asyncapi:master May 23, 2023
@derberg
Copy link
Member

derberg commented May 23, 2023

@allcontributors please add @Shurtu-gal for code

@allcontributors allcontributors bot mentioned this pull request May 23, 2023
Merged
@allcontributors
Copy link
Contributor

@derberg

I've put up a pull request to add @Shurtu-gal! 🎉

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.41.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

1 similar comment
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.41.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Shurtu-gal Shurtu-gal deleted the feat/php-support branch August 24, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@jonaslagoni jonaslagoni jonaslagoni approved these changes

@derberg derberg derberg approved these changes

@Souvikns Souvikns Awaiting requested review from Souvikns Souvikns is a code owner

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu

@boyney123 boyney123 Awaiting requested review from boyney123

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add PHP model generation support
4 participants
@Shurtu-gal @derberg @jonaslagoni @asyncapi-bot