Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C++ model generation support #575

Merged
merged 2 commits into from
May 23, 2023
Merged

feat: add C++ model generation support #575

merged 2 commits into from
May 23, 2023

Conversation

kaushik-rishi
Copy link
Contributor

Description

  • Adding C++ support to CLI as Modelina supports C++ model generation

Related issue(s)
Fixes #571

github-actions[bot]
github-actions bot reviewed May 22, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@kaushik-rishi kaushik-rishi changed the title feat: Add C++ model generation support feat: add C++ model generation support May 22, 2023
@kaushik-rishi kaushik-rishi mentioned this pull request May 22, 2023
Closed
jonaslagoni
jonaslagoni approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

Need a code owner to take a look as well 🙂

derberg
derberg approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@derberg
Copy link
Member

derberg commented May 23, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 3c47219 into asyncapi:master May 23, 2023
@derberg
Copy link
Member

derberg commented May 23, 2023

@allcontributors please add @kaushik-rishi for code

@allcontributors allcontributors bot mentioned this pull request May 23, 2023
Merged
@allcontributors
Copy link
Contributor

@derberg

I've put up a pull request to add @kaushik-rishi! 🎉

@derberg
Copy link
Member

derberg commented May 23, 2023

@kaushik-rishi thanks!!! there are some more issues, if you are interested https://github.com/asyncapi/cli/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22

@derberg derberg mentioned this pull request May 23, 2023
Merged
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.41.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@jonaslagoni jonaslagoni jonaslagoni approved these changes

@derberg derberg derberg approved these changes

@Souvikns Souvikns Awaiting requested review from Souvikns Souvikns is a code owner

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu

@boyney123 boyney123 Awaiting requested review from boyney123

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add C++ model generation support
4 participants
@kaushik-rishi @derberg @asyncapi-bot @jonaslagoni