Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP model generation support #572

Closed
jonaslagoni opened this issue May 22, 2023 · 6 comments · Fixed by #576
Closed

Add PHP model generation support #572

jonaslagoni opened this issue May 22, 2023 · 6 comments · Fixed by #576
Labels
area/typescript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. enhancement New feature or request good first issue Good for newcomers released

Comments

@jonaslagoni
Copy link
Member

jonaslagoni commented May 22, 2023

Reason/Context

Now that Modelina supports PHP model generation, we need to add support for it in the CLI.

To do this:

  1. Add the language (php) to the list of languages:
    enum Languages {
  2. Add a new switch entry as we have for JavaScript:
    case Languages.javascript:
  3. Add a new test case for the new language:
    describe('for JavaScript', () => {
  4. Add a required namespace option
@jonaslagoni jonaslagoni added the enhancement New feature or request label May 22, 2023
@Shurtu-gal
Copy link
Collaborator

Can I pick it up @jonaslagoni

@jonaslagoni
Copy link
Member Author

Yep, please do @Shurtu-gal 👍

@derberg
Copy link
Member

derberg commented May 22, 2023

/gfi ts

@asyncapi-bot asyncapi-bot added area/typescript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. good first issue Good for newcomers labels May 22, 2023
@munneb10
Copy link

Hi @jonaslagoni can I work on this issue?

@Shurtu-gal
Copy link
Collaborator

@jonaslagoni Done!

@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 0.41.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/typescript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. enhancement New feature or request good first issue Good for newcomers released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants