Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix staticheck and add to linter #13

Merged
merged 1 commit into from
Jan 9, 2023
Merged

fix staticheck and add to linter #13

merged 1 commit into from
Jan 9, 2023

Conversation

kannon92
Copy link
Contributor

@kannon92 kannon92 commented Jan 9, 2023

@Sharpz7 brought up this linter issue so I added to our linter and fixed it.

This way we can discover issues like this consistently among different developers.

@kannon92 kannon92 requested a review from Sharpz7 January 9, 2023 17:23
@Sharpz7
Copy link
Contributor

Sharpz7 commented Jan 9, 2023

There is now an issue for this;

Closes #12

@kannon92 kannon92 linked an issue Jan 9, 2023 that may be closed by this pull request
Start using staticchecker in lint. #12
Closed
@kannon92 kannon92 requested a review from Sharpz7 January 9, 2023 18:10
Sharpz7
Sharpz7 approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@Sharpz7 Sharpz7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannon92 kannon92 merged commit 0a249ca into armadaproject:main Jan 9, 2023
@kannon92 kannon92 deleted the staticcheck branch January 9, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sharpz7 Sharpz7 Sharpz7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Start using staticchecker in lint.
2 participants
@kannon92 @Sharpz7