Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start using staticchecker in lint. #12

Closed
Sharpz7 opened this issue Jan 9, 2023 · 0 comments · Fixed by #13
Closed

Start using staticchecker in lint. #12

Sharpz7 opened this issue Jan 9, 2023 · 0 comments · Fixed by #13

Comments

@Sharpz7
Copy link
Contributor

Sharpz7 commented Jan 9, 2023

Current problems from this lint check include:

Move to using named import in install package.

We should install github.com/armadaproject/armada-operator/apis/install/v1alpha1 once, as we do here instead of installing it at:

And in all other unit tests.

This produces https://staticcheck.io/docs/checks#ST1019 in vscode with the golang extension

Check for error before defering in e2e tests:

For example https://github.com/armadaproject/armada-operator/blob/main/controllers/install/binoculars_controller_e2e_test.go#L39

@Sharpz7 Sharpz7 changed the title Move to using named import in install package. Start using staticchecker in lint. Jan 9, 2023
@kannon92 kannon92 linked a pull request Jan 9, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant