fix staticheck and add to linter (#13)

armadaproject · Jan 9, 2023 · 0a249ca · 0a249ca
1 parent cfc9903
commit 0a249ca
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 4 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -17,4 +17,5 @@ linters:
     - errcheck
     - govet
     - gosimple
+    - staticcheck
 
diff --git a/controllers/install/binoculars_controller_e2e_test.go b/controllers/install/binoculars_controller_e2e_test.go
@@ -36,8 +36,12 @@ var _ = Describe("Armada Operator", func() {
 		It("Kubernetes should create Executor Kubernetes resources", func() {
 			By("Calling the Executor Controller Reconcile function", func() {
 				f, err := utils.CreateTempFile([]byte(binocularsYaml))
-				defer f.Close()
-				defer os.Remove(f.Name())
+				defer func() {
+					Expect(f.Close()).ToNot(HaveOccurred())
+				}()
+				defer func() {
+					Expect(os.Remove(f.Name())).ToNot(HaveOccurred())
+				}()
 				Expect(err).ToNot(HaveOccurred())
 
 				k, err := testUser.Kubectl()

diff --git a/controllers/install/executor_controller_e2e_test.go b/controllers/install/executor_controller_e2e_test.go
@@ -36,8 +36,12 @@ var _ = Describe("Armada Operator", func() {
 		It("Kubernetes should create Executor Kubernetes resources", func() {
 			By("Calling the Executor Controller Reconcile function", func() {
 				f, err := utils.CreateTempFile([]byte(executorYaml))
-				defer f.Close()
-				defer os.Remove(f.Name())
+				defer func() {
+					Expect(f.Close()).ToNot(HaveOccurred())
+				}()
+				defer func() {
+					Expect(os.Remove(f.Name())).ToNot(HaveOccurred())
+				}()
 				Expect(err).ToNot(HaveOccurred())
 
 				k, err := testUser.Kubectl()