Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added dlq option to aws-sqs eventsource spec #1403

Merged
merged 2 commits into from
Nov 2, 2021
Merged

feat: Added dlq option to aws-sqs eventsource spec #1403

merged 2 commits into from
Nov 2, 2021

Conversation

daniel-codefresh
Copy link
Member

@daniel-codefresh daniel-codefresh commented Nov 2, 2021 •
edited
Loading

Checklist:

@daniel-codefresh
Copy link
Member Author

Related issue: #1364

@daniel-codefresh daniel-codefresh mentioned this pull request Nov 2, 2021
Closed
whynowy
whynowy approved these changes Nov 2, 2021
View reviewed changes
Copy link
Member

@whynowy whynowy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@whynowy whynowy merged commit 4a1bf22 into argoproj:master Nov 2, 2021
BulkBeing pushed a commit to BulkBeing/argo-events that referenced this pull request Nov 16, 2021
@daniel-codefresh @BulkBeing
feat: Added dlq option to aws-sqs eventsource spec (argoproj#1403)
b2dc9d9 
* feat: Added dlq option to aws-sqs eventsource spec

Signed-off-by: Daniel Soifer <[email protected]>

* codegen

Signed-off-by: Daniel Soifer <[email protected]>
BulkBeing pushed a commit to BulkBeing/argo-events that referenced this pull request Nov 16, 2021
@daniel-codefresh @BulkBeing
feat: Added dlq option to aws-sqs eventsource spec (argoproj#1403)
2b7cf2c 
* feat: Added dlq option to aws-sqs eventsource spec

Signed-off-by: Daniel Soifer <[email protected]>

* codegen

Signed-off-by: Daniel Soifer <[email protected]>
@daniel-codefresh daniel-codefresh mentioned this pull request Dec 1, 2021
Closed
5 tasks
BulkBeing pushed a commit to BulkBeing/argo-events that referenced this pull request Mar 7, 2022
@daniel-codefresh @BulkBeing
feat: Added dlq option to aws-sqs eventsource spec (argoproj#1403)
cc68615 
* feat: Added dlq option to aws-sqs eventsource spec

Signed-off-by: Daniel Soifer <[email protected]>

* codegen

Signed-off-by: Daniel Soifer <[email protected]>
juliev0 pushed a commit to juliev0/argo-events that referenced this pull request Mar 29, 2022
@daniel-codefresh
feat: Added dlq option to aws-sqs eventsource spec (argoproj#1403)
19d375b 
* feat: Added dlq option to aws-sqs eventsource spec

Signed-off-by: Daniel Soifer <[email protected]>

* codegen

Signed-off-by: Daniel Soifer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whynowy whynowy whynowy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniel-codefresh @whynowy