[SQS] Ack messages when can not unmarshal payload

[mbruner]

When message payload received from SQS is not a valid JSON we get an error in logs but message is still acknowledged. That makes it impossible to forward it farther to DLQ.

argo-events/eventsources/sources/awssqs/start.go

Lines 143 to 146 in d556788

	log.Errorw("failed to marshal event data, will process next message...", zap.Error(err))
	el.Metrics.EventProcessingFailed(el.GetEventSourceName(), el.GetEventName())
	ack()
	return

Also, SQS handling logic differs from how it's implemented for PubSub:

argo-events/eventsources/sources/gcppubsub/start.go

Lines 124 to 127 in e9745c1

	log.Errorw("failed to marshal the event data", zap.Error(err))
	el.Metrics.EventProcessingFailed(el.GetEventSourceName(), el.GetEventName())
	m.Nack()
	return

[whynowy]

@mbruner - do you think adding a field indicating if dlq is configured and ack based on it works?

[whynowy]

Also, do you have any suggestion to the logic for pub/sub?

[mbruner]

do you think adding a field indicating if dlq is configured and ack based on it works?

@whynowy if it can be configurable - perfect!
I don't have any suggestion for pub/sub, only think that it should be consistent with sqs

[daniel-codefresh]

@whynowy I can take this one, but what will be the preferable solution? to simply remove the ack to be consistent with PubSub logic? or to add a conditional ack based on a new dlq field on the spec like you suggested?

[daniel-codefresh]

Hey @whynowy, heres the related PR: #1403
I ended up adding the dlq option you suggested to avoid breaking any existing behavior.