feat: Added dlq option to aws-sqs eventsource spec (argoproj#1403)

* feat: Added dlq option to aws-sqs eventsource spec Signed-off-by: Daniel Soifer <[email protected]> * codegen Signed-off-by: Daniel Soifer <[email protected]>
BulkBeing · Mar 7, 2022 · cc68615 · cc68615
1 parent 98a0feb
commit cc68615
Show file tree

Hide file tree

Showing 8 changed files with 449 additions and 373 deletions.
diff --git a/api/event-source.html b/api/event-source.html
diff --git a/api/event-source.md b/api/event-source.md
diff --git a/api/openapi-spec/swagger.json b/api/openapi-spec/swagger.json
diff --git a/eventsources/sources/awssqs/start.go b/eventsources/sources/awssqs/start.go
@@ -142,7 +142,10 @@ func (el *EventListener) processMessage(ctx context.Context, message *sqslib.Mes
 	if err != nil {
 		log.Errorw("failed to marshal event data, will process next message...", zap.Error(err))
 		el.Metrics.EventProcessingFailed(el.GetEventSourceName(), el.GetEventName())
-		ack()
+		// Don't ack if a DLQ is configured to allow to forward the message to the DLQ
+		if !el.SQSEventSource.DLQ {
+			ack()
+		}
 		return
 	}
 	if err = dispatch(eventBytes); err != nil {

diff --git a/pkg/apis/eventsource/v1alpha1/generated.pb.go b/pkg/apis/eventsource/v1alpha1/generated.pb.go
diff --git a/pkg/apis/eventsource/v1alpha1/generated.proto b/pkg/apis/eventsource/v1alpha1/generated.proto
diff --git a/pkg/apis/eventsource/v1alpha1/openapi_generated.go b/pkg/apis/eventsource/v1alpha1/openapi_generated.go
diff --git a/pkg/apis/eventsource/v1alpha1/types.go b/pkg/apis/eventsource/v1alpha1/types.go
@@ -606,6 +606,11 @@ type SQSEventSource struct {
 	// Metadata holds the user defined metadata which will passed along the event payload.
 	// +optional
 	Metadata map[string]string `json:"metadata,omitempty" protobuf:"bytes,9,rep,name=metadata"`
+	// DLQ specifies if a dead-letter queue is configured for messages that can't be processed successfully.
+	// If set to true, messages with invalid payload won't be acknowledged to allow to forward them farther to the dead-letter queue.
+	// The default value is false.
+	// +optional
+	DLQ bool `json:"dlq,omitempty" protobuf:"varint,10,opt,name=dlq"`
 }
 
 // PubSubEventSource refers to event-source for GCP PubSub related events.