feat: Introducing a Validating Admission Controller #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
whynowy
changed the title
Signed-off-by: Derek Wang <[email protected]>
VaibhavPage
reviewed
Jan 17, 2021
manifests/install-no-extension.yaml
Outdated
| @@ -0,0 +1,370 @@ | |||
| apiVersion: apiextensions.k8s.io/v1beta1 | |||
There was a problem hiding this comment.
Let's call this file install-with-extension. By default Argo-Events should be installed without Validating webhook as it is an addon.
There was a problem hiding this comment.
I made it a separate installation file install-validating-webhook.yaml.
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
whynowy
changed the title
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
alexec
approved these changes
Feb 5, 2021
| serialNumberLimit := new(big.Int).Lsh(big.NewInt(1), 128) | ||
| serialNumber, err := rand.Int(rand.Reader, serialNumberLimit) | ||
| if err != nil { | ||
| return nil, errors.Wrap(err, "failed to generate serial number") |
There was a problem hiding this comment.
minor: I much prefer fmt.Errorf("%w")
| @@ -25,6 +25,7 @@ require ( | |||
| github.com/fatih/color v1.9.0 // indirect | |||
| github.com/fsnotify/fsnotify v1.4.9 | |||
| github.com/ghodss/yaml v1.0.1-0.20190212211648-25d852aebe32 | |||
| github.com/go-openapi/inflect v0.19.0 | |||
juliev0
pushed a commit
to juliev0/argo-events
that referenced
this pull request
Mar 29, 2022
* feat: Introducing a Validating Admission Controller Signed-off-by: Derek Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a Validating Admission Controller to Argo Events, it validates the input spec and notifies the errors when doing
kubectl apply.Main features:
spec.nats.native.authin EventBus can not be updated);This change brings in a new Deployment and Service for the validating webhook, currently it would be made optional for installation.
Closes #1019.
Checklist: