feat: Introducing a Validating Admission Controller #1021
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,117 @@ | ||
| package tls | ||
|
|
||
| import ( | ||
| "crypto/rand" | ||
| "crypto/rsa" | ||
| "crypto/x509" | ||
| "crypto/x509/pkix" | ||
| "encoding/pem" | ||
| "math/big" | ||
| "time" | ||
|
|
||
| "github.com/pkg/errors" | ||
| ) | ||
|
|
||
| func certTemplate(org string, hosts []string, notAfter time.Time) (*x509.Certificate, error) { | ||
| serialNumberLimit := new(big.Int).Lsh(big.NewInt(1), 128) | ||
| serialNumber, err := rand.Int(rand.Reader, serialNumberLimit) | ||
| if err != nil { | ||
| return nil, errors.Wrap(err, "failed to generate serial number") | ||
| } | ||
| return &x509.Certificate{ | ||
| SerialNumber: serialNumber, | ||
| Subject: pkix.Name{ | ||
| Organization: []string{org}, | ||
| }, | ||
| SignatureAlgorithm: x509.SHA256WithRSA, | ||
| NotBefore: time.Now(), | ||
| NotAfter: notAfter, | ||
| BasicConstraintsValid: true, | ||
| DNSNames: hosts, | ||
| }, nil | ||
| } | ||
|
|
||
| func createCACertTemplate(org string, hosts []string, notAfter time.Time) (*x509.Certificate, error) { | ||
| rootCert, err := certTemplate(org, hosts, notAfter) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| rootCert.IsCA = true | ||
| rootCert.KeyUsage = x509.KeyUsageCertSign | x509.KeyUsageDigitalSignature | ||
| rootCert.ExtKeyUsage = []x509.ExtKeyUsage{x509.ExtKeyUsageServerAuth, x509.ExtKeyUsageClientAuth} | ||
| return rootCert, nil | ||
| } | ||
|
|
||
| func createServerCertTemplate(org string, hosts []string, notAfter time.Time) (*x509.Certificate, error) { | ||
| serverCert, err := certTemplate(org, hosts, notAfter) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| serverCert.KeyUsage = x509.KeyUsageDigitalSignature | ||
| serverCert.ExtKeyUsage = []x509.ExtKeyUsage{x509.ExtKeyUsageServerAuth} | ||
| return serverCert, err | ||
| } | ||
|
|
||
| // Sign the cert | ||
| func createCert(template, parent *x509.Certificate, pub, parentPriv interface{}) ( | ||
| cert *x509.Certificate, certPEM []byte, err error) { | ||
| certDER, err := x509.CreateCertificate(rand.Reader, template, parent, pub, parentPriv) | ||
| if err != nil { | ||
| return | ||
| } | ||
| cert, err = x509.ParseCertificate(certDER) | ||
| if err != nil { | ||
| return | ||
| } | ||
| b := pem.Block{Type: "CERTIFICATE", Bytes: certDER} | ||
| certPEM = pem.EncodeToMemory(&b) | ||
| return | ||
| } | ||
|
|
||
| func createCA(org string, hosts []string, notAfter time.Time) (*rsa.PrivateKey, *x509.Certificate, []byte, error) { | ||
| rootKey, err := rsa.GenerateKey(rand.Reader, 2048) | ||
| if err != nil { | ||
| return nil, nil, nil, errors.Wrap(err, "failed to generate random key") | ||
| } | ||
|
|
||
| rootCertTmpl, err := createCACertTemplate(org, hosts, notAfter) | ||
| if err != nil { | ||
| return nil, nil, nil, errors.Wrap(err, "failed to generate CA cert") | ||
| } | ||
|
|
||
| rootCert, rootCertPEM, err := createCert(rootCertTmpl, rootCertTmpl, &rootKey.PublicKey, rootKey) | ||
| if err != nil { | ||
| return nil, nil, nil, errors.Wrap(err, "failed to sign CA cert") | ||
| } | ||
| return rootKey, rootCert, rootCertPEM, nil | ||
| } | ||
|
|
||
| // CreateCerts creates and returns a CA certificate and certificate and | ||
| // key for the server | ||
| func CreateCerts(org string, hosts []string, notAfter time.Time) (serverKey, serverCert, caCert []byte, err error) { | ||
| // Create a CA certificate and private key | ||
| caKey, caCertificate, caCertificatePEM, err := createCA(org, hosts, notAfter) | ||
| if err != nil { | ||
| return nil, nil, nil, err | ||
| } | ||
|
|
||
| // Create the private key | ||
| servKey, err := rsa.GenerateKey(rand.Reader, 2048) | ||
| if err != nil { | ||
| return nil, nil, nil, errors.Wrap(err, "failed to generate random key") | ||
| } | ||
| servCertTemplate, err := createServerCertTemplate(org, hosts, notAfter) | ||
| if err != nil { | ||
| return nil, nil, nil, errors.Wrap(err, "failed to create server cert template") | ||
| } | ||
|
|
||
| // create a certificate wrapping the public key, sign it with the CA private key | ||
| _, servCertPEM, err := createCert(servCertTemplate, caCertificate, &servKey.PublicKey, caKey) | ||
| if err != nil { | ||
| return nil, nil, nil, errors.Wrap(err, "failed to sign server cert") | ||
| } | ||
| servKeyPEM := pem.EncodeToMemory(&pem.Block{ | ||
| Type: "RSA PRIVATE KEY", Bytes: x509.MarshalPKCS1PrivateKey(servKey), | ||
| }) | ||
| return servKeyPEM, servCertPEM, caCertificatePEM, nil | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| package tls | ||
|
|
||
| import ( | ||
| "crypto/x509" | ||
| "encoding/pem" | ||
| "testing" | ||
| "time" | ||
|
|
||
| "github.com/pkg/errors" | ||
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func TestCreateCerts(t *testing.T) { | ||
| t.Run("test create certs", func(t *testing.T) { | ||
| sKey, serverCertPEM, caCertBytes, err := CreateCerts("test-org", []string{"test-host"}, time.Now().AddDate(1, 0, 0)) | ||
| assert.NoError(t, err) | ||
| p, _ := pem.Decode(sKey) | ||
| assert.Equal(t, "RSA PRIVATE KEY", p.Type) | ||
| key, err := x509.ParsePKCS1PrivateKey(p.Bytes) | ||
| assert.NoError(t, err) | ||
| err = key.Validate() | ||
| assert.NoError(t, err) | ||
| sCert, err := validCertificate(serverCertPEM, t) | ||
| assert.NoError(t, err) | ||
| caParsedCert, err := validCertificate(caCertBytes, t) | ||
| assert.NoError(t, err) | ||
| assert.Equal(t, "test-host", caParsedCert.DNSNames[0]) | ||
| err = sCert.CheckSignatureFrom(caParsedCert) | ||
| assert.NoError(t, err) | ||
| }) | ||
| } | ||
|
|
||
| func validCertificate(cert []byte, t *testing.T) (*x509.Certificate, error) { | ||
| t.Helper() | ||
| const certificate = "CERTIFICATE" | ||
| caCert, _ := pem.Decode(cert) | ||
| if caCert.Type != certificate { | ||
| return nil, errors.Errorf("CERT type mismatch, got %s, want: %s", caCert.Type, certificate) | ||
| } | ||
| parsedCert, err := x509.ParseCertificate(caCert.Bytes) | ||
| if err != nil { | ||
| return nil, errors.Wrap(err, "failed to parse cert") | ||
| } | ||
| if parsedCert.SignatureAlgorithm != x509.SHA256WithRSA { | ||
| return nil, errors.Errorf("signature not match. Got: %s, want: %s", parsedCert.SignatureAlgorithm, x509.SHA256WithRSA) | ||
| } | ||
| return parsedCert, nil | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| apiVersion: kustomize.config.k8s.io/v1beta1 | ||
| kind: Kustomization | ||
|
|
||
| resources: | ||
| - ../base | ||
| - rbac | ||
|
|
||
| namespace: argo-events | ||
|
|
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| apiVersion: v1 | ||
| kind: ServiceAccount | ||
| metadata: | ||
| name: argo-events-webhook-sa |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| apiVersion: apps/v1 | ||
| kind: Deployment | ||
| metadata: | ||
| name: events-webhook | ||
| spec: | ||
| replicas: 1 | ||
| selector: | ||
| matchLabels: | ||
| app: events-webhook | ||
| template: | ||
| metadata: | ||
| labels: | ||
| app: events-webhook | ||
| spec: | ||
| containers: | ||
| - name: webhook | ||
| image: argoproj/events-webhook:latest | ||
| imagePullPolicy: Always | ||
| env: | ||
| - name: NAMESPACE | ||
| valueFrom: | ||
| fieldRef: | ||
| fieldPath: metadata.namespace | ||
| serviceAccountName: argo-events-webhook-sa |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| apiVersion: v1 | ||
| kind: Service | ||
| metadata: | ||
| name: events-webhook | ||
| spec: | ||
| ports: | ||
| - port: 443 | ||
| targetPort: 443 | ||
| selector: | ||
| app: events-webhook |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| apiVersion: kustomize.config.k8s.io/v1beta1 | ||
| kind: Kustomization | ||
|
|
||
| resources: | ||
| - argo-events-webhook-sa.yaml | ||
| - rbac | ||
| - events-webhook-deployment.yaml | ||
| - events-webhook-service.yaml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: ClusterRoleBinding | ||
| metadata: | ||
| name: argo-events-webhook-binding | ||
| roleRef: | ||
| apiGroup: rbac.authorization.k8s.io | ||
| kind: ClusterRole | ||
| name: argo-events-webhook | ||
| subjects: | ||
| - kind: ServiceAccount | ||
| name: argo-events-webhook-sa | ||
| namespace: argo-events |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: ClusterRole | ||
| metadata: | ||
| name: argo-events-webhook | ||
| rules: | ||
| - apiGroups: | ||
| - "" | ||
| resources: | ||
| - secrets | ||
| - configmaps | ||
| verbs: | ||
| - get | ||
| - list | ||
| - create | ||
| - update | ||
| - delete | ||
| - patch | ||
| - watch | ||
| - apiGroups: | ||
| - apps | ||
| resources: | ||
| - deployments | ||
| verbs: | ||
| - get | ||
| - list | ||
| - apiGroups: | ||
| - admissionregistration.k8s.io | ||
| resources: | ||
| - validatingwebhookconfigurations | ||
| verbs: | ||
| - get | ||
| - list | ||
| - create | ||
| - update | ||
| - delete | ||
| - patch | ||
| - watch |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| apiVersion: kustomize.config.k8s.io/v1beta1 | ||
| kind: Kustomization | ||
|
|
||
| resources: | ||
| - argo-events-webhook-cluster-role.yaml | ||
| - argo-events-webhook-cluster-role-binding.yaml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| # | ||
| # Update the versions in this file. | ||
| # | ||
|
|
||
| apiVersion: kustomize.config.k8s.io/v1beta1 | ||
| kind: Kustomization | ||
|
|
||
| resources: | ||
| - events-webhook | ||
|
|
||
| images: | ||
| - name: argoproj/events-webhook | ||
| newTag: latest | ||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: I much prefer
fmt.Errorf("%w")