Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A validation webhook to prevent some EventBus spec to be updated #986

Closed
whynowy opened this issue Dec 7, 2020 · 1 comment
Closed

A validation webhook to prevent some EventBus spec to be updated #986

whynowy opened this issue Dec 7, 2020 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@whynowy
Copy link
Member

whynowy commented Dec 7, 2020

Is your feature request related to a problem? Please describe.
EventBus is essential to the whole Argo Events, it's very critical to EventSource and Sensor services. Updating EventBus spec might cause unexpected behavior once the EventBus is created (e.g. updating auth strategy from none to token), this is something not we expected.

Describe the solution you'd like
A validation webhook to prevent this kind of action will be part of the installation.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.


Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@whynowy whynowy added the enhancement New feature or request label Dec 7, 2020
@whynowy whynowy mentioned this issue Dec 7, 2020
@whynowy whynowy added this to the v1.3 milestone Jan 24, 2021
@whynowy
Copy link
Member Author

whynowy commented Feb 6, 2021

#1021

@whynowy whynowy closed this as completed Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant