Add support for pluggable monitor (tracks branch feature/pluggable-monitor)
#1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added bundled instance of serial-monitor * Download serial-monitor together with other bundle tools * fix i18n
* Added new Monitor command (will replace current Monitor service) * Added new EnumerateMonitorPortParameters gRPC call * Force compile error on gRPC deamon when there are unimplemented methods * Updated deamon implementation stub * fix i18n
* Implementation of Monitor business logic * Implementation of 'monitor' command of the CLI * fix i18n * Update commands/monitor/monitor.go Co-authored-by: Silvano Cerza <[email protected]> Co-authored-by: Silvano Cerza <[email protected]>
cmaglie
force-pushed
the
feature/pluggable-monitor
branch
from
728847c
to
3eb819c
Compare
* Added documentation for pluggable monitor * Apply suggestions from code review Co-authored-by: per1234 <[email protected]> * Add pluggable monitor spec in nav bar; fixed link in source code comments * fix i18n and lint warnings Co-authored-by: per1234 <[email protected]>
* Factored pluggable monitor creation * Factored out code duplication * EnumerateMonitorPortSettings does require only protocol * Monitor.Open does require only address and protocol * Added GetPortAddressAndProtocol helper * fix i18n * Apply suggestions from code review Co-authored-by: Silvano Cerza <[email protected]>
* Add --fqbn parameter to monitor command * Add support for pluggable monitors with explicit recipe in platform.txt * increase logging * fix i18n
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tracks the
feature/pluggable-monitorbranch that collects all the patches for the pluggable monitor implementation.