Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pluggable monitor cli command #1495

Merged
merged 4 commits into from
Oct 5, 2021
Merged

Pluggable monitor cli command #1495

merged 4 commits into from
Oct 5, 2021

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Oct 5, 2021

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?
    This PR implements the CLI monitor command:
$ ./arduino-cli monitor -p /dev/ttyACM0
Connected to /dev/ttyACM0! Press CTRL-C to exit.
HELLO 492
HELLO 493
HELLO 494
HELLO 495
HELLO 496
HELLO 497
HELLO 498
^C
$

@cmaglie cmaglie force-pushed the pluggable-monitor-cli-command branch from 96d2780 to 9419fb7 Compare October 5, 2021 15:31
@cmaglie cmaglie merged commit 728847c into arduino:feature/pluggable-monitor Oct 5, 2021
@cmaglie cmaglie deleted the pluggable-monitor-cli-command branch October 5, 2021 15:51
cmaglie added a commit that referenced this pull request Oct 5, 2021
@cmaglie @silvanocerza
Implementation of CLI 'monitor' command (#1495)
3eb819c 
* Implementation of Monitor business logic

* Implementation of 'monitor' command of the CLI

* fix i18n

* Update commands/monitor/monitor.go

Co-authored-by: Silvano Cerza <[email protected]>

Co-authored-by: Silvano Cerza <[email protected]>
d-a-v pushed a commit to d-a-v/arduino-cli that referenced this pull request Oct 14, 2021
@cmaglie @silvanocerza @d-a-v
Implementation of CLI 'monitor' command (arduino#1495)
8e198a4 
* Implementation of Monitor business logic

* Implementation of 'monitor' command of the CLI

* fix i18n

* Update commands/monitor/monitor.go

Co-authored-by: Silvano Cerza <[email protected]>

Co-authored-by: Silvano Cerza <[email protected]>
@per1234 per1234 mentioned this pull request Jul 30, 2022
Closed
@seaxwi seaxwi mentioned this pull request Jan 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmaglie @silvanocerza