[pluggable monitor] Added gRPC calls. #1492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
approved these changes
Oct 4, 2021
d-a-v
pushed a commit
to d-a-v/arduino-cli
that referenced
this pull request
Oct 14, 2021
* Added new Monitor command (will replace current Monitor service) * Added new EnumerateMonitorPortParameters gRPC call * Force compile error on gRPC deamon when there are unimplemented methods * Updated deamon implementation stub * fix i18n
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)Added gRPC calls for the pluggable monitor system.
titled accordingly?
Not a breaking change.
BTW, in the future, the current non-pluggable "Monitor service" will be deprecated/removed and replaced by this one.