Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging to Get-AzKeyVaultAccessPolicies #271

Closed
pim-simons opened this issue Feb 10, 2022 · 0 comments · Fixed by #283
Closed

Add logging to Get-AzKeyVaultAccessPolicies #271

pim-simons opened this issue Feb 10, 2022 · 0 comments · Fixed by #283
Assignees
@pim-simons @pimentacodit888
Labels
area:key-vault All issues related to Azure Key Vault enhancement New feature or request
Milestone
v0.6.0

Comments

@pim-simons
Copy link
Contributor

In #262 we removed unnecessary logging from the Get-AzKeyVaultAccessPolicies script.
We should improve the script by logging that the access policies were retrieved successfully, a nice to have would be logging the retrieved access policies in the verbose logging.
@pim-simons pim-simons added enhancement New feature or request area:key-vault All issues related to Azure Key Vault labels Feb 10, 2022
@pim-simons pim-simons self-assigned this Feb 10, 2022
@pim-simons pim-simons added this to the v0.6.0 milestone Feb 10, 2022
pimentacodit888 added a commit to pimentacodit888/arcus.scripting that referenced this issue Mar 17, 2022
@pimentacodit888
feat: added logging to Get-AzKeyVaultAccessPolicies (arcus-azure#271)
71ec444
@pimentacodit888 pimentacodit888 mentioned this issue Mar 17, 2022
Merged
pim-simons pushed a commit that referenced this issue Mar 18, 2022
@pimentacodit888 @stijnmoreels
feat: Add logging to Get-AzKeyVaultAccessPolicies #271 (#283)
d2eca71 
Co-authored-by: Stijn Moreels <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pim-simons pim-simons

@pimentacodit888 pimentacodit888

Labels
area:key-vault All issues related to Azure Key Vault enhancement New feature or request
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging a pull request may close this issue.

feat: Add logging to Get-AzKeyVaultAccessPolicies #271 pimentacodit888/arcus.scripting
2 participants
@pim-simons @pimentacodit888