feat: Add logging to Get-AzKeyVaultAccessPolicies #271 #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pimentacodit888
requested review from
mbraekman,
stijnmoreels and
pim-simons
as code owners
|
✔️ Deploy Preview for arcus-scripting ready! 🔨 Explore the source changes: d873b13 🔍 Inspect the deploy log: https://app.netlify.com/sites/arcus-scripting/deploys/62345346204d400008240fe9 😎 Browse the preview: https://deploy-preview-283--arcus-scripting.netlify.app |
pim-simons
approved these changes
Mar 17, 2022
|
Great work @pimentacodit888! Thanks for your contribution 👍🏻 |
stijnmoreels
approved these changes
Mar 18, 2022
There was a problem hiding this comment.
Thx for this! ❤️ Will help a long way in defect detection, as consumers will know it succeeded.
Just added some minor suggestions to include the 'Azure Key Vault' in the statements (like we do in the existing logging statements). When things get run parallel, it's good that we still know what's going on. 😄
src/Arcus.Scripting.KeyVault/Scripts/Get-AzKeyVaultAccessPolicies.ps1
Outdated
Show resolved
Hide resolved
src/Arcus.Scripting.KeyVault/Scripts/Get-AzKeyVaultAccessPolicies.ps1
Outdated
Show resolved
Hide resolved
…ies.ps1 Co-authored-by: Stijn Moreels <[email protected]>
…ies.ps1 Co-authored-by: Stijn Moreels <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write-Host when all the policies are successfully retrieving from key vault and also added details in verbose for each policy.
The following fields are printed in verbose logging: Tenant Id; Object Id; Keys; Secrets; Certificates; Storage
Closes #271
Note: The fields Keys, Secrets, Certificates and Storage only display information about the access permissions of the policy, not the sensitive data.
E.g. keys : {Get, List, Set, Delete}