Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary logging in Get-AzKeyVaultAccessPolicies.ps1 #262

Closed
fgheysels opened this issue Jan 7, 2022 · 2 comments · Fixed by #270
Closed

Unnecessary logging in Get-AzKeyVaultAccessPolicies.ps1 #262

fgheysels opened this issue Jan 7, 2022 · 2 comments · Fixed by #270
Assignees
Labels
area:key-vault All issues related to Azure Key Vault enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@fgheysels
Copy link
Member

I was looking at some logs of a devops pipeline where I use the Get-AzKeyVaultAccessPolicies script to retrieve existing access policies, and I noticed a log-entry which doesn't bring any value to the table.

More specifically, I saw this:

Current access policies: @{list=System.Object[]}

Which doesn't really give any added value imho. This is just outputting the type of the variable that contains the access policies, but not the access policies themselves. Additionally, I wonder if we should even output the existing access policies here, as it can be quite a long list which contains a lot of information. (For every access policy, the name of the object that has access + their rights).

I think we should just remove this line of code from the Powershell script.

@fgheysels fgheysels added the good first issue Good for newcomers label Jan 7, 2022
@stijnmoreels
Copy link
Member

Yeah, I saw that too some time ago. We could definitely remove it, as it indeed doesn't add much value. We could, though, still log that we successfully retrieved the access policies. Or something like that. 👍

@stijnmoreels stijnmoreels added this to the v0.6.0 milestone Jan 10, 2022
@stijnmoreels stijnmoreels added area:key-vault All issues related to Azure Key Vault enhancement New feature or request labels Jan 10, 2022
@pim-simons pim-simons self-assigned this Feb 9, 2022
@pim-simons
Copy link
Contributor

Assigned to me, but https://github.com/pimentacodit888 will be working on this 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:key-vault All issues related to Azure Key Vault enhancement New feature or request good first issue Good for newcomers
Projects
None yet
3 participants