feat: remove print "Current access policies: $armAccessPoliciesParameter" #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pimentacodit888
requested review from
mbraekman,
pim-simons and
stijnmoreels
as code owners
|
✔️ Deploy Preview for arcus-scripting canceled. 🔨 Explore the source changes: 1071714 🔍 Inspect the deploy log: https://app.netlify.com/sites/arcus-scripting/deploys/6203eb33fc874e00079f94ea |
pim-simons
changed the title
pim-simons
approved these changes
Feb 10, 2022
|
@pimentacodit888 many thanks for your contribution!! Awesome that you wanted to contribute 👍🏻 |
|
Maybe we should add also a logging statement to show that the retrieval was successful. Now, it will only show that the script got access to the Azure Key Vault. @pim-simons |
Seems like a good idea, I will create a new issue for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove print command "Current access policies: $armAccessPoliciesParameter"
on script arcus.scripting\src\Arcus.Scripting.KeyVault\Scripts\Get-AzKeyVaultAccessPolicies.ps1
Closes #262