Fix rosetta staking balances #15246
Closed
Fix rosetta staking balances #15246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: gedigi <[email protected]> (cherry picked from commit 7097148) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ond the overall commit progress. (cherry picked from commit a6dd53d)
(cherry picked from commit 46364e9)
gregnazario
requested review from
msmouse,
lightmark,
grao1991 and
a team
as code owners
⏱️ 21m total CI duration on this PR
🚨 1 job on the last run was significantly faster/slower than expected
|
gregnazario
force-pushed
the
fix-rosetta-staking-balances
branch
from
1e5c99e to
2b5dd27
Compare
the last refactor made it get staking balances and the account's balance this should fix it so it never cross contaminates between staking, delegated staking, and normal balances. It's much more straightforward and should be easier to understand.
gregnazario
force-pushed
the
fix-rosetta-staking-balances
branch
from
2b5dd27 to
5b12db7
Compare
|
Closed in favor of #15247 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This cleans up and ensures that Rosetta only returns either the base account balances, the staking balances, or the delegated staking balances. It will never return all three at the same time.
How Has This Been Tested?
Tested against existing accounts on mainnet with a local version.
Key Areas to Review
Logically, this should be the same as before. The main issue was the fallthrough behavior that would handle the base account path on every path. Instead it should only be handled on the base path, where staking should do the staking path.
Type of Change
Which Components or Systems Does This Change Impact?
Checklist