Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dry_run env flag #14992

Merged
merged 1 commit into from
Oct 17, 2024
Merged

remove dry_run env flag #14992

merged 1 commit into from
Oct 17, 2024

Conversation

aluon
Copy link
Contributor

@aluon aluon commented Oct 17, 2024

Description

Don't set dry_run in the environment variables. This was getting set to the string 'false' which is a truthy value and results in dry run mode being enabled

How Has This Been Tested?

Ran the workflow manually:
https://github.com/aptos-labs/aptos-core/actions/runs/11378206947

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@aluon aluon requested review from ibalajiarun and sherry-x October 17, 2024 04:09
Copy link

trunk-io bot commented Oct 17, 2024

⏱️ 35m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-doc-tests 5m 🟩
execution-performance / test-target-determinator 4m 🟩
test-target-determinator 4m 🟩
rust-cargo-deny 4m 🟩🟩
check 4m 🟩
check-dynamic-deps 3m 🟩🟩🟩
rust-move-tests 2m 🟩
rust-move-tests 2m 🟩
fetch-last-released-docker-image-tag 2m 🟩
general-lints 1m 🟩🟩
semgrep/ci 1m 🟩🟩🟩
file_change_determinator 34s 🟩🟩🟩
copy-images 31s 🟩
test-copy-images 23s 🟩
rust-move-tests 14s

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 11s 20m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@aluon aluon force-pushed the aluon/fix-release-images-workflow branch from e67fb5a to a06cba7 Compare October 17, 2024 04:10
@aluon aluon marked this pull request as ready for review October 17, 2024 04:10
@aluon aluon requested a review from a team as a code owner October 17, 2024 04:10
@aluon aluon enabled auto-merge (squash) October 17, 2024 04:13

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on a06cba74fdb38829202c3287a22fc7ddd5a4b704

two traffics test: inner traffic : committed: 11865.86 txn/s, latency: 3349.29 ms, (p50: 3000 ms, p70: 3300, p90: 4200 ms, p99: 11200 ms), latency samples: 4511680
two traffics test : committed: 99.96 txn/s, latency: 2705.71 ms, (p50: 2500 ms, p70: 2700, p90: 3600 ms, p99: 9400 ms), latency samples: 1800
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.240, avg: 0.224", "QsPosToProposal: max: 0.644, avg: 0.585", "ConsensusProposalToOrdered: max: 0.339, avg: 0.331", "ConsensusOrderedToCommit: max: 0.597, avg: 0.493", "ConsensusProposalToCommit: max: 0.931, avg: 0.823"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.12s no progress at version 1751159 (avg 0.24s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 7.41s no progress at version 1751157 (avg 6.24s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> a06cba74fdb38829202c3287a22fc7ddd5a4b704

Compatibility test results for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> a06cba74fdb38829202c3287a22fc7ddd5a4b704 (PR)
Upgrade the nodes to version: a06cba74fdb38829202c3287a22fc7ddd5a4b704
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1272.33 txn/s, submitted: 1274.78 txn/s, failed submission: 2.44 txn/s, expired: 2.44 txn/s, latency: 2522.43 ms, (p50: 2100 ms, p70: 2600, p90: 4200 ms, p99: 5700 ms), latency samples: 114580
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1038.98 txn/s, submitted: 1042.09 txn/s, failed submission: 3.11 txn/s, expired: 3.11 txn/s, latency: 2875.95 ms, (p50: 2700 ms, p70: 3300, p90: 4500 ms, p99: 6000 ms), latency samples: 93520
5. check swarm health
Compatibility test for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> a06cba74fdb38829202c3287a22fc7ddd5a4b704 passed
Upgrade the remaining nodes to version: a06cba74fdb38829202c3287a22fc7ddd5a4b704
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1182.23 txn/s, submitted: 1185.33 txn/s, failed submission: 3.10 txn/s, expired: 3.10 txn/s, latency: 2557.86 ms, (p50: 2400 ms, p70: 2700, p90: 3900 ms, p99: 4700 ms), latency samples: 106780
Test Ok

Copy link
Contributor

✅ Forge suite compat success on b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> a06cba74fdb38829202c3287a22fc7ddd5a4b704

Compatibility test results for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> a06cba74fdb38829202c3287a22fc7ddd5a4b704 (PR)
1. Check liveness of validators at old version: b29f09f57e898d8d211c8bc3e303f6e50bba2266
compatibility::simple-validator-upgrade::liveness-check : committed: 13450.05 txn/s, latency: 2509.77 ms, (p50: 2100 ms, p70: 2300, p90: 4200 ms, p99: 8600 ms), latency samples: 437720
2. Upgrading first Validator to new version: a06cba74fdb38829202c3287a22fc7ddd5a4b704
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6565.18 txn/s, latency: 4232.53 ms, (p50: 4900 ms, p70: 5100, p90: 5400 ms, p99: 5900 ms), latency samples: 114920
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6629.93 txn/s, latency: 4786.86 ms, (p50: 4900 ms, p70: 5300, p90: 6900 ms, p99: 7200 ms), latency samples: 224340
3. Upgrading rest of first batch to new version: a06cba74fdb38829202c3287a22fc7ddd5a4b704
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6653.08 txn/s, latency: 4227.30 ms, (p50: 4700 ms, p70: 5000, p90: 5400 ms, p99: 5400 ms), latency samples: 123500
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 5771.68 txn/s, latency: 5522.81 ms, (p50: 5700 ms, p70: 5900, p90: 7500 ms, p99: 7800 ms), latency samples: 194680
4. upgrading second batch to new version: a06cba74fdb38829202c3287a22fc7ddd5a4b704
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 10632.02 txn/s, latency: 2553.23 ms, (p50: 2600 ms, p70: 2700, p90: 3700 ms, p99: 3900 ms), latency samples: 187740
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 9995.22 txn/s, latency: 3079.28 ms, (p50: 2800 ms, p70: 3000, p90: 5700 ms, p99: 6900 ms), latency samples: 324900
5. check swarm health
Compatibility test for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> a06cba74fdb38829202c3287a22fc7ddd5a4b704 passed
Test Ok

@aluon aluon merged commit 46364e9 into main Oct 17, 2024
92 of 94 checks passed
@aluon aluon deleted the aluon/fix-release-images-workflow branch October 17, 2024 04:47
github-actions bot pushed a commit that referenced this pull request Oct 28, 2024
(cherry picked from commit 46364e9)
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
aptos-release-v1.22

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

sherry-x pushed a commit that referenced this pull request Oct 28, 2024
(cherry picked from commit 46364e9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants