-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove dry_run env flag #14992
Merged
Merged
remove dry_run env flag #14992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 35m total CI duration on this PR
🚨 1 job on the last run was significantly faster/slower than expected
|
aluon
force-pushed
the
aluon/fix-release-images-workflow
branch
from
October 17, 2024 04:10
e67fb5a
to
a06cba7
Compare
sherry-x
approved these changes
Oct 17, 2024
ibalajiarun
approved these changes
Oct 17, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
github-actions bot
pushed a commit
that referenced
this pull request
Oct 28, 2024
(cherry picked from commit 46364e9)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
sherry-x
pushed a commit
that referenced
this pull request
Oct 28, 2024
(cherry picked from commit 46364e9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Don't set
dry_run
in the environment variables. This was getting set to the string'false'
which is a truthy value and results in dry run mode being enabledHow Has This Been Tested?
Ran the workflow manually:
https://github.com/aptos-labs/aptos-core/actions/runs/11378206947
Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?
Checklist