Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create signer_native_format_fix.yaml #15088

Merged

Conversation

junkil-park
Copy link
Contributor

Description

This enables the fix for the issue of string_utils::native_format in formatting signer values

Copy link

trunk-io bot commented Oct 25, 2024

⏱️ 55m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-unit-tests 23m 🟩
test-target-determinator 5m 🟩
execution-performance / test-target-determinator 5m 🟩
rust-doc-tests 5m 🟩
check 4m 🟩
rust-cargo-deny 4m 🟩🟩
fetch-last-released-docker-image-tag 2m 🟩
rust-move-tests 2m 🟩
check-dynamic-deps 2m 🟩🟩
rust-move-tests 2m 🟩
general-lints 1m 🟩🟩
semgrep/ci 54s 🟩🟩
file_change_determinator 20s 🟩🟩
execution-performance / single-node-performance 10s 🟩
file_change_determinator 9s 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 10s 17m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@junkil-park junkil-park changed the base branch from main to aptos-release-v1.22 October 25, 2024 21:59
@runtian-zhou
Copy link
Contributor

Was wondering if we just add this feature flag change to the framework release proposal?

@junkil-park junkil-park enabled auto-merge (squash) October 25, 2024 22:55
@junkil-park junkil-park requested review from wrwg and movekevin October 25, 2024 23:03

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 7eeba4cd15892717741a614add1afde004c7855f ==> e955d87ef707b7df19aa7720e2d4e19e7787fece

Compatibility test results for 7eeba4cd15892717741a614add1afde004c7855f ==> e955d87ef707b7df19aa7720e2d4e19e7787fece (PR)
1. Check liveness of validators at old version: 7eeba4cd15892717741a614add1afde004c7855f
compatibility::simple-validator-upgrade::liveness-check : committed: 13277.18 txn/s, latency: 2601.49 ms, (p50: 2200 ms, p70: 2400, p90: 3300 ms, p99: 9100 ms), latency samples: 504440
2. Upgrading first Validator to new version: e955d87ef707b7df19aa7720e2d4e19e7787fece
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7086.89 txn/s, latency: 3952.91 ms, (p50: 4400 ms, p70: 4700, p90: 4900 ms, p99: 5000 ms), latency samples: 134420
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 5881.60 txn/s, latency: 5463.80 ms, (p50: 5700 ms, p70: 5800, p90: 7200 ms, p99: 7500 ms), latency samples: 222900
3. Upgrading rest of first batch to new version: e955d87ef707b7df19aa7720e2d4e19e7787fece
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 1832.72 txn/s, submitted: 1832.87 txn/s, expired: 0.16 txn/s, latency: 4005.09 ms, (p50: 4600 ms, p70: 4800, p90: 5000 ms, p99: 5100 ms), latency samples: 129369
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7403.85 txn/s, latency: 4349.85 ms, (p50: 4800 ms, p70: 4900, p90: 5100 ms, p99: 5200 ms), latency samples: 247300
4. upgrading second batch to new version: e955d87ef707b7df19aa7720e2d4e19e7787fece
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 9741.78 txn/s, latency: 2650.24 ms, (p50: 2500 ms, p70: 2800, p90: 4400 ms, p99: 5700 ms), latency samples: 203600
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 9201.98 txn/s, latency: 3322.79 ms, (p50: 2900 ms, p70: 3100, p90: 6800 ms, p99: 8700 ms), latency samples: 305360
5. check swarm health
Compatibility test for 7eeba4cd15892717741a614add1afde004c7855f ==> e955d87ef707b7df19aa7720e2d4e19e7787fece passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on e955d87ef707b7df19aa7720e2d4e19e7787fece

two traffics test: inner traffic : committed: 12721.78 txn/s, submitted: 12722.51 txn/s, expired: 0.74 txn/s, latency: 3112.80 ms, (p50: 2700 ms, p70: 3000, p90: 3900 ms, p99: 12600 ms), latency samples: 4837100
two traffics test : committed: 99.91 txn/s, latency: 2637.50 ms, (p50: 1600 ms, p70: 1900, p90: 6200 ms, p99: 13200 ms), latency samples: 1740
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.235, avg: 0.218", "QsPosToProposal: max: 0.810, avg: 0.664", "ConsensusProposalToOrdered: max: 0.327, avg: 0.314", "ConsensusOrderedToCommit: max: 0.498, avg: 0.478", "ConsensusProposalToCommit: max: 0.822, avg: 0.792"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.18s no progress at version 2248538 (avg 0.22s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.29s no progress at version 2248536 (avg 8.29s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on 7eeba4cd15892717741a614add1afde004c7855f ==> e955d87ef707b7df19aa7720e2d4e19e7787fece

Compatibility test results for 7eeba4cd15892717741a614add1afde004c7855f ==> e955d87ef707b7df19aa7720e2d4e19e7787fece (PR)
Upgrade the nodes to version: e955d87ef707b7df19aa7720e2d4e19e7787fece
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1188.14 txn/s, submitted: 1190.80 txn/s, failed submission: 2.66 txn/s, expired: 2.66 txn/s, latency: 2530.05 ms, (p50: 2400 ms, p70: 2600, p90: 3900 ms, p99: 5600 ms), latency samples: 107240
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1216.88 txn/s, submitted: 1219.98 txn/s, failed submission: 3.09 txn/s, expired: 3.09 txn/s, latency: 2623.17 ms, (p50: 2400 ms, p70: 2700, p90: 4400 ms, p99: 5700 ms), latency samples: 110140
5. check swarm health
Compatibility test for 7eeba4cd15892717741a614add1afde004c7855f ==> e955d87ef707b7df19aa7720e2d4e19e7787fece passed
Upgrade the remaining nodes to version: e955d87ef707b7df19aa7720e2d4e19e7787fece
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1195.92 txn/s, submitted: 1198.80 txn/s, failed submission: 2.88 txn/s, expired: 2.88 txn/s, latency: 2621.40 ms, (p50: 2400 ms, p70: 2700, p90: 3900 ms, p99: 5300 ms), latency samples: 107940
Test Ok

@junkil-park junkil-park merged commit 23a2cd8 into aptos-release-v1.22 Oct 25, 2024
91 of 92 checks passed
@junkil-park junkil-park deleted the jpark/enable-feature-signer-native-format-fix branch October 25, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants