Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 9410 by removing special-case hack to suppress unknown attribute warnings on aptos_stdlib #10175

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

brmataptos
Copy link
Contributor

Description

PR 9229 introduced warnings on unknown attributes, but suppressed them for aptos_stdlib to avoid user consternation about problems in the Aptos codebase. It also removed those attributes from the codebase, so now that it is released it becomes safe to Fix issue 9410 and remove the special-case for the aptos_stdlib.

Test Plan

Existing test cases, new test outputs.

Copy link
Contributor

@vineethk vineethk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@brmataptos brmataptos enabled auto-merge (squash) September 22, 2023 03:37
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.6.2 ==> 93f19a89449ffb5711fe654035ee6321096f2abe

Compatibility test results for aptos-node-v1.6.2 ==> 93f19a89449ffb5711fe654035ee6321096f2abe (PR)
1. Check liveness of validators at old version: aptos-node-v1.6.2
compatibility::simple-validator-upgrade::liveness-check : committed: 2869 txn/s, latency: 10965 ms, (p50: 12000 ms, p90: 15800 ms, p99: 16400 ms), latency samples: 111900
2. Upgrading first Validator to new version: 93f19a89449ffb5711fe654035ee6321096f2abe
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1851 txn/s, latency: 15669 ms, (p50: 19800 ms, p90: 22000 ms, p99: 22400 ms), latency samples: 92580
3. Upgrading rest of first batch to new version: 93f19a89449ffb5711fe654035ee6321096f2abe
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1714 txn/s, latency: 16150 ms, (p50: 19000 ms, p90: 22000 ms, p99: 22500 ms), latency samples: 90880
4. upgrading second batch to new version: 93f19a89449ffb5711fe654035ee6321096f2abe
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2542 txn/s, latency: 12024 ms, (p50: 12600 ms, p90: 17400 ms, p99: 18400 ms), latency samples: 111860
5. check swarm health
Compatibility test for aptos-node-v1.6.2 ==> 93f19a89449ffb5711fe654035ee6321096f2abe passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 93f19a89449ffb5711fe654035ee6321096f2abe

two traffics test: inner traffic : committed: 6134 txn/s, latency: 6384 ms, (p50: 6000 ms, p90: 8400 ms, p99: 12300 ms), latency samples: 2656420
two traffics test : committed: 100 txn/s, latency: 3220 ms, (p50: 3000 ms, p90: 3700 ms, p99: 7200 ms), latency samples: 1800
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.245, avg: 0.218", "QsPosToProposal: max: 0.167, avg: 0.159", "ConsensusProposalToOrdered: max: 0.690, avg: 0.651", "ConsensusOrderedToCommit: max: 0.559, avg: 0.526", "ConsensusProposalToCommit: max: 1.200, avg: 1.177"]
Max round gap was 1 [limit 4] at version 974624. Max no progress secs was 3.528102 [limit 10] at version 974624.
Test Ok

@brmataptos brmataptos disabled auto-merge September 22, 2023 04:16
@github-actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.5.1 ==> 93f19a89449ffb5711fe654035ee6321096f2abe

Compatibility test results for aptos-node-v1.5.1 ==> 93f19a89449ffb5711fe654035ee6321096f2abe (PR)
Upgrade the nodes to version: 93f19a89449ffb5711fe654035ee6321096f2abe
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 5576 txn/s, latency: 5986 ms, (p50: 6000 ms, p90: 9600 ms, p99: 10500 ms), latency samples: 195180
5. check swarm health
Compatibility test for aptos-node-v1.5.1 ==> 93f19a89449ffb5711fe654035ee6321096f2abe passed
Test Ok

@brmataptos brmataptos merged commit 82af7ac into aptos-labs:main Sep 22, 2023
78 of 81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants