Fix issue 9410 by removing special-case hack to suppress unknown attribute warnings on aptos_stdlib #10167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vineethk
approved these changes
Sep 21, 2023
| ┌─ tests/move_check/parser/aptos_stdlib_attributes.move:7:7 | ||
| │ | ||
| 7 │ #[testonly] | ||
| │ ^^^^^^^^ Attribute name 'testonly' is unknown (use --skip-attribute-checks CLI option to ignore); known attributes are '{"bytecode_instruction", "deprecated", "expected_failure", "native_interface", "test", "test_only", "verify_only"}'. |
There was a problem hiding this comment.
Not a comment for this PR, but this seems like a good candidate for the move linter (to identify the closest allowed attribute and suggest it as fix).
There was a problem hiding this comment.
Well, there is a list displayed. Good point, though.
|
Note this PR was defective (was on my main instead of a branch), so I've closed it and am reopening as #10175. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR 9229 introduced warnings on unknown attributes, but suppressed them for aptos_stdlib to avoid user consternation about problems in the Aptos codebase. It also removed those attributes from the codebase, so now that it is released it becomes safe to Fix issue 9410 and remove the special-case for the aptos_stdlib.
Test Plan
Existing test cases, new test outputs.