Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Turn off suppression of warnings on unknown attributes in library code when it's safe #9410

Closed
brmataptos opened this issue Aug 1, 2023 · 1 comment
Closed

[Bug] Turn off suppression of warnings on unknown attributes in library code when it's safe #9410

brmataptos opened this issue Aug 1, 2023 · 1 comment
Assignees
@brmataptos
Labels
bug Something isn't working stale-exempt Prevents issues from being automatically marked and closed as stale

Comments

@brmataptos
Copy link
Contributor

🐛 Bug

I'm soon going to deploy a fix to warn on unknown attributes in Move code, but will include a suppression for library code until libraries can be updated. Once fixed libraries are deployed everywhere we should remove that suppression (search for this issue # in third-party/move/move-compiler/src/expansion/translate.rs).
@brmataptos brmataptos added the bug Something isn't working label Aug 1, 2023
@brmataptos brmataptos self-assigned this Aug 1, 2023
@sausagee sausagee added the stale-exempt Prevents issues from being automatically marked and closed as stale label Aug 2, 2023
@lbmeiyi lbmeiyi moved this from 🆕 New to 📋 Backlog in Move Language and Runtime Aug 2, 2023
This was referenced Sep 21, 2023
Closed
Merged
@brmataptos
Copy link
Contributor Author

This was merged.

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Move Language and Runtime Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brmataptos brmataptos

Labels
bug Something isn't working stale-exempt Prevents issues from being automatically marked and closed as stale
Projects
Move Language and Runtime
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sausagee @brmataptos