[Bug][move-compiler-v2] Some remaining V1 tests have issues when ported to V2 #13747
Assignees
Labels
bug
Something isn't working
compiler-v2-stable
compiler-v2
stale-exempt
Prevents issues from being automatically marked and closed as stale
Comments
sausagee
added
the
stale-exempt
wrwg
added a commit
that referenced
this issue
Aug 19, 2024
This goes through all urgent bugs in the spreadsheet from issue #13747 and verifies that they have been resolved with recent changes.
15 tasks
wrwg
added a commit
that referenced
this issue
Aug 19, 2024
This goes through all urgent bugs in the spreadsheet from issue #13747 and verifies that they have been resolved with recent changes.
wrwg
added a commit
that referenced
this issue
Aug 19, 2024
This goes through all urgent bugs in the spreadsheet from issue #13747 and verifies that they have been resolved with recent changes.
wrwg
added a commit
that referenced
this issue
Aug 19, 2024
This goes through all urgent bugs in the spreadsheet from issue #13747 and verifies that they have been resolved with recent changes.
wrwg
added a commit
that referenced
this issue
Aug 19, 2024
* [compiler-v2] Adding and verifying some missing v1 tests This goes through all urgent bugs in the spreadsheet from issue #13747 and verifies that they have been resolved with recent changes. * [compiler-v2] Do not pop non-droppables on stack flush Fixes #14233 On stack flush we must not pop values which cannot be dropped. Rather they should be stored in temps. This faciltates scenarios where an `abort` happens before the end of a block. Without this, we pop the value before the abort, leading to a bytecode verification error. There is still an issue with a missing warning, added #14320 for that. * Addressing reviewer feedback * Fix wrong naming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🐛 Bug
I moved all remaining V1 tests under tests/more-v1/, carefully compared outputs, and saw a number of variations.
High-level analysis is here:
The analysis is still preliminary, so it's hard to file distinct issues. As we decide which are actual bugs and which are really the same bug we can file issues and link them in the spreadsheet and here.
Detailed diffs are here:
The color one is useful for viewing in
less -Rin a terminal.Verification and deprecation test issues are not visible in the diff, as they are already addressed in Issue #13696 and PR #13732.
The text was updated successfully, but these errors were encountered: