Honor #[verify_only] in move-compiler-v2. Add relevant tests from v1. Also add tests of #[deprecated].
#13732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 6h 2m total CI duration on this PR
🚨 1 job on the last run was significantly faster/slower than expected
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13732 +/- ##
=======================================
Coverage 59.0% 59.0%
=======================================
Files 820 820
Lines 197375 197445 +70
=======================================
+ Hits 116553 116598 +45
- Misses 80822 80847 +25 ☔ View full report in Codecov by Sentry. |
rahxephon89
reviewed
Jun 18, 2024
|
|
||
| /// Whether to compile #[verify_only] code | ||
| #[clap(skip)] | ||
| pub compile_verify_code: bool, |
There was a problem hiding this comment.
Could you point to where this flag is used apart from unit tests?
There was a problem hiding this comment.
run_move_prover_v2(), in third_party/move/move-prover/src/lib.rs.
rahxephon89
approved these changes
Jun 18, 2024
wrwg
approved these changes
Jun 19, 2024
| @@ -25,29 +31,36 @@ pub struct Options { | |||
| num_args = 0.. | |||
| )] | |||
| pub dependencies: Vec<String>, | |||
|
|
|||
There was a problem hiding this comment.
Has this been done by the auto formatter? Please note that there is no agreement in general what is the better style, it actually pretty much depends on the IDE and font you are using. Its not necessarily better now. I would leave such decisions of formatting at the author and not enforce my private style tastes.
There was a problem hiding this comment.
I just can't read it the other way. Call it an accessibility issue for the partially-blind.
|
|
||
| #[clap(long = cli::MOVE_COMPILER_WARN_OF_DEPRECATION_USE_FLAG, | ||
| default_value=bool_to_str(move_compiler_warn_of_deprecation_use_env_var()))] | ||
| pub warn_deprecated: bool, |
There was a problem hiding this comment.
Just wondering how this relates to the title of the PR. Should you update the title?
There was a problem hiding this comment.
Fixed it. Though it's the final commit message that really matters.
brmataptos
changed the title
#[verify_only] in move-compiler-v2. Add relevant tests from v1.#[verify_only] in move-compiler-v2. Add relevant tests from v1. Also add tests of #[deprecated].
brmataptos
force-pushed
the
brm-issue-13696
branch
from
9d6955a to
518a991
Compare
…ing and tests that it is set when appropriate
…tion and keep_testing_functions
…verification and keep_testing_functions" This reverts commit 355e14e.
Closes #13737. This removes, in the generic parser AST filter, spec blocks for members which are filtered out. For example, for a `#[test_only]` function which is filtered out, also an associated spec block will be removed. This works equally for other attributes like `#[verify_only]` thanks to the generic filter logic.
brmataptos
force-pushed
the
brm-issue-13696
branch
from
518a991 to
f6d29c7
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
21 tasks
21 tasks
brmataptos
added a commit
that referenced
this pull request
Jul 3, 2024
Cleanup of the the move_pr.sh script to allow use in CI:
- relocate v2 doc test outputs, use v2 to build for v2 integration tests
- env var `MVC_DOCGEN_OUTPUT_DIR` is set by V2 tests to relocate doc outputs for V2
- use nextest -profile smoke-test by default to tolerate rare Heisenbugs by replaying 3x
- env var `MOVE_PR_NEXTEST_PROFILE` allows `smoke-test` to be overridden.
- a few cleanups
- paying attention to env var `MOVE_PR_PROFILE` if set
- Add a few compiler-v2 verification tests and update to v1.matched that were left over from #13732
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add options and plumbing for compile_verify_code, warn_deprecated, etc. to move-compiler-v2, and test add relevant tests from v1. Requires disabling verify by default in compiler path in move-model.
Fixes #13696.
Merged in a commit from Wolfgang to fix #13737.
How Has This Been Tested?
Added relevant tests from V1 under tests/more-v1/. Also ran
move_pr.sh, which uncovers issue #13737, which is now also fixed here, thanks to Wolfgang. Added new tests to illustrate #13737: function_with_spec.move to test#[verify_only]and#[test_only]with associatedspecblocks for verify and testing on and off.Key Areas to Review
Is plumbing correct?
Type of Change
Which Components or Systems Does This Change Impact?
Checklist