[compiler-v2] Adding and verifying some missing v1 tests

[wrwg]

Description

This goes through all urgent bugs in the spreadsheet from issue #13747 and verifies that they have been resolved with recent changes.

Type of Change

• New feature
• Bug fix
• Breaking change
• Performance improvement
• Refactoring
• Dependency update
• Documentation update
• Tests

Which Components or Systems Does This Change Impact?

• Validator Node
• Full Node (API, Indexer, etc.)
• Move/Aptos Virtual Machine
• Aptos Framework
• Aptos CLI/SDK
• Developer Infrastructure
• Other (specify)

How Has This Been Tested?

Migrates tests from v1 to v2

[trunk-io]

⏱️ 2h 49m total CI duration on this PR

Job	Cumulative Duration	Recent Runs
execution-performance / single-node-performance	21m	🟩
forge-framework-upgrade-test / forge	20m	🟩
forge-e2e-test / forge	17m	🟩
forge-compat-test / forge	13m	🟩
rust-move-tests	9m	🟩
rust-move-unit-coverage	9m	🟩
rust-move-tests	8m	🟩
rust-move-unit-coverage	8m	🟩
rust-move-tests	8m	⬜
rust-move-tests	8m	🟩
rust-move-unit-coverage	8m	🟩
general-lints	7m	🟩 🟩 🟩 🟩
rust-cargo-deny	7m	🟩 🟩 🟩 🟩
check-dynamic-deps	5m	🟩 🟩 🟩 🟩
rust-doc-tests	5m	🟩
execution-performance / test-target-determinator	4m	🟩
test-target-determinator	4m	🟩
check	4m	🟩
semgrep/ci	2m	🟩 🟩 🟩 🟩
file_change_determinator	46s	🟩 🟩 🟩 🟩
file_change_determinator	45s	🟩 🟩 🟩 🟩
permission-check	14s	🟩 🟩 🟩 🟩
permission-check	12s	🟩 🟩 🟩 🟩
file_change_determinator	10s	🟩
permission-check	10s	🟩 🟩 🟩 🟩
permission-check	9s	🟩 🟩 🟩 🟩
Backport PR	6s	🟥
determine-docker-build-metadata	4s	🟩
permission-check	3s	🟩
permission-check	2s	🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
forge-framework-upgrade-test / forge	20m	12m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[wrwg]

• [compiler-v2] Do not pop non-droppables on stack flush #14321
• [compiler-v2] Adding and verifying some missing v1 tests #14316 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @wrwg and the rest of your teammates on Graphite

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.4%. Comparing base (0b2cd51) to head (3f9dcd5).
Report is 10 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #14316   +/-   ##
=======================================
  Coverage    59.4%    59.4%           
=======================================
  Files         834      834           
  Lines      203852   203852           
=======================================
+ Hits       121141   121146    +5     
+ Misses      82711    82706    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

✅ Forge suite compat success on d1bf834728a0cf166d993f4728dfca54f3086fb0 ==> 3f9dcd529f740ea86938f066b3a7bc7bdf6f0e0d

Compatibility test results for d1bf834728a0cf166d993f4728dfca54f3086fb0 ==> 3f9dcd529f740ea86938f066b3a7bc7bdf6f0e0d (PR)
1. Check liveness of validators at old version: d1bf834728a0cf166d993f4728dfca54f3086fb0
compatibility::simple-validator-upgrade::liveness-check : committed: 5171.07 txn/s, latency: 5525.40 ms, (p50: 2500 ms, p90: 13500 ms, p99: 36500 ms), latency samples: 246620
2. Upgrading first Validator to new version: 3f9dcd529f740ea86938f066b3a7bc7bdf6f0e0d
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6844.27 txn/s, latency: 4077.75 ms, (p50: 4200 ms, p90: 5600 ms, p99: 5800 ms), latency samples: 123900
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7421.23 txn/s, latency: 4334.82 ms, (p50: 4500 ms, p90: 4900 ms, p99: 5100 ms), latency samples: 251620
3. Upgrading rest of first batch to new version: 3f9dcd529f740ea86938f066b3a7bc7bdf6f0e0d
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6014.52 txn/s, latency: 4221.14 ms, (p50: 4700 ms, p90: 5100 ms, p99: 5200 ms), latency samples: 126380
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6556.55 txn/s, latency: 4673.63 ms, (p50: 4500 ms, p90: 7400 ms, p99: 7700 ms), latency samples: 218000
4. upgrading second batch to new version: 3f9dcd529f740ea86938f066b3a7bc7bdf6f0e0d
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 8905.07 txn/s, latency: 3154.89 ms, (p50: 2900 ms, p90: 4400 ms, p99: 5500 ms), latency samples: 157960
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10288.91 txn/s, latency: 3113.32 ms, (p50: 2700 ms, p90: 4500 ms, p99: 5800 ms), latency samples: 348580
5. check swarm health
Compatibility test for d1bf834728a0cf166d993f4728dfca54f3086fb0 ==> 3f9dcd529f740ea86938f066b3a7bc7bdf6f0e0d passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite realistic_env_max_load success on 3f9dcd529f740ea86938f066b3a7bc7bdf6f0e0d

two traffics test: inner traffic : committed: 11427.66 txn/s, latency: 3479.09 ms, (p50: 3300 ms, p90: 4100 ms, p99: 6900 ms), latency samples: 4345020
two traffics test : committed: 99.91 txn/s, latency: 2986.52 ms, (p50: 2700 ms, p90: 4000 ms, p99: 8700 ms), latency samples: 1740
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.242, avg: 0.222", "QsPosToProposal: max: 0.543, avg: 0.481", "ConsensusProposalToOrdered: max: 0.375, avg: 0.341", "ConsensusOrderedToCommit: max: 0.768, avg: 0.666", "ConsensusProposalToCommit: max: 1.135, avg: 1.008"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.57s no progress at version 14205 (avg 0.24s) [limit 15].
Max epoch-change gap was: 1 rounds at version 2389193 (avg 1.00) [limit 4], 8.93s no progress at version 2389193 (avg 8.93s) [limit 15].
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite framework_upgrade success on d1bf834728a0cf166d993f4728dfca54f3086fb0 ==> 3f9dcd529f740ea86938f066b3a7bc7bdf6f0e0d

Compatibility test results for d1bf834728a0cf166d993f4728dfca54f3086fb0 ==> 3f9dcd529f740ea86938f066b3a7bc7bdf6f0e0d (PR)
Upgrade the nodes to version: 3f9dcd529f740ea86938f066b3a7bc7bdf6f0e0d
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1199.84 txn/s, submitted: 1202.90 txn/s, failed submission: 3.06 txn/s, expired: 3.06 txn/s, latency: 2790.64 ms, (p50: 2200 ms, p90: 5600 ms, p99: 7200 ms), latency samples: 102000
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1036.91 txn/s, submitted: 1038.47 txn/s, failed submission: 1.56 txn/s, expired: 1.56 txn/s, latency: 3073.58 ms, (p50: 2700 ms, p90: 5300 ms, p99: 6800 ms), latency samples: 93240
5. check swarm health
Compatibility test for d1bf834728a0cf166d993f4728dfca54f3086fb0 ==> 3f9dcd529f740ea86938f066b3a7bc7bdf6f0e0d passed
Upgrade the remaining nodes to version: 3f9dcd529f740ea86938f066b3a7bc7bdf6f0e0d
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1135.02 txn/s, submitted: 1136.56 txn/s, failed submission: 1.54 txn/s, expired: 1.54 txn/s, latency: 2633.75 ms, (p50: 2400 ms, p90: 4100 ms, p99: 6000 ms), latency samples: 102940
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking