Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual Studio 2019 #2907

Closed
chronoxor opened this issue Apr 8, 2019 · 74 comments
Closed

Visual Studio 2019 #2907

chronoxor opened this issue Apr 8, 2019 · 74 comments
Milestone
next vs2019 image...

Comments

@chronoxor
Copy link

chronoxor commented Apr 8, 2019 •
edited
Loading

Can you please give estimations when the "Visual Studio 2019" image will be available?
@m-tmatma m-tmatma mentioned this issue Apr 10, 2019
Closed
3 tasks
@EwoutH
Copy link
Contributor

EwoutH commented Apr 12, 2019

Visual Studio 2019 version 16.0.1 is out now

@EwoutH EwoutH mentioned this issue Apr 16, 2019
Closed
@XVilka XVilka mentioned this issue Apr 17, 2019
Open
@micbou micbou mentioned this issue Apr 23, 2019
Merged
zzbot added a commit to ycm-core/YouCompleteMe that referenced this issue Apr 24, 2019
@zzbot
Auto merge of #3378 - micbou:visual-studio-build-tools, r=bstaletic
2ae0044 
[READY] Instruct installing Visual Studio Build Tools 2017

As suggested by @bstaletic in #3376 (comment), Visual Studio Build Tools is sufficient to build YCM. Users are told to download the 2017 version since 2019 is not yet supported (require a change to the `build.py` script and [waiting for AppVeyor to release the image](appveyor/ci#2907)).

Closes #3376.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/3378)
<!-- Reviewable:end -->
@zspitz zspitz mentioned this issue Apr 30, 2019
Closed
@EwoutH
Copy link
Contributor

EwoutH commented May 1, 2019

Visual Studio 2019 version 16.0.3 was just released.

Any ETA on the VS 2019 image?

@IlyaFinkelshteyn
Copy link
Contributor

Should be available this month, but cannot give a specific promises.

@MarcoRossignoli MarcoRossignoli mentioned this issue May 2, 2019
Merged
zspitz added a commit to zspitz/ExpressionTreeVisualizer that referenced this issue May 3, 2019
@zspitz
Disable 2019 build pending appveyor/ci#2907
b9edf91
@Zingam
Copy link

Zingam commented May 3, 2019

Should be available this month, but cannot give a specific promises.

Are the preview versions of VS2019 (currently 16.1.0) supported/included? I adopt some C++20 features as they become available.

@Cheesebaron Cheesebaron mentioned this issue May 13, 2019
Merged
4 tasks
This was referenced May 15, 2019
Merged
Open
@IlyaFinkelshteyn IlyaFinkelshteyn mentioned this issue May 21, 2019
Merged
@IlyaFinkelshteyn
Copy link
Contributor

First draft of Visual Studio 2019 image is available. At the moment we do not have an official list of installed software. but you can get a good idea by looking into respective packer configuration.

We will update the image per your feedback.

We enable it per request now. We already enabled it for those who reacted to this comment. Send us your AppVeyor account if you do not see this image available for you.

Note that this image runs on Azure so build Starting stage will be 2-4 minutes (time to provision Azure VM).

@EwoutH
Copy link
Contributor

EwoutH commented May 21, 2019

@IlyaFinkelshteyn Thanks for the update!

Could you add https://github.com/Xiph, https://github.com/OpenVisualCloud and https://github.com/EwoutH?

@IlyaFinkelshteyn
Copy link
Contributor

@EwoutH please try now... hopefully I guessed AppVeyor accounts (which are not always the same as GitHub users) correctly.

@mikejsavage
Copy link

Please could you enable it for this account? Appveyor user is also mikejsavage

@IlyaFinkelshteyn
Copy link
Contributor

@mikejsavage enabled

@xt0rted
Copy link

xt0rted commented May 22, 2019

@IlyaFinkelshteyn could you enable it for this account please?

@IlyaFinkelshteyn
Copy link
Contributor

@xt0rted done, please try.

@Croydon
Copy link

Croydon commented May 22, 2019

@IlyaFinkelshteyn Could you please enable for bincrafters (both AppVeyor and GitHub name)?

@IlyaFinkelshteyn
Copy link
Contributor

@Croydon sure, it is enabled. It was actually enabled already as we did it for all who reacted to this comment :)

@Croydon
Copy link

Croydon commented May 22, 2019 •
edited
Loading

@IlyaFinkelshteyn Thanks!

The current installed CMake version is 3.13 https://github.com/appveyor/build-images/blob/09fe483c20cfc4dd6218deb0037a10a9dc98f035/scripts/Windows/install_cmake.ps1#L1

Unfortunately, only CMake >= 3.14 is supporting Visual Studio 2019 so all CMake builds are blocked for the moment until CMake gets upgraded

https://cmake.org/cmake/help/v3.14/release/3.14.html#generators

Edit: That's issue #2891 then :)

@matt77hias
Copy link

@IlyaFinkelshteyn could you enable it for this account please?

@mloskot
Copy link

mloskot commented May 27, 2019

Why not to just release the image to the public?

Or, what's the time frame to expect it to happen?

@chronoxor
Copy link
Author

Cygwin issue is fixed for me using additional --site "http://mirrors.kernel.org/sourceware/cygwin" command line argument

@nblumhardt
Copy link

@IlyaFinkelshteyn can you please add support to the @serilog account? Thanks!

@nblumhardt
Copy link

Cancel that - just tried my luck and it seems we can use it already :-)

@EwoutH
Copy link
Contributor

EwoutH commented May 28, 2019 •
edited
Loading

@IlyaFinkelshteyn Could you add https://ci.appveyor.com/project/tdaede/rav1e ?

And https://ci.appveyor.com/project/lu-zero/crav1e please

@IlyaFinkelshteyn
Copy link
Contributor

We actually made Visual Studio 2019 image available for everyone. Though it is still not mature enough, so please send us what we need to add there.

CC @mloskot

@chronoxor
Copy link
Author

chronoxor commented May 28, 2019 •
edited
Loading

@IlyaFinkelshteyn, all my builds passed with new Visual Studio 2019 image! Thanks a lot!

I have to update Cygwin with some packages for my build and install the latest MinGW with additional steps:

  # Cygwin
  - if "%type%"=="Cygwin" if not exist "C:\cygwin64" mkdir "C:\cygwin64"
  - if "%type%"=="Cygwin" appveyor-retry appveyor DownloadFile "http://cygwin.com/setup-x86_64.exe" -FileName "C:\cygwin64\setup-x86_64.exe"
  - if "%type%"=="Cygwin" C:\cygwin64\setup-x86_64.exe --quiet-mode --no-desktop --no-shortcuts --upgrade-also --root "C:\cygwin64" --local-package-dir "C:\cache\cygwin" --site "http://mirrors.kernel.org/sourceware/cygwin" --packages cmake,automake,make,gcc-core,gcc-g++,flex,bison,libjsoncpp19,librhash0,libuuid-devel,libuv1
  # MinGW
  - if "%type%"=="MinGW" if not exist "C:\mingw.7z" appveyor-retry appveyor DownloadFile "http://downloads.sourceforge.net/mingw-w64/x86_64-8.1.0-release-posix-seh-rt_v6-rev0.7z" -FileName "C:\mingw.7z"
  - if "%type%"=="MinGW" 7z x -y -oC:\ "C:\mingw.7z" > nul

It will be great if you update Cygwin with some useful packages (cmake,automake,make,gcc-core,gcc-g++,flex,bison,libjsoncpp19,librhash0,libuuid-devel,libuv1) in C:\cygwin64 and put the latest MinGW 8.1.0 to C:\mingw64 so I can remove this magic steps for the new image.

Thanks in advance!

@jnyrup jnyrup mentioned this issue May 29, 2019
Closed
@Cheesebaron
Copy link

JavaSDK environment variable doesn't seem to be set, which makes Xamarin Android builds fail:

error XA5300: The Java SDK Directory could not be found. Please set via /p:JavaSdkDirectory.

@craftwar
Copy link

VS2019 and VS2017 are ABI-compatible, user may want to use VS2019 in VS2017 projects. It is reasonable to add everything in VS2017 image to VS2019 image.
Is it possible to just add VS2019 into VS2017 image? Can you make VS2019 and VS2017 images the same but default Visual Studio version different?

@XVilka
Copy link

XVilka commented May 30, 2019

I found that Inno Setup (presented in the older images) is now missing from VS2019 one: #2948

@NN---
Copy link

NN--- commented May 30, 2019

Please provide clang-cl with Visual Studio 2019 image.

@ashalkhakov
Copy link

ashalkhakov commented May 31, 2019 •
edited
Loading

Could you please provide WiX 3.11?

EDIT: well, for now I'm just installing it via Chocolatey and it works.

@FunctionPoint FunctionPoint mentioned this issue Jun 1, 2019
Closed
@heydojo
Copy link

heydojo commented Jun 1, 2019

Hi!
Looking forward to trying out the following components in the up coming 2019 image:

  • IncrediBuild
  • MSBuild
  • MSVC v142 (v14.21) Minimum
  • MSVC v142 Spectre mitigation Libs (v14.21) Minimum
  • C++ Core Features
  • Windows 10 SDK (10.0.18362.0) Minimum
  • Windows Universal C runtime

Cheers!

@JustArchi
Copy link

@IlyaFinkelshteyn java command is missing in Visual Studio 2019 image, please consider adding at least one JDK (currently available in 2017 image), thank you!

@JustArchi JustArchi mentioned this issue Jun 1, 2019
Merged
@ice1000 ice1000 mentioned this issue Jun 2, 2019
Closed
@IlyaFinkelshteyn
Copy link
Contributor

IlyaFinkelshteyn commented Jun 3, 2019 •
edited
Loading

@JustArchi @XVilka @Cheesebaron please watch #2961

@IlyaFinkelshteyn
Copy link
Contributor

@ashalkhakov please watch #2963

@IlyaFinkelshteyn
Copy link
Contributor

@NN--- please watch #2964

@IlyaFinkelshteyn
Copy link
Contributor

@heydojo can you please create separate issues? Please check with https://github.com/appveyor/ci/milestone/144 that no duplicates happened

@IlyaFinkelshteyn
Copy link
Contributor

I am closing this issue, because it is difficult to track requests to add a software in comments. Please create a separate new issue if for each new software to add to Visual Studio 2019 image. Please check https://github.com/appveyor/ci/milestone/144 to avoid duplicates.

@nickaein nickaein mentioned this issue Jun 4, 2019
Closed
This was referenced Jun 7, 2019
Closed
Closed
annagrin pushed a commit to microsoft/GSL that referenced this issue Jun 13, 2019
@NN---
Add Visual Studio 2019 image for tests (#787)
1212bea 
* Add Visual Studio 2019 image for tests

Refer to appveyor/ci#2907
VS2019 is enabled per request.

* Use CMake 3.14

* Fix CMake output directory

* trigger build

* Trigger build
versat referenced this issue in danmar/cppcheck Jul 7, 2019
@PKEuS
Updated to Visual Studio 2019
ae86536
mehulagg pushed a commit to mehulagg/superproject that referenced this issue Dec 21, 2019
Update git submodules
2243cd7 
* Update art from branch 'simpleperf-release'
  to 0671f7f1f394966d23fbc7017b9f47eb7dcb157b
  - Fix out-of-bounds read in ApiList::Dump.
    
    In this loop i ranges from DomainApi::kMin to DomainApi:kMax, while API
    names in kDomainApiNames are stored at indexes starting from zero, so we need
    to subtract DomainApi::kMin before indexing into kDomainApiNames. Found by
    running CTS under HWASAN with the new global instrumentation support.
    
    Bug: 139749928
    Change-Id: Ib35c4494e7652cfaf84e07ff362210d67a50fba2
    
  - Reenable LUCI notifications on the ART Buildbot AOSP builders.
    
    The clean steps on the AOSP builders (aosp-builder-cc and
    aosp-builder-cms) used to call "make clean", which sometimes failed
    with this error:
    
      Failed to remove file "out/.module_paths":
      unlinkat out/.module_paths: directory not empty
    
    As a result the LUCI notitications for these builders were disabled.
    
    The clean steps are now using "rm -rf out" instead of "make clean",
    which presubmably addressed the previous issue. Reenable the LUCI
    notifications for aosp-builder-cc and aosp-builder-cms.
    
    Test: Rely on the ART Buildbot
          (https://ci.chromium.org/p/art/builders/ci/aosp-builder-cc
          and https://ci.chromium.org/p/art/builders/ci/aosp-builder-cms)
    Bug: 139655167
    Bug: 131573205
    
    Change-Id: I38f31d2ccf1f337698aaf463d90efc593c666976
    
  - Convert the `art_apex_test.py` script to Python 2.
    
    This might help with build issues recently observed on the ART
    Buildbot on the AOSP builders:
    - aosp-builder-cc (https://ci.chromium.org/p/art/builders/ci/aosp-builder-cc);
    - aosp-builder-cms (https://ci.chromium.org/p/art/builders/ci/aosp-builder-cms).
    
    Test: m art-check-release-apex-gen-fakebin
    Test: m art-check-debug-apex-gen-fakebin
    Test: m art-check-testing-apex-gen-fakebin
    Test: art/build/apex/runtests.sh
    Test: Rely on ART Buildbot AOSP builders aosp-builder-cc and aosp-builder-cms
    Bug: 139655167
    Change-Id: I42574cbfd7c41c937483e3b81427cb9ce71f8925
    
  - JIT mini-debug-info: Allocate entries in the JIT data space.
    
    Test: test.py -b --host --jit
    Test: device boots
    Bug: 119800099
    Change-Id: I7efa1e6e6660239cbd6438b829e08dd9cd079343
    
  - Snap for 5824001 from 9ac8e4327bd732e4b3b9b8dc6a29560013338d21 to simpleperf-release
    
    Change-Id: I1016b2533ffdbdd9988f6329a979a74ce6f76dae
    

* Update bionic from branch 'simpleperf-release'
  to 777403a1dc8ecc5a7c7609c481e8058d6d81acc3
  - Merge "Snap for 5824001 from 436af3d55b26d1204812b4e45fea7bd9feb983e7 to simpleperf-release" into simpleperf-release
  - Snap for 5824001 from 436af3d55b26d1204812b4e45fea7bd9feb983e7 to simpleperf-release
    
    Change-Id: Idf25eba48133bf6d1df8dd04c9f56d12b40577e8
    
  - Merge changes from topic "clang-r365631-switch-over"
    
    * changes:
      Fix segment gap test
      stdatomic_test: always use bits/stdatomic.h
      Adapt tests due to the new Clang fortify-source warning
    
  - Merge "Link libc++demangle."
  - Merge "Reland "fdsan: make fatal by default.""
  - Reland "fdsan: make fatal by default."
    
    The two tests known to be failing (installd_dexopt_test and BpfMapTest)
    have been fixed, so let's try this again.
    
    This reverts commit 76351e3e3fbbd386c059251dbc6b1081a8f77088.
    
    Bug: http://b/137788030
    Bug: http://b/139092341
    Bug: http://b/139175951
    Test: treehugger
    
  - Merge "Automatically include <android/ndk-version.h> from every header."
  - Automatically include <android/ndk-version.h> from every header.
    
    (Via <sys/cdefs.h>, which is where we get <android/api-level.h> from.)
    
    Not super helpful today, but when NDK r21 is the oldest NDK anyone cares
    about, they'll be able to stop worrying about this specific header as
    long as they've included _something_.
    
    Test: builds
    Change-Id: Ia5bc42f89b7025d8e3963e4fd590f0e3723157be
    
  - Fix segment gap test
    
    The test starts failing in the upcoming lld update. The root cause is
    that no relro section is specified by the linker script, and the orphan
    placement algorithm decides to place them after .text which is a
    misaligned place.
    
    Test: bionic-unit-tests
    Bug: 139089152
    Bug: 131328001
    Change-Id: I2140d8a9fd7c712f1d31a541a3b4a10788385e98
    
  - stdatomic_test: always use bits/stdatomic.h
    
    Host includes are updated now, so we always must include
    bits/stdatomic.h
    
    Bug: 137876753
    Bug: 138701943
    Test: not yet
    Change-Id: Ib2ce34ae5dace8f9a114fa8c04f864cd7f41a5d9
    
  - Adapt tests due to the new Clang fortify-source warning
    
    https://reviews.llvm.org/D58797 added several new compile time
    _FORTIFY_SOURCE diagnostics. This broke clang_fortify_tests:
    
    FAILED: out/target/product/walleye/obj/STATIC_LIBRARIES/bionic-compile-time-tests2-clang++_intermediates/clang_fortify_tests.o
    error: 'warning' diagnostics seen but not expected:
      Line 159: 'memcpy' will always overflow; destination buffer has size 8, but size argument is 9
      Line 161: 'memmove' will always overflow; destination buffer has size 8, but size argument is 9
      Line 165: 'memset' will always overflow; destination buffer has size 8, but size argument is 9
      Line 183: 'strncpy' size argument is too large; destination buffer has size 8, but size argument is 9
      Line 185: 'stpncpy' size argument is too large; destination buffer has size 8, but size argument is 9
      Line 189: 'strncat' size argument is too large; destination buffer has size 8, but size argument is 9
      Line 227: 'strncpy' size argument is too large; destination buffer has size 4, but size argument is 5
      Line 232: 'stpncpy' size argument is too large; destination buffer has size 4, but size argument is 5
      Line 242: 'strncat' size argument is too large; destination buffer has size 4, but size argument is 5
      Line 490: 'snprintf' size argument is too large; destination buffer has size 8, but size argument is 9
      Line 495: 'vsnprintf' size argument is too large; destination buffer has size 8, but size argument is 9
    error: 'note' diagnostics seen but not expected:
      File bionic/libc/include/bits/fortify/fcntl.h Line 50: 'open' has been explicitly marked unavailable here
      File bionic/libc/include/bits/fortify/fcntl.h Line 102: 'open64' has been explicitly marked unavailable here
      File bionic/libc/include/bits/fortify/fcntl.h Line 75: 'openat' has been explicitly marked unavailable here
      File bionic/libc/include/bits/fortify/fcntl.h Line 121: 'openat64' has been explicitly marked unavailable here
      File bionic/libc/include/bits/fortify/stdio.h Line 68: 'sprintf' has been explicitly marked unavailable here
    16 errors generated.
    
    Bug: 131328001
    Bug: 138701853
    Test: Build with r365631 toolchain
    Change-Id: I103ecb7b3abcf4b5cfc4f36ccab69e03d0976275
    
  - Link libc++demangle.
    
    The demangler is moving out of libc++abi to save on bloat.
    
    Test: make checkbuild
    Bug: http://b/138245375
    Change-Id: I7402894bb326f524388c9efdf86509dad50f2018
    

* Update build/make from branch 'simpleperf-release'
  to c2bb9b607aa962e4a758557113df4fab4de532fc
  - Merge "Snap for 5824001 from ffdeeae450d98c837b42bbc6ec112cc9a2af36d4 to simpleperf-release" into simpleperf-release
  - Snap for 5824001 from ffdeeae450d98c837b42bbc6ec112cc9a2af36d4 to simpleperf-release
    
    Change-Id: I9448295de446ea00ad2c207180f60361e16ae5e5
    
  - Merge "Remove stale artifact whitelist entries"
  - Merge "Remove package-stats.txt"
  - Merge "SYSTEM_EXT supports executables"
  - Merge "Add "owngrep" shell utility."
  - Merge "Link libc++demangle with libc++ for the device."
  - Merge "Only include the "tools" and "testcases" subdirectories in android-cts.zip."
  - Add "owngrep" shell utility.
    
    Bug: 132612223
    Test: manual
    Change-Id: Ibe27e419caaf4ebcbb5d48ab50cc71730c320e1c
    
  - Merge "Rename Soong variable `FlattenApex` as `Flatten_apex`."
  - Remove package-stats.txt
    
    I can't find any remaining users of this functionality.
    
    Test: codesearch; treehugger
    Change-Id: I63b079b381211b743baa293267c992d9b2eadcf9
    
  - Only include the "tools" and "testcases" subdirectories in android-cts.zip.
    
    Without this, we can end up packaging log files from previous CTS runs in
    the zip file. If the names of those log files contain whitespace characters,
    it can result in a build failure.
    
    Change-Id: Id96d1915a03b6a715acfdc212c9b2d6f28045baa
    
  - Merge "Add group_system_ext and passwd_system_ext"
  - Add group_system_ext and passwd_system_ext
    
    Add the remaining group and passwd files for partitions that have
    reserved AIDs.
    
    Test: mainline checks pass
    Change-Id: Iae62c9465e0144b77b1d804c17fe6e724a744da2
    
  - SYSTEM_EXT supports executables
    
    Because TARGET_OUT_SYSTEM_EXT_EXECUTABLES have been omitted, we cannot
    install any executables in system_ext.
    So fix it.
    
    Test: set system_ext_specific true in some executable, and then check if
    it is installed in /system_ext/bin
    Bug: 139719550
    
    Change-Id: I1bc7a2e6a7c25ec4b5b1ea6358ba8d3e1ae6331b
    
  - Remove stale artifact whitelist entries
    
    Test: lunch mainline_arm64; m nothing
    Change-Id: Ia495ed7b883fd100fdb75206c13cedb6fa62b0b2
    Merged-In: Ia495ed7b883fd100fdb75206c13cedb6fa62b0b2
    
  - Link libc++demangle with libc++ for the device.
    
    libc++demangle provides __cxa_demangle, which used to be a part of
    libc++.so but is being moved out to save on resources since very few
    libraries need it.
    
    Test: make checkbuild
    Bug: http://b/138245375
    Change-Id: I677006dbbe87ccf2dd4df182114d2a6b985e3c00
    
  - Rename Soong variable `FlattenApex` as `Flatten_apex`.
    
    This is so that it can be used as a Soong/Blueprint property.
    
    Test: m
    Bug: 139277987
    Change-Id: I009817e040994738814c92ee007aec9ef2cfa838
    

* Update build/soong from branch 'simpleperf-release'
  to af0f3016a42fb86a92766667589f855ceebf9f63
  - Snap for 5824001 from b020d570038c184a5f1c8523ccf113d742c0fae4 to simpleperf-release
    
    Change-Id: I6319a9b0b254f60a841f7523940d3f9275b0efe7
    
  - Merge "apex: add llndk libs as requireNativeLibs"
  - Merge "Switch to clang-r365631"
  - Merge "Revert "Re-enable ASAN globals instrumentation for devices.""
  - Merge "Always set ASAN_SYMBOLIZER_PATH appropriately"
  - Revert "Re-enable ASAN globals instrumentation for devices."
    
    This reverts commit cba311bcfc698c09841e289537e077905ef9ff44.
    
    The build is actually still broken with ASAN globals instrumentation.
    We accidentally suppressed ASAN by turning on the new pass manager and
    the build breakage was not discovered.
    
    Bug: 137312732
    Bug: 139747256
    Change-Id: I8110e1413468c4d760a59a8de816a72c9852a7c8
    
  - Merge "Link libc++demangle with libc++ for the device."
  - Always set ASAN_SYMBOLIZER_PATH appropriately
    
    Otherwise tools built with ASAN can't symbolize their dumps, as
    llvm-symbolizer is not allowed to be used from $PATH.
    
    Fixes: 139825736
    Test: cherry-pick https://android-review.googlesource.com/c/platform/system/tools/aidl/+/1106532
      mmma ASAN_OPTIONS="" SANITIZE_HOST=address system/tools/aidl
    Change-Id: Ib1eeec15ce6694d7bde54c7201b3280e38df3a83
    
  - Merge "Disable new pass manager for ASAN build"
  - Disable new pass manager for ASAN build
    
    ASAN build has some weird issues with the new pass manager, keep using
    the legacy pass manager for now.
    
    Test: presubmit
    Bug: 139747256
    Change-Id: I345afbf6bc4043f274a4e7545a895b59c65641b0
    
  - Merge "Rename Soong variable `FlattenApex` as `Flatten_apex`."
  - apex: add llndk libs as requireNativeLibs
    
    "use_vendor: true" APEX modules may bundle vendor variants of cc
    modules, which can depend on llndk stubs.
    
    In that case, those llndk libraries should be also counted as required
    libraries. (stored in 'requireNativeLibs' key in apex_manifest.json)
    
    Bug: 138695532
    Test: m nothing (runs soong tests)
    Change-Id: If7ad4dec0e723c8d0c73ca60453b555063e14694
    
  - Switch to clang-r365631
    
    Test: build, boot, bionic-unit-test
    Test: For Googlers, go/clang-r365631-testing
    Bug: 131328001
    Change-Id: Ib357d9044a72e41f6bde1e5ec2db34e90706124d
    
  - Rename Soong variable `FlattenApex` as `Flatten_apex`.
    
    This is so that it can be used as a Soong/Blueprint property.
    
    Test: m
    Bug: 139277987
    Change-Id: I8840811fde92a71e97ed100aacfc7fbb003580d0
    
  - Link libc++demangle with libc++ for the device.
    
    libc++demangle provides __cxa_demangle, which used to be a part of
    libc++.so but is being moved out to save on resources since very few
    libraries need it.
    
    Test: make checkbuild
    Bug: http://b/138245375
    Change-Id: Ie97225d496d7d40f8749522bf36702a2d9dcdfe7
    

* Update cts from branch 'simpleperf-release'
  to f124640054f883ecae93eb754275677ebfa86d97
  - Merge "Snap for 5824001 from e06e843dadee7005ec79d7908d4d49c298b48cce to simpleperf-release" into simpleperf-release
  - Snap for 5824001 from e06e843dadee7005ec79d7908d4d49c298b48cce to simpleperf-release
    
    Change-Id: Id61c09a0a444cc15cecb66301b9e6ece9485345f
    
  - Merge "MmsProvider TestCases"
  - Merge "Fix StagefrightTests"
  - Merge "CtsNdkBinderTestCases: get/setExtension."
  - Merge "Move default MimeMap implementation to frameworks."
  - Merge "Fix up formatting of tests/libcore/luni/Android.bp"
  - CtsNdkBinderTestCases: get/setExtension.
    
    See AIBinder_setExtension and CL on libbinder_ndk.
    
    Bug: 136027762
    Test: atest CtsNdkBinderTestCases
    Change-Id: I8eb12564500212951e9e34f4d82edd04829a1fb7
    
  - Merge "simpleperf: link libraries for etm decoding."
  - Merge "Remove CtsThemeHostTestCases from general-tests suite"
  - Remove CtsThemeHostTestCases from general-tests suite
    
    The test is not used in TEST_MAPPING. Removing it from genera-tests
    suite allows:
    1. Reduce size of general-tests.zip
    2. Reduce sandbox setup time (the test contains a 120MB jar file that
    requires to be staged before sandbox process starts. This is unnecessary
    as the test is not part of Test Mapping suite.
    
    One shall add the suite back if the test will be part of Test Mapping.
    
    Bug: 73786521
    Test: none
    Change-Id: I7b8346d886a0c64e95b0a83a5f67d10d471514d6
    
  - Move default MimeMap implementation to frameworks.
    
    This CL topic moves the default MimeMap implementation to frameworks.
    Libcore starts with a minimal implementation sufficient to pass
    CtsLibcoreTestCases,  but frameworks can inject the real implementation.
    Before this CL topic, the data files and logic (MimeMapImpl) were part of
    core-*.jar on device; after this CL, they instead live in framework.jar.
    
    Tests from MimeMapTest that check behavior of that default
    implementation also move to a non-libcore CTS test.
    
    Planned work for follow-up CL:
     1. Make CTS more opinionated, with a plan to assert that all of
        the default mappings are present. How exactly the expectated
        mapping will be bundled in CTS is still TBD.
     2. Add a vendor.mime.types file (defaults to empty) where vendors
        can add additional mappings; I plan to make it such that mappings
        in that file are parsed last but never override any earlier
        mappings, as if each mime type / file extension was prefixed
        with '?'.
     3. Perhaps enforce that public APIs android.webkit.MimeTypeMap
        and java.net.URLConnection.getFileNameMap() behave consistently
        with MimeMap.getDefault().
    
    Test: atest CtsLibcoreTestCases
    Test: atest CtsMimeMapTestCases
    Bug: 136256059
    Change-Id: Ia199dd683c26753ccee820004e37d28ffb6446db
    
  - Fix up formatting of tests/libcore/luni/Android.bp
    
     - Replace tab with spaces
     - Reorder the *ts part of the list to be alphabetically ordered.
    
    Test: Treehugger
    Change-Id: Ia64d140e3463ae2072d18ec7b9af71ba8ab05c14
    
  - simpleperf: link libraries for etm decoding.
    
    Bug: 135204414
    Test: run CtsSimpleperfTestCases.
    Change-Id: Id9891d6db89f6f8bd98a79b3bd665fde5e628994
    
  - Fix StagefrightTests
    
    Update the process names to regex so that they match hidl processes.
    
    Bug: 113170203
    Test: run stagefright against an expected failure
    Change-Id: Icf03f341f55f97a43db5e8dcdf3da75c24e041ef
    Merged-In: Icf03f341f55f97a43db5e8dcdf3da75c24e041ef
    
  - MmsProvider TestCases
    
    Below listed all the testcases of MmsProvider class.
    
    Bug: 124791757
    Test: run atest CtsTelephonyProviderTestCases:MmsTest & atest CtsTelephonyProviderTestCases:MmsPartTest
    Change-Id: If1846ec0bd6e3ac6a0dcf6a599f9eee33b41bb50
    

* Update device/amlogic/yukawa from branch 'simpleperf-release'
  to 081ef6ccba4ad00f3d991957e2c4da9dbc559ff2
  - Snap for 5824001 from 5af3589d88ec07c2daf05c8163e8e3a21e79726b to simpleperf-release
    
    Change-Id: Iaa3a80069d5299be9e7085d16d8a9d6c925441e0
    
  - yukawa: Remove NoGms apps for Gms build
    
    Bug: 139832572
    Test: Manual
    
    Change-Id: I9950384401b52e97c6aac9bedecb9461c491af14
    Signed-off-by: Dmitry Shmidt <[email protected]>
    

* Update device/generic/car from branch 'simpleperf-release'
  to 464df04b1b53a28c05f38c3f5fd0702dcfc3d48f
  - Snap for 5824001 from e8756d036a606f4c2742ea77a356faa8463a1306 to simpleperf-release
    
    Change-Id: If5107ea55bcfbf16164f9ef0d7bf148fe494d80e
    
  - Update configstore entry to 1.1.
    
    This is installed by base_vendor.mk and is changing to [email protected].
    This 1.0 target no longer exists.
    
    Bug: 139274536
    Test: N/A
    Change-Id: Ib59a2c3e59a5ed833778b428f2f004dacf7036d2
    

* Update device/generic/goldfish from branch 'simpleperf-release'
  to c908b9879175b0a146be4565aaad61ca75245005
  - Merge "Snap for 5824001 from d62382d265e09ee55c85dab215113244fdd70abd to simpleperf-release" into simpleperf-release
  - Snap for 5824001 from d62382d265e09ee55c85dab215113244fdd70abd to simpleperf-release
    
    Change-Id: Ic4dde73e2206d3cb4f169c3ba910a726eaf85cef
    
  - Merge "Update VINTF manifest."
  - Update VINTF manifest.
    
    - broadcastradio 1.1 is installed, now in manifest
    - wifi 1.2 is installed, now in manifest
    - wifi supplicant 1.1 is installed, now in manifest
    - radio 1.1 is installed, now in manifest
    - soundtrigger 2.0 is installed, now in manifest
    
    This would have been failing VtsTrebleVendorVintfTest, but now these
    checks are being moved up to runtime.
    
    Bug: 139274536
    Test: m && emulator (and no more crashes/failed registrations)
    Change-Id: I90121ec19eb12dc2cb433a598449bcf6b5683f5d
    
  - Merge "goldfish: Remove invalid keywork in ueventd"
  - goldfish: Remove invalid keywork in ueventd
    
    * Fixes: ueventd: /vendor/ueventd.rc: 5: Invalid section keyword found
    
    Test: m, check dmesg
    Change-Id: Iceb81b2a951a8cee1fb32650c394399d555e5cf1
    

* Update device/generic/goldfish-opengl from branch 'simpleperf-release'
  to addde2aed3779327b696117732cdb66a51900bfa
  - Snap for 5824001 from de7eaa79a2fb418e856224c2c9b206f783addc5d to simpleperf-release
    
    Change-Id: I0d4d6acf6727a0d218a728ae490a301c43d8e1b0
    
  - fix some more compile warnings
    
    - unused variables
    - platform sdk ver not propagated to hwc2
    
    Change-Id: I40a7d2cf8be76ceaa38d8244779e4e58cfcf8c37
    
  - gl: gen code fixing compile warning (guest)
    
    Change-Id: Ie2e30b9756b812858a67772e6d384edfb34c69c2
    
  - android-emu: Add threading-related classes
    
    bug: 139194471
    
    Add functionality up to FunctorThread + MessageChannel, which is good
    for the driver to spawn extra worker threads used for things such as
    async waits for external fences/semaphores.
    
    Change-Id: I4d4a5d5cb97d7ca88ab7772b6ea1606fc4f64347
    

* Update device/google/cuttlefish from branch 'simpleperf-release'
  to 20048fb498422563bd679f50781fd0019a401f19
  - Snap for 5824001 from e222139d8d3721813ca150ba0c29f5915d57276e to simpleperf-release
    
    Change-Id: I52b632798186105a4234edb4fffcb90ec9133229
    
  - Merge "Revert "Delete unused mk files""
  - Revert "Delete unused mk files"
    
    This reverts commit ce088c2d697b1d37f062d3873747c292e5a6c4cb.
    
    Reason for revert: The change should have been submitted with 'DO NOT MERGE'
    
    Bug: 139830650
    Change-Id: Ia0a54b15f64b990cddf621b88b374c44523dfe3f
    
  - Delete other unused files
    
    Bug: 139763357
    Test: none
    Change-Id: Ib0fad42823038a5d4d0f6ce33a938ba01eb594c8
    
  - Delete gsi target
    
    Bug: 139763357
    Test: none
    Change-Id: Iaee840b1fc854394fbb9f7b2725cd281ca3d1092
    
  - Delete unused mk files
    
    Bug: 139763357
    Test: none
    Change-Id: I7418727375b531cafba0811b738f6034b7a99d09
    
  - Delete unused tablet directories
    
    Bug: 139763357
    Test: none
    Change-Id: I2fa36d1813af3c9af78e7e28728e9cf6bc25a0ff
    

* Update device/google/cuttlefish_common from branch 'simpleperf-release'
  to 730ce9521015ba2f2602e90504ba602b21a537d4
  - Snap for 5824001 from 0ced32c1e18fa2bf2589f879310ff08fba5d62bf to simpleperf-release
    
    Change-Id: I84b8ae1bca8f4ac6ea1b22213291e852c9fae601
    
  - Remove wifi_(host|guest)_mac_addr.
    
    This is not used with the new wifi implementation.
    
    Test: Build and run, TreeHugger
    Change-Id: I35d4dccbb857bc1ace6f118a3a3f564e26236021
    

* Update device/google/marlin from branch 'simpleperf-release'
  to 9c2d1e5e92921313386014a3f0283f264ceef1cb
  - Snap for 5824001 from b87ab81df39114463f966e06e00cfd06dd29d307 to simpleperf-release
    
    Change-Id: I787a104a0dd6b256a6b88b449dc0993ce4ec5ffe
    
  - Merge "Don't audit hwservice add -> find."
  - Don't audit hwservice add -> find.
    
    Since an additional check related to getting the transport of a service
    before registering it is more visible (this is moving a VTS test failure
    to boot time for more visibility).
    
    When adding a 'find' check on the 'add' path, this triggered some logs
    here. 'find' has always been given with 'add' for other services, but
    for a dontaudit, find has to be manually added.
    
    Bug: 139274536
    Fixes: 139822884
    
    Test: TH
    Change-Id: Ica4266dfaf17acc8c7bc8bd83054aa02811a4a37
    (cherry picked from commit 56078dad4484836059a00510522480acf242cc81)
    
  - mediacodec_service: this service DNE
    
    Bug: 80317992
    Test: TH
    Change-Id: I536f6139b95c70c71940a6e44f87ff84e53ca4ae
    

* Update device/google/wahoo from branch 'simpleperf-release'
  to 4d4ef8b97a09218a7c26bf42a4a805f783407805
  - Snap for 5824001 from cfe911b5faa70199a0c60fa557815dd70e82823d to simpleperf-release
    
    Change-Id: I84800f8dc174748c87d4ea618665fe6be91b4859
    
  - Merge "mediacodec_service: this service DNE"
  - mediacodec_service: this service DNE
    
    Bug: 80317992
    Test: automated only
    Change-Id: I031b87a17a9b03b0a32d0fac10717bf57ef95d24
    
  - Merge "Don't audit hwservice add -> find."
  - Don't audit hwservice add -> find.
    
    Since an additional check related to getting the transport of a service
    before registering it is more visible (this is moving a VTS test failure
    to boot time for more visibility).
    
    When adding a 'find' check on the 'add' path, this triggered some logs
    here. 'find' has always been given with 'add' for other services, but
    for a dontaudit, find has to be manually added.
    
    Bug: 139274536
    Test: TH
    Change-Id: Ica4266dfaf17acc8c7bc8bd83054aa02811a4a37
    

* Update device/linaro/hikey from branch 'simpleperf-release'
  to 5a34763669fb4b68e4fb4d3b1b6bde5c6fead64f
  - Snap for 5824001 from 60ad7594adae2166ef7e0234c870b52443504794 to simpleperf-release
    
    Change-Id: Ic467223d1ce80ca815ef00e964fe792699096da6
    
  - Update configstore entry to 1.1.
    
    This is installed by base_vendor.mk and is changing to [email protected].
    This 1.0 target no longer exists.
    
    Bug: 139274536
    Test: N/A
    Change-Id: I293ef28ad08362d078cc4b5ba5369d41e1ea6ff5
    

* Update device/linaro/poplar from branch 'simpleperf-release'
  to 7f477e411dba54620b27e28d14572601521dedd4
  - Snap for 5824001 from 74acd435d6075acfbc5aab92b8b7d511d9edbb7a to simpleperf-release
    
    Change-Id: I0e7c58b71fc06747046119df763c7e0b98a9101b
    
  - Update configstore entry to 1.1.
    
    This is installed by base_vendor.mk and is changing to [email protected].
    This 1.0 target no longer exists.
    
    Bug: 139274536
    Test: N/A
    Change-Id: I5eec3d33af60d43f64b81a318b6c2bccab5bddd5
    

* Update device/ti/beagle_x15 from branch 'simpleperf-release'
  to 5ffb31d6c2720a3c8e8486f747b554daff599840
  - Snap for 5824001 from d0fdc3231d6df776125997aaba945fdec38f3467 to simpleperf-release
    
    Change-Id: Ic413b4b6df40d3c4a81af8ddd8b19f362f6ab00d
    
  - Update configstore entry to 1.1.
    
    This is installed by base_vendor.mk and is changing to [email protected].
    This 1.0 target no longer exists.
    
    Bug: 139274536
    Test: N/A
    Change-Id: I35a7846d47aa56fd14261d014da03fedd69ad3e4
    

* Update external/Microsoft-GSL from branch 'simpleperf-release'
  to be41fa18df06c702cdaa173d1d5312f66ca0da7a
  - Snap for 5824001 from 97163d0b88931989c01370c75ed7d9cfe4a6c3ce to simpleperf-release
    
    Change-Id: Ie679c060e9cf84f4d3521ea7da5a5077ac661ff0
    
  - Upgrade Microsoft-GSL to b576cc6ce375cf42f6537d65a9ef29d67aa6b78e
    
    Test: None
    Change-Id: I0edbad888bfb8c4a6672d0cb2f070f6a2eb923ef
    
  - Merge pull request #769 from jack17529/patch-1
    
    Update usage of difference_type in span
  - Merge pull request #800 from eyalroz/master
    
    Fixes #798 : Dropping inclusion of `gsl/pointers` in `string_span`
  - Fix GNUC typo (#780)
    
    Resolves #779
  - Fixed check if std::byte is available (#764)
    
    The check for std::byte existance fails on gcc 8.2. According to https://en.cppreference.com/w/cpp/utility/feature_test it is necessary to `#include <cstddef>` before checking `__cpp_lib_byte`.
  - Fixes #798 : Dropped inclusion of `gsl/pointers` in `string_span`.
    
  - Add Visual Studio 2019 image for tests (#787)
    
    * Add Visual Studio 2019 image for tests
    
    Refer to https://github.com/appveyor/ci/issues/2907
    VS2019 is enabled per request.
    
    * Use CMake 3.14
    
    * Fix CMake output directory
    
    * trigger build
    
    * Trigger build
    
  - make TypeListIndexer constexpr (#733)
    
    
  - Update span
    
    About my Issue - https://github.com/Microsoft/GSL/issues/765

* Update external/arm-optimized-routines from branch 'simpleperf-release'
  to c5ee22cab532fe461b427ac1c483ea0ec8b17207
  - Snap for 5824001 from f68bf18eaa74500adf55d48a4ac0a8c3b8b12b69 to simpleperf-release
    
    Change-Id: Ic80a72fb5a78497afa34b2b48d0e35e01f70441f
    
  - Remove no-longer-used README.version.
    
    Test: builds
    Change-Id: I997f1f6f1c6c17a011ef12b65f06362dc2e7f830
    

* Update external/autotest from branch 'simpleperf-release'
  to 89947a6de586e355173ef3041b331f24fba84bb5
  - Snap for 5824001 from 3611c39ee9f4a4ad284e95502e16f0b873b8e336 to simpleperf-release
    
    Change-Id: I47df55159369e711d81408c049cda5cfc011825b
    
  - autotest: exclude firmware_Cr50DeferredECReset from CR50 qual suite
    am: b0a8d2e103
    
    Change-Id: Ic4b86e1588be16155d25132decd921b5f0e918bb
    
  - autotest: exclude firmware_Cr50DeferredECReset from CR50 qual suite
    
    This test is causing various kind of failures on almost all platforms.
    It should be pulled back for now.
    
    BUG=b:139537748
    BRANCH=None
    TEST=manually ran test_that --pretend suite:faft_cr50_pvt
    and checked it didn't run firmware_Cr50DeferredECReset
    
    Change-Id: Ifb760f3d1fbc70da5889f34b12736915e840cd7d
    Signed-off-by: Namyoon Woo <[email protected]>
    Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/1758927
    Reviewed-by: Mary Ruthven <[email protected]>
    Legacy-Commit-Queue: Commit Bot <[email protected]>
    
  - disable logging_UserCrash
    am: c989b632f2
    
    Change-Id: Ief41949e7cefa6e360426e2bce32240e09c7f127
    
  - telemetry_AFDOGenerate: Change the GS bucket of async AFDO generators.
    am: 2cdd9186c7
    
    Change-Id: I798798cdc23da4fb8f38e1580de829f6a0b9acf5
    
  - disable logging_UserCrash
    
    BUG=chromium:996748
    TEST=None
    
    Exempt-From-Owner-Approval: Chumping to Fix CQ
    Change-Id: Ib2f7730fc66af120703301b6bcf7a65c0ae49a0e
    Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/1766226
    Commit-Queue: Dhanya Ganesh <[email protected]>
    Commit-Queue: Jason Clinton <[email protected]>
    Tested-by: Dhanya Ganesh <[email protected]>
    Auto-Submit: Dhanya Ganesh <[email protected]>
    Reviewed-by: Jason Clinton <[email protected]>
    
  - telemetry_AFDOGenerate: Change the GS bucket of async AFDO generators.
    
    Use a temporary bucket (instead of production bucket) for the AFDO
    profiles generated by the async builders, because the samus profiles
    might not be good to use.
    
    BUG=chromium:947345
    TEST=Tryjob pass at https://ci.chromium.org/p/chromeos/builders/general/Try/b8905082370856331248
    
    Change-Id: I646d49f45ab697c52350479eb940eb09d202f76c
    Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/1751816
    Tested-by: Tiancong Wang <[email protected]>
    Reviewed-by: Manoj Gupta <[email protected]>
    Legacy-Commit-Queue: Commit Bot <[email protected]>
    Commit-Queue: ChromeOS CL Exonerator Bot <[email protected]>
    
  - make atest host mod --lock failure nonfatal
    am: 30426ea70f
    
    Change-Id: I210cafb0bb62a171d6b98280be890d0044a8e666
    
  - make atest host mod --lock failure nonfatal
    
    Bug: chromium:996409
    Change-Id: Ie8076e7da060c63fcc769822dcf2ab6ea1f3e58d
    Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/1763234
    Reviewed-by: Gregory Nisbet <[email protected]>
    Commit-Queue: Gregory Nisbet <[email protected]>
    Tested-by: Gregory Nisbet <[email protected]>
    Auto-Submit: Gregory Nisbet <[email protected]>
    Legacy-Commit-Queue: Commit Bot <[email protected]>
    
  - Disable logging_CrashSender
    am: f49726fedb
    
    Change-Id: I394737be46beab856a2b3f48d32355ab81dc283a
    
  - Disable logging_CrashSender
    
    BUG=chromium:996748
    TEST=None
    Exempt-From-Owner-Approval: Chumping to Fix CQ
    Change-Id: Ife1fb0ad3d8d993b20367528a0a65820517cd26a
    Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/1765628
    Tested-by: Dhanya Ganesh <[email protected]>
    Auto-Submit: Dhanya Ganesh <[email protected]>
    Reviewed-by: Jason Clinton <[email protected]>
    Commit-Queue: Jason Clinton <[email protected]>
    
  - firmware_ECCbiEeprom: ensure servo's i2c mux is off
    am: 19b77dd01c
    
    Change-Id: I9c5566ebc4bc463c5d2cd3ca081f464448f3a182
    
  - firmware_ECCbiEeprom: ensure servo's i2c mux is off
    
    The i2c lines from the servo are also tied to the i2c lines that control
    the CBI EEPROM in some designs. Ensure that the servo's i2c lines are
    disconnected from the DUT during this test.
    
    BRANCH=none
    BUG=b:139092495
    TEST=Ampton PVT passes FAFT
    
    Change-Id: Ia575ea92f7fc2008eb8c8a7e7ec3a30329797da1
    Signed-off-by: Jett Rink <[email protected]>
    Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/1762439
    Tested-by: Michael Cheng <[email protected]>
    Reviewed-by: Denis Brockus <[email protected]>
    Reviewed-by: Daisuke Nojiri <[email protected]>
    Legacy-Commit-Queue: Commit Bot <[email protected]>
    
  - [autotest] change more python shebangs to python2
    am: 0e2cb7a198
    
    Change-Id: I1912ee5269c71e48af972705a44e918d3c7d4243
    
  - Bluetooth: handle exception when there is no newblue config file
    am: 91681a37aa
    
    Change-Id: Iee8e5ba1987cf3d42f3dd6488ad35f4a0787556e
    
  - [autotest] change more python shebangs to python2
    
    Make sure all these scripts run as Python 2 since there is no support
    for Python 3 in this code base.  This allows us to change the default
    `python` to Python 3.  This catches patterns I missed previously.
    
    BUG=chromium:990593
    TEST=CQ passes
    
    Change-Id: I45e226d65d8a406e984e103a3687124c5d09c36b
    Reviewed-on: https://chromium-review.googlesource.com/1761350
    Tested-by: Mike Frysinger <[email protected]>
    Commit-Ready: Mike Frysinger <[email protected]>
    Legacy-Commit-Queue: Commit Bot <[email protected]>
    Reviewed-by: Vadim Bendebury <[email protected]>
    Reviewed-by: Allen Li <[email protected]>
    
  - Bluetooth: handle exception when there is no newblue config file
    
    Handle exception case when there is no newblue config file.
    
    BUG=chromium:995545
    TEST=manual test
    Tested with newblue config file removed.
    
    Change-Id: I4cf93196e7869e5319f283d3a5d2143c966aaee6
    Reviewed-on: https://chromium-review.googlesource.com/1761370
    Tested-by: Michael Sun <[email protected]>
    Commit-Ready: Michael Sun <[email protected]>
    Legacy-Commit-Queue: Commit Bot <[email protected]>
    Reviewed-by: Puthikorn Voravootivat <[email protected]>
    
  - faft: Rename firmware_UpdateModes test
    am: 1461a28598
    
    Change-Id: I78513dcc123745abffe9a059e97086ff713a849a
    
  - faft: Rename firmware_UpdateModes test
    
    The other firmware_Update* tests are tests of updating something, but
    this test covers modes of the updater, not updating the modes of
    something.  So, I'm renaming to firmware_UpdaterModes.
    
    BUG=chromium:967917
    TEST=Run firmware_UpdaterModes
    
    Change-Id: Ie03664393df0791b5c3be7a656915e10883089c8
    Reviewed-on: https://chromium-review.googlesource.com/1739595
    Tested-by: Dana Goyette <[email protected]>
    Commit-Ready: ChromeOS CL Exonerator Bot <[email protected]>
    Legacy-Commit-Queue: Commit Bot <[email protected]>
    Reviewed-by: Kevin Shelton <[email protected]>
    
  - platform_EncryptedStateful: remove factory mode from the test
    am: 7abea60dc7
    
    Change-Id: I2c3d3f388ea36ab843a70370e7463b6473b861af
    
  - platform_EncryptedStateful: remove factory mode from the test
    
    Factory mode was removed in CL:1636176, which caused the test
    platform_EncryptedStateful to fail. Removed factory mode from the test and
    replace it with a reclamation test.
    
    BUG=b:131123943
    TEST=run `test_that <dut_ip> platform_EncryptedStateful` on a local soraka
         before and after this change. It's failing before the change and passing
         now.
    
    Change-Id: Ie3932e0fa09ccbca05576fa61f9947be68adf481
    Reviewed-on: https://chromium-review.googlesource.com/1757652
    Tested-by: Wei-Cheng Xiao <[email protected]>
    Commit-Ready: Wei-Cheng Xiao <[email protected]>
    Legacy-Commit-Queue: Commit Bot <[email protected]>
    Reviewed-by: Sarthak Kukreti <[email protected]>
    

* Update external/conscrypt from branch 'simpleperf-release'
  to b342558fa65e0a8bd88789722f77e5fb6c0b3d26
  - Snap for 5824001 from 2634c1148db8c5135734e02bb6d5a190e760d60c to simpleperf-release
    
    Change-Id: Ieb16be20f54a06721e1567634c6f612be542178a
    
  - apex: Add boringssl_self_test binaries
    
    Currently these binaries call out to BORINGSSL_self_test but
    this can be removed once boringssl is setup to do this in a
    constructor.
    
    Test: m
    Test: adb shell /apex/com.android.conscrypt/bin/boringssl_self_test64
    Test: adb shell /apex/com.android.conscrypt/bin/boringssl_self_test32
    
    Change-Id: Ia7569f9596fa40cc60c5a791be34ae71fa7db325
    

* Update external/freetype from branch 'simpleperf-release'
  to 0b6caa8fc72be8fca8e8321ce4e17db6eeaa4ea0
  - Merge "Snap for 5824001 from ff98b650827bb18a696aec007e914b7e2473afc6 to simpleperf-release" into simpleperf-release
  - Snap for 5824001 from ff98b650827bb18a696aec007e914b7e2473afc6 to simpleperf-release
    
    Change-Id: I12db7d3aab0db9828ce640bf948382cd67920c22
    
  - Merge "Remove no-longer-used README.version."
  - Remove no-longer-used README.version.
    
    Test: builds
    Change-Id: I984204245d4d078367dbab8db53214b37e3ffb30
    

* Update external/googletest from branch 'simpleperf-release'
  to c4464882ff6a8401d271f5b99f5ff34eb5bf9f52
  - Snap for 5824001 from 65d4908152e286719ce699613d222ea0ff6c627d to simpleperf-release
    
    Change-Id: I2a31f7b1a2f8b53556be20c2e7256c3dd02818d8
    
  - Remove README.version
    
    Seems redundant given the new METADATA.
    
    Change-Id: Ic84ecb5b5e113a201c3eafdddcaa1ce20a2a8365
    

* Update external/icu from branch 'simpleperf-release'
  to 361fedf8075b1e8b949189aabc89016a04c23cda
  - Snap for 5824001 from 684fe8af2d33563a3ade72465992c38bd3c3357b to simpleperf-release
    
    Change-Id: I2d016a9b0e4b3c5ea13feac8d919f111cb42d09b
    
  - Set path property for filegroup modules
    
    The path property specifies the base directory for Java files. This can
    be used by the build system to filter (or filter-out) Java files by
    their package names.
    
    Bug: 135922046
    Test: m
    Change-Id: I390373a5f40216a7b49f121997960e028d1b8823
    

* Update external/libavc from branch 'simpleperf-release'
  to 1b40ab8f3c329ccd2062d3438bf21b1fa0fbe3c5
  - Snap for 5824001 from dcdaa5c23202fb9f36296a4d4824855a47ffd78e to simpleperf-release
    
    Change-Id: I37abecabe2f0e81b2a1a83f7f6a4ae222de6eda1
    
  - Merge "decoder: Add host support"
  - Add README.md for fuzzer
    
    Instructions to build fuzzer target are now in README.md
    
    Bug: 139761244
    Test: Review
    Change-Id: Ie0eebac0508e45fc952b1e9cf2bb9b2a3df6b475
    
  - decoder: Add host support
    
    Test: Build libavcdec on host
    Bug: 139379050
    Change-Id: If81b01e3058e1ae42c8d266571a07deb39fbd603
    

* Update external/libcxx from branch 'simpleperf-release'
  to f4597b2328d32f7f83b6cf9d129d764e10dd00df
  - Snap for 5824001 from 45f1d9904470661e73a52a005dfd41f559f358ac to simpleperf-release
    
    Change-Id: I6ac59d7f857b32e344d88c91c2c3c37c224972af
    
  - Fix tests for soong change.
    
    Test: ./run_tests.py
    Bug: None
    Change-Id: I235225f449e3e3d0bb17c5d0c28d2acd8acfa6c9
    

* Update external/libcxxabi from branch 'simpleperf-release'
  to 1ce22cf361f5becea66adf2ef5491bfbb8de1790
  - Snap for 5824001 from 8144d214aed6d7bfc87b773782a9792f6609810d to simpleperf-release
    
    Change-Id: I8db6b2222ea80208e6556079159da54619356ed4
    
  - Move the demangler into its own library.
    
    The demangler is quite large, and not commonly needed. If we remove
    the use of the demangler from the default terminate handler and remove
    the demangler from libc++abi.a, it won't cause dirty pages for every
    libc++.so user on the system.
    
    For those that do actually need the demangler, it has been moved into
    a separate libc++demangle.a that must be linked explicitly. Some day
    the build system could make the explicit link unnecessary, but not
    currently. There are only a handful of users, so it's not a large
    burden.
    
    Test: make checkbuild
    Test: external/libcxx/run_tests.py --bitness 32
    Test: external/libcxx/run_tests.py --bitness 64
    Test: adb shell librank | grep libc++
    Bug: http://b/138245375
    Change-Id: I344d4c6957b9b7180a9d825cb5119fa5b2ce61b6
    

* Update external/libhevc from branch 'simpleperf-release'
  to 3bf83b93fa7b8775923198c6c2af524ef64a2a9f
  - Snap for 5824001 from b534035e2652e6d21e134f5f7198affe2c89736c to simpleperf-release
    
    Change-Id: I80168791b39276a7a256dbbaba8c72bc96e217af
    
  - Merge "Add host support to build hevcdec binary"
  - Add host support to build hevcdec binary
    
    Test: Build libhevc on host
    Bug: 139379050
    Change-Id: Ia125abda94a449c91a4611a141c0019b621b8da6
    

* Update external/libmpeg2 from branch 'simpleperf-release'
  to 37c8019743dc5ff657ab63123b1db858e554b1bc
  - Snap for 5824001 from 313d5efa2d866f01aaf25b015f31480ce095e7f5 to simpleperf-release
    
    Change-Id: I459c78ab29d576aafeaa9d9d82c9e5aaa973278a
    
  - Merge "Add host support for libmpeg2"
  - Merge "Added mpeg2_dec_fuzzer"
  - Added mpeg2_dec_fuzzer
    
    Test: ./mpeg2_dec_fuzzer
    Bug: 135628965
    Change-Id: I7ed154dabb575c1af000a3615a678b1e4506b1a5
    
  - Added CMakeLists.txt for x86/x64 build
    
    Bug: 135628965
    Test: cmake && make
    Change-Id: Ifb88577b9fe7104d75b84642e516915ac78db7a7
    
  - Add host support for libmpeg2
    
    Test: Build libmpeg2 on host
    Bug: 139379050
    Change-Id: Icf1b286b3673a6fa575fa07e6924a81e9aef7bc0
    

* Update external/libphonenumber from branch 'simpleperf-release'
  to d9c6bdaa14d05631d45ef65a74e102a0799c4536
  - Merge "Snap for 5824001 from f626fde32cbe0092d9ad73d7ed797e097b01d9b2 to simpleperf-release" into simpleperf-release
  - Snap for 5824001 from f626fde32cbe0092d9ad73d7ed797e097b01d9b2 to simpleperf-release
    
    Change-Id: I35b8e1ecd7ac1a54cca5acc82d6ab2727b688cdc
    
  - Merge "Update libphonenumber to v8.10.17"
  - Update libphonenumber to v8.10.17
    
    Bug: 138910881
    Test: run cts -m CtsTelephonyTestCases -t
    android.telephony.cts.PhoneNumberUtilsTest
    Test: vogar --timeout 0 \ --classpath
    out/target/common/obj/JAVA_LIBRARIES/libphonenumber-test_intermediates/classes.jar
    \ com.google.i18n.phonenumbers
    
    Change-Id: I6678f1a81e5ce363b97d840e34baffce6a267f59
    Signed-off-by: Sarah Chin <[email protected]>
    

* Update external/libutf from branch 'simpleperf-release'
  to 70c4d402c49427615ab9149cbfcc39d158aab74c
  - Snap for 5824001 from 8829f320425d2a83967f6ce4e5b9322d2c57d34e to simpleperf-release
    
    Change-Id: I031195c890bff9971f67ad028df2b13bf4aded49
    
  - Remove no-longer-used README.version.
    
    Test: builds
    Change-Id: I856eb865b3805e46f5c722bc105f0aa1fe25442f
    

* Update external/libxaac from branch 'simpleperf-release'
  to 73d7de8180a708cffa8f7a3baa8631037c5065d7
  - Snap for 5824001 from 0f1f7833874010dee336602843390ab5ae6cbd9b to simpleperf-release
    
    Change-Id: Id0402f16ed5b812fa889c0c3ac2fa79532366bc9
    
  - Add host support for libxaacdec
    
    Test: Build libxaacdec on host
    Bug: 139379050
    Change-Id: I7b71c4c00839597c66d97077870d55beb55f34a1
    

* Update external/libxkbcommon from branch 'simpleperf-release'
  to ccd27eab3a0e694d968069ee2c7d918e7a9c1ece
  - Snap for 5824001 from 7ac52a5e76d131932c79836db3896647f1c2fa75 to simpleperf-release
    
    Change-Id: I6ebe5268a12f30524fcf879f20f51d6937a1d7ca
    
  - Remove no-longer-used README.version.
    
    Test: builds
    Change-Id: I1e12880500e87ae23502cab5e5c342919ff8e97b
    

* Update external/perfetto from branch 'simpleperf-release'
  to e238af7d89757887df330aaacdc34d0226fa8ee9
  - Snap for 5824001 from a52177c11e7288c553556c898e46d9a1d9f74527 to simpleperf-release
    
    Change-Id: Id06ea295ebe768841019940a0b17185fb46a2116
    
  - Merge "Client API: allow to configure SMB size and page size"
  - Merge "Fix chromium roll (INSTANTIATE_TEST_CASE_P/SUITE)"
  - Merge "Temporarily disable ConcurrentProfile test."
  - Fix chromium roll (INSTANTIATE_TEST_CASE_P/SUITE)
    
    Build failure: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8904411179670535584/+/steps/compile__with_patch_/0/stdout
    
    Test: builds and passes CI
    Change-Id: Id17b92df11ebdc7e4dc9dabe3261b13025978e4d
  - Client API: allow to configure SMB size and page size
    
    Test: manual. Covering this in the api_integrationtest.cc
          would require to tear-down all the singletons. Too
          overkill and unmaintainable for testing the plumbing
          of two integers.
    Bug: 139860079
    Change-Id: I19ba8be767fb4303a610b41fe2472efdda4cee73
  - Fix perfetto's extension listener registration
    
    The listener for the connection was set only in the onInstalled
    callback. Now it should always work.
    
    Bug: 139788095
    Change-Id: I02150ed67bb56849a8204feb604a5f27d1ab0579
  - Merge "Fix signed-unsigned conversions"
  - Merge "Add support for Dvorak keyboard layout"
  - Fix signed-unsigned conversions
    
    aosp/1009188 ended up hitting the recently introduced
    signed-unsigned warnings and breaking the CI as it landed.
    
    Test: CI builds
    Change-Id: I58c663fd6fd00cbe860446156489eee6982d083e
  - Merge "client api: Introduce a bare-bones TrackEvent library"
  - Merge "Speculative fix for Windows build failure"
  - Merge "Removing useless permissions to the extension"
  - Speculative fix for Windows build failure
    
    Failure: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8904477524826020480/+/steps/compile/0/stdout
    Introduced by: aosp/1105365
    
    Change-Id: I87aff00649c1a83eef6f664565040d9f7ce2afe1
    
  - Merge "Separate out the parts of HeapProfiling that CPUProfiling will reuse into StackProfiling"
  - Merge "trace_processor: add Table and Column classes"
  - trace_processor: add Table and Column classes
    
    This forms the foundation for all the other Tables in trace processor.
    
    Bug: 1104618
    Change-Id: I6dadeacc8e78edd7e16bbd191b5ee23168eb2feb
  - Merge "[GPU TRACE] Add UI control to record GPU sched trace events"
  - Temporarily disable ConcurrentProfile test.
    
    This is broken on hwasan, disabling while investigating.
    
    Bug: 138812852
    Change-Id: I7ba3e0c4efe272ddfed1682cc98030a394affa70
  - trace_processor: add SparseVector implementation and tests
    
    This class will be used as the backing data structure for essentially all
    columns.
    
    Bug: 135177627
    Change-Id: I55f4a15a362096d78bb0378aa7ecc8097a0c535f
  - trace_processor: add RowMap implementation and tests
    
    This will be used in the remainder of the trace processor refactor
    to perform efficient filtering.
    
    Bug: 135177627
    Change-Id: I222dcf23745d487747e31f5a2e2c95c02ffe0ddb
  - trace_processor: add bitvector implementation
    
    The trace processor refactor will make heavy use of this class for
    sort, filter and SparseVector logic.
    
    Bug: 135177627
    Change-Id: Ib687be1d319377bc2db6bfe19762834bd24b4d15
  - Separate out the parts of HeapProfiling that CPUProfiling will reuse into StackProfiling
    
    This splits the HeapProfilingTracker part of the proto parsing into
    two: HeapProfilingTracker and StackProfilingTracker, with the latter
    keeping track of frames/mappings/callsites.
    
    Also a mechanical rename of the HP tables (Heap* -> Stack*).
    
    Change-Id: I5ae635b320d3b119f292d84298a6508de0c4adb6
  - [GPU TRACE] Add UI control to record GPU sched trace events
    
    Bug: 139323730
    Test: Manual test with perfetto ui
    Change-Id: I0df7c1837d6bcf4af47d054318ef6f3ce0062f69
    
  - Merge "[GPU TRACE] Add GPU scheduling trace events"
  - Merge "Remove use of -isystem for googletest"
  - Remove use of -isystem for googletest
    
    Use standard include_dirs and a proxy header to manually suppress
    warning. This solves the problem of sign conversion warning that
    fire only when rolling into chrome.
    Follow-up CLs will try to remove -isystem also to other
    buildtools. Limiting the scope of this for now.
    
    Change-Id: I8bc7924a95c7dd73cad54f447c122bd339e4e2a4
    Bug: 129130827
  - Add support for Dvorak keyboard layout
    
    Bug: 139553518
    Change-Id: I937a1661ab4a835515e20c665609c6fcedf6a16f
  - Removing useless permissions to the extension
    
    Bug: 139788710
    Change-Id: I8d1e5cba4dfaba512e4d67d85c12933534737ce7
  - perfetto-ui: Fix to split up FrontendLocalState
    
    The previous CL had missed the step that updates
    the local variables when the visible time has
    changed in the global state.
    
    See previous CL here: aosp/1101916
    
    Change-Id: Icd39f1c7b9e4d13ed9e9297304495c80adc3f988
  - Merge "Improve Perfetto recording page"
  - Improve Perfetto recording page
    
    - The recording buttons are now nice.
    - Has been added a dialog in case of a chrome target with a link to
      the extension,
    - There is a bottom code-snippet box with the log of the recording.
      (not used in this CL, so there are no UI canges due to this here)
    - The logic to display each button has been improved
    
    Bug: 139716112
    Change-Id: I0e7a45dc8a709621630ee6b7212f7526c5af9578
  - Merge "Add adb controller and adb interfaces."
  - Roll clang + fix run_android_test
    
    Clang:
      -the sub-revision was mismatching chromium's (1 vs 8)
    tools/run_android_test:
     - adb push was unnecessarily noisy, spamming logs.
     - the TEST_RET_CODE boilerplate was unnecessary,
       adb shell propagates the exit code properly.
       It check_output() was causing the output to be
       retained until the end with no reason.
    
    Change-Id: I39cba05fb5aa2db5cf4afd2c52ee5daade6dce13
    Test: ci.perfetto.dev is happy
    
  - client api: Introduce a bare-bones TrackEvent library
    
    This patch adds a basic TrackEvent library to serve as a higher level
    entrypoint into Perfetto for apps that wish to record various types of
    events on a timeline. For now, the library only supports explicit
    Begin/End slice events with static categories and names. Note that
    enabling trace points based on their categories isn't supported yet.
    
    Bug: 132678367
    Change-Id: If72eb0c0cba565303b0a778933931609043c5004
  - Merge "CI: fix job failures due to autoscaler and artifact uploader"
  - CI: fix job failures due to autoscaler and artifact uploader
    
    - Effectively disables the autoscaler and keeps 2 instances
      always on. Solving this problem properly is harder and not
      a priority for now.
    - Makes the artifact uploader more robust by:
      - Restarting the script if it crashes.
      - Pre-caching the list of files before uploading it
      - Retrying in case of HTTP upload failures
    - In case of cancellation skip voting and post an explanation
      message.
    
    Bug: 139105385
    Change-Id: Ia77957a30434eae77a799309c4a7c527e9c39201
  - Update perfetto_config.proto to have more necessary protos.
    
    We can't import protos with LITE_RUNTIME into protos without LITE_RUNTIME, so
    we currently rely on perfetto_config.proto. In order to parse query-raw output,
    we need several protos from common, however, importing common as a whole will
    result in duplicate registry because perfetto_config.proto also contains some
    protos from common. Thus, we add more necessary protos into
    perfetto_config.proto to facilitate the need of parsing query-raw output from
    perfetto.
    
    BUG: N/A
    Test: N/A
    Change-Id: I4b3913dd1dc69b063d8b0306b65c0532c746026b
    
  - Add adb controller and adb interfaces.
    
    In order to support start recording a trace from android devices
    directly from the UI, a new adb_record_controller has been added, with a
    custom implementation of the consumer_port. Instead of the real ADB
    implementation in typescript, an interface and mock implementation have
    been used. This will be replaced with the real ADB as soon as it has
    been tested enough.
    
    
    Bug: 139536756
    Change-Id: I1edb7a55a9a59278143de51e98ffe8ea52b35e07
  - [GPU TRACE] Add GPU scheduling trace events
    
    This CL adds new gpu scheduling trace events and whitelists the new
    events.
    
    Bug: 139323730
    Test: manual
    Change-Id: I6624b7fb5991cbb73ee1374d32647741a7d2700c
    

* Update external/python/google-api-python-client from branch 'simpleperf-release'
  to 71ef10a8eedbbf5198bbf2f879b1a1bc1130cfb7
  - Snap for 5824001 from ae3aef9b3229dddaee9c8c912d062d7767c1a646 to simpleperf-release
    
    Change-Id: Ib9afb2380315b79c501405b829e3c73629e8c448
    
  - Upgrade python/google-api-python-client to v1.7.11
    
    Exempt-From-Owner-Approval: upgrade library
    Test: None
    Change-Id: Icfabfda6d625a3d6251ce2091ddc636b85e4dfb0
    
  - Release 1.7.11 (#737)
    
    
  - Pass library and Python version in x-goog-api-client (#734)
    
    
    
  - Fix typo in filename used in 'docs/auth.md'. (#736)
    
    

* Update external/sl4a from branch 'simpleperf-release'
  to c47e5aee39f585c7242c501e1b58e39ea6abbdc1
  - Snap for 5824001 from 27614c291b925f44611616a4cc3e368354dd1308 to simpleperf-release
    
    Change-Id: I58abc62dc8addd98c37fa9fd80d0751c8ea3c005
    
  - Remove IN_CALL_SERVICE_UI from InCallService
    
    In order for Telecom to bind to InCallService of sl4a
    
    Test: None
    Bug: 138587254
    Change-Id: I06fe513bd18575352bb0381b6d73fc71eb802c81
    

* Update external/tinyxml2 from branch 'simpleperf-release'
  to 1ff1d11f7683dffe0fcee0fb8f890dcd32659781
  - Merge "Snap for 5824001 from 44291488cdd3b83fa698e33dfe816f925398cd18 to simpleperf-release" into simpleperf-release
  - Snap for 5824001 from 44291488cdd3b83fa698e33dfe816f925398cd18 to simpleperf-release
    
    Change-Id: Ia02aff4a05f507a7c8ec2b9d13d6aab79b7b75a1
    
  - Merge "Remove no-longer-used README.version."
  - Remove no-longer-used README.version.
    
    Test: builds
    Change-Id: Ie89351c4436a3ae2ff99692190a12d4a3327abf1
    

* Update external/toybox from branch 'simpleperf-release'
  to 0135330bceb2810fe2333504e0fe7cc3b6cdf2cd
  - Snap for 5824001 from fab2596c75f0a9f761d35e9f063972cf5cfa39ee to simpleperf-release
    
    Change-Id: I4faaad2638a3b8e7929475771687e11fd7476024
    
  - Android: add env/setsid/sleep back to the host config.
    
    Also admit that we have libcrypto. We were still linking against it, but
    if you don't tell toybox you _have_ libcrypto it will still build
    commands that need libcrypto, they'll just produce the wrong output :-/
    
    I'll fix that upstream later.
    
    Bug: http://b/139450866
    Test: builds
    Change-Id: I94351c717f1c2f7e8f475e4142a84ec47f1ce21f
    
  - regenerate.sh: only keep the generated files we actually need.
    
    Also tidy up the script to reduce duplication.
    
    Bug: http://b/139450866
    Test: ./regenerate.sh && mm -j32
    Change-Id: If02d8d7939ab7a8a3b289e57e081dca1bac040a4
    
  - Support building for macOS too.
    
    Bug: http://b/139450866
    Test: builds
    Change-Id: If9dbac77974e70007d62215668c4aff1daf79bdd
    

* Update frameworks/av from branch 'simpleperf-release'
  to 4818e08347703105f83c8030510a39ffed0d867d
  - Merge "Snap for 5824001 from b7a4a3c49214617fd928de1e11c7ff49e4a68815 to simpleperf-release" into simpleperf-release
  - Snap for 5824001 from b7a4a3c49214617fd928de1e11c7ff49e4a68815 to simpleperf-release
    
    Change-Id: I9e839261c4f9aa04fd0b7b7e641a516df8344dd9
    
  - Merge "Fix OffloadThread VolumeShaper issue"
  - Fix OffloadThread VolumeShaper issue
    
    Bug: 134042971
    
    Test: NTS case AUDIO-026-DDP51-TC3-NonTunnel / Tunnel verify volume starts at 0 when fading in
    
    Change-Id: I8ee4444e3ceb2d8a0ceb979fada10c644b5db35c
    
  - Merge "Added trace event to screenrecord"
  - Added trace event to screenrecord
    
    Bug: 135278534
    Test: Run Perfetto with "screen recording" enabled and execute
    a query for the "first_frame" slice
    Exempt-From-Owner-Approval: cherry-pick
    
    (cherry-picked from commit c840c0bfee6aa9be4e05e957e8d1ee8d9e330f75)
    Merged-In: I20abf7300e8c46b6e6dc52096db699e95c93297d
    Change-Id: I20abf7300e8c46b6e6dc52096db699e95c93297d
    

* Update frameworks/base from branch 'simpleperf-release'
  to 44b119efe92d0dfa1a90a9b4dc7b8c4ea5a6390c
  - Merge "Snap for 5824001 from 9e4df4985a5bc6ffd8b30796e5c04d2013d26462 to simpleperf-release" into simpleperf-release
  - Snap for 5824001 from 9e4df4985a5bc6ffd8b30796e5c04d2013d26462 to simpleperf-release
    
    Change-Id: Id4fce6744908737ad8c8488d63a448fe23c9bd58
    
  - Merge "Fix AVR compatibility."
  - Merge "DO NOT MERGE Crash app on foreground service notification error."
  - DO NOT MERGE Crash app on foreground service notification error.
    
    Resolved issue 118612296.
    
    On any notification error, the NMS silently cancels the notification,
    including foreground service notifications. Thus, an app could pass in a
    garbage notification deliberately and start a foreground service silently.
    
    This patch resolved this issue by judging the notification's flag, and if
    it is a foreground notification, still crash the app as previous platforms,
    and if it is a normal notification, don't crash the app.
    
    Background: In 3ad4cdd1, which was merged into Android 9 release, the crash
    behaviour is removed. But it is an important rule that foreground services
    guaranteed to show an ongoing notification.
    
    Test: Run the sample apk provided in the issue, it's main thread received
     a RemoteServiceException: Bad notification posted from package...
    as intended behaviour.
    
    Change-Id: I36ea0137ca6978ff401f64dccacb6f2edcadd7db
    Merged-In: I36ea0137ca6978ff401f64dccacb6f2edcadd7db
    Signed-off-by: Da Xing <[email protected]>
    
  - Fix AVR compatibility.
    
    Not to start ARC action if ARC has been already established
    It’s a device compatibility issue happened with Sony amplifier str-dn860.
    Occasionally ARC won’t be able to be established after connect the amplifier to TV through HDMI ARC.
    
    Bug: 133329521
    
    Change-Id: I857e2457cb682e810a940b0698d4bb635bebd1de
    
  - Merge changes from topic "null_callback"
    
    * changes:
      Fixed null callback issue
      Added debug messages and watchdog
    
  - Fixed null callback issue
    
    Fixed the vendor data/network service non-responsive
    issue. The callback binder passed from frameworks
    might be GC'd so that vendor data/network service skipped
    calling the callback. This eventually caused data
    connection state machine messed up.
    
    Fixed by turning the weak refernce to the callback into
    a strong reference. This ensure the binder alive when
    vendor service needs to invoke the callback.
    
    Test: Telephony sanity tests
    Bug: 139076980
    Merged-In: Ica0b7b810ffd5416ffd1b2b61f7ebc4af0dcb8ce
    Change-Id: Ica0b7b810ffd5416ffd1b2b61f7ebc4af0dcb8ce
    (cherry picked from commit 09ef1cb126ee59dcb4eacfc3a8afefcb0f991945)
    
  - Added debug messages and watchdog
    
    Added debug messages and watchdog to catch
    unresponsive data service issue.
    
    Bug: 139076980
    Test: Manual
    Merged-In: I52dd126fddc1b1e8b18d5388a92aabaa3e2e48d5
    Change-Id: I52dd126fddc1b1e8b18d5388a92aabaa3e2e48d5
    (cherry picked from commit 36e2bfbaad3e1edcbb3ad0bf2be1e94643c38b07)
    
  - Merge "Add geo targeting implementation"
  - Merge "Added Part & Addr Constants."
  - Add geo targeting implementation
    
    This CL adds support for geo targeting, including determining whether a
    point is inside a simple polygon and circle.
    
    For the judgment of the point in the polygon, the algorithm implemented
    here simply considers the spherical polygon as a 2d plane polygon, which
    may be not precisely. However, according to the test of real geographical
    coordinates data i.e state/city/stree boundary data, this error is less than
    10 meters that within 160 meters requires by the spec.
    
    Bug: 123096618
    Test: atest GeoUtils
    Change-Id: I51e1fad3b48c1a58fa0510f97d9f5f9335779c30
    (cherry picked from commit 7fbc74b66b58dd57deedb7336c5c1e2f0f9e2064)
    
  - Merge "Rename android.compat.IPlatformCompat"
  - Merge "Tweak RuntimeInit docs around MimeMap registration."
  - Merge "avoid generating reserved local MACs"
  - Merge "Move default MimeMap implementation to frameworks."
  - Rename android.compat.IPlatformCompat
    
    To com.android.internal.compat.IPlatformCompat. This solves a java9
    issue because libcore exported api has the same package android.compat.
    
    Test: EXPERIMENTAL_JAVA_LANGUAGE_LEVEL_9=true make framework
    Change-Id: I0918344f670669cecb04f1e9e54dbcb471b587d5
    
  - Tweak RuntimeInit docs around MimeMap registration.
    
    Bug: 136256059
    Test: Treehugger
    
    Change-Id: I3f82a1684f47d96630badef4c13b3f507f30eaa5
    
  - Merge "Add entry to OWNERS."
  - Add entry to OWNERS.
    
    Test: N/A
    Change-Id: I1019015a81523e679a4a7529eb3e444283d0ba87
    
  - Move default MimeMap implementation to frameworks.
    
    This CL topic moves the default MimeMap implementation to frameworks.
    Libcore starts with a minimal implementation sufficient to pass
    CtsLibcoreTestCases,  but frameworks can inject the real implementation.
    Before this CL topic, the data files and logic (MimeMapImpl) were part of
    core-*.jar on device; after this CL, they instead live in framework.jar.
    
    Tests from MimeMapTest that check behavior of that default
    implementation also move to a non-libcore CTS test.
    
    Specifically, the logic and android.mime.types now live in
    frameworks/base/mime. The default implementation is injected
    into libcore from RuntimeInit. I chose to use a separate directory
    (frameworks/base/mime/) and build java_library target ("mimemap")
    in order to keep this as separate as possible from the rest of
    frameworks code, to make it as easy as possible to factor this
    out into a separate APEX module if we ever choose to do so.
    
    Planned work for follow-up CL:
     1. Make CTS more opinionated, with a plan to assert that all of
        the default mappings are present. How exactly the expectated
        mapping will be bundled in CTS is still TBD.
     2. Add a vendor.mime.types file (defaults to empty) where vendors
        can add additional mappings; I plan to make it such that mappings
        in that file are parsed last but never override any earlier
        mappings, as if each mime type / file extension was prefixed
        with '?'.
     3. Perhaps enforce that public APIs android.webkit.MimeTypeMap
        and java.net.URLConnection.getFileNameMap() behave consistently
        with MimeMap.getDefault().
    
    Test: atest CtsLibcoreTestCases
    Test: atest CtsMimeMapTestCases
    Bug: 136256059
    Change-Id: Ib955699694d24a25c33ef2445443afb7c35ed9e7
    
  - Merge "Add a platform-compat-config to the framework services."
  - Merge "Modify start/stop condition for mScreenDozeTimer."
  - Merge "TvInputManagerService patch"
  - TvInputManagerService patch
    
    Fix potential null pointer access at TvInputManagerService.java
    
    Bug: 136411969
    
  - Add a platform-compat-config to the framework services.
    
    Bug: 138222363
    Test: m. the config builds and contains annotated changes.
    Change-Id: I35ab9d028bbf23aca38494b66592779fdb4ef01e
    
  - avoid generating reserved local MACs
    
    Avoid generating WifiInfo.DEFAULT_MAC_ADDRESS as a randomized MAC
    address since it's being used for another purpose.
    
    Bug: 137796328
    Test: atest MacAddressTest
    Change-Id: Ia7beef0d0af5d7b39845e662cd343d81aef97702
    
  - Modify start/stop condition for mScreenDozeTimer.
    
    Both Display.STATE_DOZE and Display.STATE_DOZE_SUSPEND returns true in
    func isScreenDoze(int state),so if state change from STATE_DOZE to
    STATE_DOZE_SUSPEND or the other way round, mScreenDozeTimer.startRunningLocked
    may execute many times, then StopwatchTimer.mNesting++ executes
    many times, mScreenDozeTimer.stopRunningLocked runs less than
     mScreenDozeTimer.startRunningLocked. The bad result is even we
    close ambient.display or stopRunningLocked, the return value from
    StopwatchTimer.computeRunTimeLocked() always rises, then Estimated power
    for ambient.display in batterystats always rises, it's obviously wrong.
    After modifying, startRunningLocked and stopRunningLocked could be
    one-to-one correspondence, and the return value from
    StopwatchTimer.computeRunTimeLocked() is right.
    
    Problem background: When we turn on AOD(Alway On Display), the display state
    may change from STATE_DOZE to STATE_DOZE_SUSPEND or the other way round, then
    we find that in BatteryStatsHelper.addAmbientDisplayUsage(), ambientDisplayMs
    always rises even after we turn off AOD. ambientDisplayMs equals
    mScreenDozeTimer.getTotalLocked(elapsedRealtimeUs, which). At last, we find
    that because of the mismatching startRunningLocked and stopRunningLocked,
    mNesting is greater tha…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
next vs2019 image update
Development

No branches or pull requests