[READY] Instruct installing Visual Studio Build Tools 2017 #3378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visual Studio Build Tools is sufficient to build YCM. Version 2019 is not yet supported.
Codecov Report
@@ Coverage Diff @@
## master #3378 +/- ##
=======================================
Coverage 94.52% 94.52%
=======================================
Files 20 20
Lines 2063 2063
=======================================
Hits 1950 1950
Misses 113 113 |
bstaletic
approved these changes
Apr 24, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status: 1 of 2 LGTMs obtained
puremourning
approved these changes
Apr 24, 2019
complete! 2 of 2 LGTMs obtained
|
@zzbot r+ |
|
📌 Commit 1efcfe4 has been approved by |
zzbot
added a commit
that referenced
this pull request
Apr 24, 2019
[READY] Instruct installing Visual Studio Build Tools 2017 As suggested by @bstaletic in #3376 (comment), Visual Studio Build Tools is sufficient to build YCM. Users are told to download the 2017 version since 2019 is not yet supported (require a change to the `build.py` script and [waiting for AppVeyor to release the image](appveyor/ci#2907)). Closes #3376. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/3378) <!-- Reviewable:end -->
|
💔 Test failed - status-travis |
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @bstaletic in #3376 (comment), Visual Studio Build Tools is sufficient to build YCM. Users are told to download the 2017 version since 2019 is not yet supported (require a change to the
build.pyscript and waiting for AppVeyor to release the image).Closes #3376.
This change is