Resolve action helper/modifier deprecations #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This copies over the ember-data-table .js code so we no longer need the addon itself. We were already overriding all the templates. This will make things easier to maintain and improve in the future. Linting errors are silenced with inline ignore comments. They will be fixed once we convert the code to .gts.
It seems we were still depending on the one from the ember-data-table addon.
It seems we accidentally prefixed a block variable with `this` when resolving some deprecation warnings.
This copies over the data table tests that aren't empty and does the bare minimum to make them pass with our custom templates.
Windvis
changed the title
Windvis
force-pushed
the
inline-ember-data-tables
branch
from
afd11a4 to
94d6693
Compare
Windvis
added
the
enhancement
Windvis
changed the title
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This inlines the ember-data-table components and resolves the action helper/modifier deprecations in their code.
Inlining the components makes our custom overrides easier to maintain since we're extending base classes. We can include the addon again once a new version is released that allows us to wrap them instead of having to extend like we're doing now.
I've split off the inlining / deprecation solving work from the type work in #498 since fixing the deprecations unblock Ember v6 support.
Includes the relevant changes from this PR: mu-semtech/ember-data-table#36
Closes #511