Add types for the data-table components #498
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windvis
commented
Jul 11, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Closed
This copies over the ember-data-table .js code so we no longer need the addon itself. We were already overriding all the templates. This will make things easier to maintain and improve in the future. Linting errors are silenced with inline ignore comments. They will be fixed once we convert the code to .gts.
Used by the addon components, but ember-data-table was bringing it in. Can be removed once we refactor the code.
It seems we were still depending on the one from the ember-data-table addon.
It seems we accidentally prefixed a block variable with `this` when resolving some deprecation warnings.
This copies over the data table tests that aren't empty and does the bare minimum to make them pass with our custom templates.
Windvis
force-pushed
the
types/au-data-table
branch
from
b21b14e to
2268219
Compare
Windvis
added
internal
Windvis
changed the title
|
Closing since it's essentially the same as #525. I'll reopen it once I start on the actual type work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This copies over the ember-data-table .js code so we no longer need the addon itself. We were already overriding all the templates. This will make things easier to maintain and improve in the future.
Linting errors are silenced with inline ignore comments. They will be fixed once we convert the code to .gts.
This is a good base to start the .gts conversion from.
TODO:
Out of scope:
Convert the components to .gtsdeprecate things that we consider private and don't want apps to use directly