AuTable improvements #528
Merged
AuTable improvements #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously ignored these specific errors since I assumed it would make maintenance easier. Now that we inlined the components we can fix the problems.
We're only using the `add` helper, which we can easily implement ourselves.
Windvis
added
the
internal
We don't really need it, and the few couple of helpers we use can be easily implemented as a private helper where needed.
This code was under the assumption that the prototype extensions were enabled, which isn't a certainty in projects, and which is removed in Ember 6. We now default to an EmberArray instead.
Windvis
force-pushed
the
table-improvements
branch
from
38c9cb2 to
e727961
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we inlined the components in #525 we made some shortcuts by ignoring linting errors and adding dependencies we didn't really use in other parts of Appuniversum.
This PR removes those shortcuts again.